From: Aaron Campbell <aaron@arbor.net>
To: Simon Kuenzer <simon.kuenzer@neclab.eu>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify master lcore id
Date: Mon, 3 Nov 2014 13:02:02 -0400 [thread overview]
Message-ID: <582DA5F6-0A84-4FDD-8DC6-D8E5C6B1652A@arbor.net> (raw)
In-Reply-To: <1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu>
> On Jul 8, 2014, at 5:28 AM, Simon Kuenzer <simon.kuenzer@neclab.eu> wrote:
>
> + else if (!strcmp(lgopts[option_index].name, OPT_MASTER_LCORE)) {
> + if (!coremask_ok) {
> + RTE_LOG(ERR, EAL, "please specify the master "
> + "lcore id after specifying "
> + "the coremask\n");
> + eal_usage(prgname);
> + return -1;
> + }
Hi Simon,
I think that forcing a particular command line order is not that clean. It might be better to remove the cfg->master_lcore setting from eal_parse_coremask(), and defer the selection of the master lcore until all of the command-line options have been parsed. If —master-lcore was specified, save the value and use that, otherwise rte_get_next_lcore(-1, 0, 0) can return the first bit set in the coremask.
-Aaron
next prev parent reply other threads:[~2014-11-03 16:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 8:28 Simon Kuenzer
2014-07-08 9:42 ` Simon Kuenzer
2014-07-21 16:21 ` Simon Kuenzer
2014-07-22 23:40 ` Hiroshi Shimamoto
2014-07-23 7:50 ` Thomas Monjalon
2014-07-23 8:53 ` Hiroshi Shimamoto
2014-07-23 9:04 ` Thomas Monjalon
2014-07-23 12:05 ` Simon Kuenzer
2014-08-04 2:48 ` Hiroshi Shimamoto
2014-07-23 12:10 ` Simon Kuenzer
2014-11-03 17:02 ` Aaron Campbell
2014-11-03 22:29 ` Thomas Monjalon
2014-07-23 8:03 ` Gray, Mark D
2014-11-03 17:02 ` Aaron Campbell [this message]
2014-11-04 19:00 ` Thomas Monjalon
2014-11-05 15:34 ` Aaron Campbell
2014-11-04 21:40 ` [dpdk-dev] [PATCH v2] eal: add option --master-lcore Thomas Monjalon
2014-11-05 11:54 ` Ananyev, Konstantin
2014-11-05 16:52 ` Thomas Monjalon
2014-11-05 15:34 ` Aaron Campbell
2014-11-05 23:43 ` Simon Kuenzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=582DA5F6-0A84-4FDD-8DC6-D8E5C6B1652A@arbor.net \
--to=aaron@arbor.net \
--cc=dev@dpdk.org \
--cc=simon.kuenzer@neclab.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).