From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ie0-f170.google.com (mail-ie0-f170.google.com [209.85.223.170]) by dpdk.org (Postfix) with ESMTP id 93D2C590C for ; Mon, 3 Nov 2014 17:52:50 +0100 (CET) Received: by mail-ie0-f170.google.com with SMTP id tp5so5705069ieb.29 for ; Mon, 03 Nov 2014 09:02:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arbor.net; s=m0; h=subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=2cjeTKXx/1OgHX3HNLZt1Ev8LBHd9YqBbq70eqt6iGg=; b=LUYhJIr9dEikGAmWbakiKNmPeDFywpjcVd8E07P2ZOsZllt6HADzMCmz00f23cKGqE XEGQr694Dbu/ANmQdxLAizwYb99EPylTjwSpbtpnKr9vMNumSlKx715BnCGqypnfkL48 ANfqtvHN00LxcPp+/36bzQRbfF8hEP2imHY8g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:mime-version:content-type:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=2cjeTKXx/1OgHX3HNLZt1Ev8LBHd9YqBbq70eqt6iGg=; b=EYOHDFIwLv+rLfFSPc6EpXKdYj0xOU7QOwef7ISSCNzU5pDjUfk4++NwJf6wNFW3XE Dtrq1JmEQKE2aGPE/+XN6dRonf/oFt39PfsN25bTH/7FfquaMtGKdl31ErfW0e5gMSLt nPnnBpIc7hKm2DhcCigWZlSqEs3gRJwuNxojvMkXClpmXjQcNxFXaG+XkNP1Pz94zjlh IBVfDTJja72oa/RUtzTL0BDjXZmAOkui7LuksqNavM+lnr5+LKz6K1ahx5njCD7LxV/d eylMSzGZb7zyd/mXv5CmoWaPPk2w3s8OjDnZ+2uhP3y0MLRI9h+xyCp1Nha4Rqvx0A3q T5+w== X-Gm-Message-State: ALoCoQnH9xsbEmOKa1CHdFnr7L2XOk/TIk88clZTzu1g/yvnOvq5CH+xhkrVf0vTFIvP1m283OTI X-Received: by 10.107.6.197 with SMTP id f66mr2693585ioi.81.1415034124489; Mon, 03 Nov 2014 09:02:04 -0800 (PST) Received: from [172.31.1.110] (hlfxns0187w-047055100128.dhcp-dynamic.FibreOp.ns.bellaliant.net. [47.55.100.128]) by mx.google.com with ESMTPSA id i184sm1931905ioi.33.2014.11.03.09.02.03 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 03 Nov 2014 09:02:03 -0800 (PST) Mime-Version: 1.0 (Mac OS X Mail 8.0 \(1990.1\)) Content-Type: text/plain; charset=utf-8 From: Aaron Campbell In-Reply-To: <1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu> Date: Mon, 3 Nov 2014 13:02:02 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: <582DA5F6-0A84-4FDD-8DC6-D8E5C6B1652A@arbor.net> References: <1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu> To: Simon Kuenzer X-Mailer: Apple Mail (2.1990.1) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify master lcore id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Nov 2014 16:52:51 -0000 > On Jul 8, 2014, at 5:28 AM, Simon Kuenzer = wrote: >=20 > + else if (!strcmp(lgopts[option_index].name, = OPT_MASTER_LCORE)) { > + if (!coremask_ok) { > + RTE_LOG(ERR, EAL, "please = specify the master " > + "lcore id after = specifying " > + "the = coremask\n"); > + eal_usage(prgname); > + return -1; > + } Hi Simon, I think that forcing a particular command line order is not that clean. = It might be better to remove the cfg->master_lcore setting from = eal_parse_coremask(), and defer the selection of the master lcore until = all of the command-line options have been parsed. If =E2=80=94master-lcor= e was specified, save the value and use that, otherwise = rte_get_next_lcore(-1, 0, 0) can return the first bit set in the = coremask. -Aaron=