From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 1B91D5585 for ; Fri, 18 Nov 2016 19:16:01 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP; 18 Nov 2016 10:16:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,510,1473145200"; d="scan'208";a="193093964" Received: from sie-lab-212-151.ir.intel.com (HELO [10.237.212.151]) ([10.237.212.151]) by fmsmga004.fm.intel.com with ESMTP; 18 Nov 2016 10:15:59 -0800 To: Fiona Trahe , dev@dpdk.org References: <1479403997-15437-1-git-send-email-fiona.trahe@intel.com> <1479403997-15437-2-git-send-email-fiona.trahe@intel.com> Cc: pablo.de.lara.guarch@intel.com, michalx.k.jastrzebski@intel.com, arkadiuszx.kusztal@intel.com From: John Griffin Message-ID: <582F455F.3030505@intel.com> Date: Fri, 18 Nov 2016 18:15:59 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1479403997-15437-2-git-send-email-fiona.trahe@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] crypto: remove unused digest-appended feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2016 18:16:02 -0000 On 17/11/16 17:33, Fiona Trahe wrote: > The cryptodev API had specified that if the digest address field was > left empty on an authentication operation, then the PMD would assume > the digest was appended to the source or destination data. > This case was not handled at all by most PMDs and incorrectly handled > by the QAT PMD. > As no bugs were raised, it is assumed to be not needed, so this patch > removes it, rather than add handling for the case on all PMDs. > The digest can still be appended to the data, but its > address must now be provided in the op. > > Signed-off-by: Fiona Trahe > --- > drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 2 ++ > drivers/crypto/qat/qat_crypto.c | 18 +----------------- > lib/librte_cryptodev/rte_crypto_sym.h | 10 +--------- > 3 files changed, 4 insertions(+), 26 deletions(-) > Acked-by: John Griffin