From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
dev@dpdk.org, Zhiyong Yang <zhiyong.yang@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix failsafe PMD failure on exit
Date: Tue, 22 May 2018 21:47:28 +0200 [thread overview]
Message-ID: <5833665.TREZe9cROF@xps> (raw)
In-Reply-To: <20180522183509.66644-1-ferruh.yigit@intel.com>
22/05/2018 20:35, Ferruh Yigit:
> vdevs detach on testpmd exit implemented as workaround to fix
> a virtio-user issue. The issue was virtio-user cleanup is not
> called and existing socket file not cleaned up which will fail
> next run.
>
> The vdev cleanup causing problems in failsafe PMD.
>
> Reduce the cleanup to only virtio-user and add a comment that this
> workaround should be converted to a proper cleanup, not something
> specific to virtio-user, and not something specific to vdev and
> testpmd.
>
> Fixes: fe890955114d ("app/testpmd: fix exit for vdevs")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
OK to squash it with above patch.
Thanks for the update.
Note: this patch is not related to failsafe.
There was a deadlock introduced in 18.05-rc1 when detaching failsafe,
but it is fixed by using a recursive lock in vdev.
next prev parent reply other threads:[~2018-05-22 19:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 18:35 Ferruh Yigit
2018-05-22 19:47 ` Thomas Monjalon [this message]
2018-05-22 20:49 ` Ferruh Yigit
2018-05-22 20:50 ` Ferruh Yigit
2018-05-27 4:06 ` Yuanhan Liu
2018-05-27 12:37 ` Thomas Monjalon
2018-06-02 5:01 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5833665.TREZe9cROF@xps \
--to=thomas@monjalon.net \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).