From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2FF55A0524; Fri, 27 Nov 2020 16:30:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0AA76C982; Fri, 27 Nov 2020 16:30:07 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id E6841C97C; Fri, 27 Nov 2020 16:30:03 +0100 (CET) IronPort-SDR: jJJ4FDaKbLXBRVg9Tqt6536W1xci2ZbsbVGYgRttYFwcBGpU7Lk58tNnTlm4ltdSE6zwO22HYV FQnnG2gByqig== X-IronPort-AV: E=McAfee;i="6000,8403,9817"; a="169845983" X-IronPort-AV: E=Sophos;i="5.78,374,1599548400"; d="scan'208";a="169845983" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Nov 2020 07:30:01 -0800 IronPort-SDR: tMph6JSr+vtYrPLWGOR8qXhoTfiOB8JuuKPEw5K+d7WZPImxp6dUYOJ/1svaM6om9DUle4UHoi q3fouptQ2NQg== X-IronPort-AV: E=Sophos;i="5.78,374,1599548400"; d="scan'208";a="548082828" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.247.181]) ([10.213.247.181]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Nov 2020 07:29:59 -0800 To: Thomas Monjalon , techboard@dpdk.org Cc: David Marchand , Bruce Richardson , Anatoly Burakov , David Hunt , Pablo de Lara , Stephen Hemminger , dev@dpdk.org, Conor Walsh , John McNamara , andrew.rybchenko@oktetlabs.ru References: <20201126141832.2277628-1-ferruh.yigit@intel.com> <407e05ab-7a1c-7d14-80d8-c9f613660fd8@intel.com> <8047461.tS4YFHTYsG@thomas> From: Ferruh Yigit Message-ID: <58344dc5-f363-5308-edd3-b833ba18b02a@intel.com> Date: Fri, 27 Nov 2020 15:29:57 +0000 MIME-Version: 1.0 In-Reply-To: <8047461.tS4YFHTYsG@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 5/6] usertools/setup: fix loading vfio module X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/27/2020 1:56 PM, Thomas Monjalon wrote: > 27/11/2020 10:55, Ferruh Yigit: >> On 11/26/2020 6:31 PM, David Marchand wrote: >>> On Thu, Nov 26, 2020 at 3:20 PM Ferruh Yigit wrote: >>>> >>>> script is checking the existing of the kernel module file, but in some >>>> distros kernel modules are stored compressed, like as 'vfio-pci.ko.xz'. >>> >>> Since this script expects modprobe to be installed (coming with kmod >>> tools), it means modinfo is available. >>> Checking for module availability should be "modinfo vfio-pci". >>> >> >> +1, that is definitely better. >> >> I can send a new version with it if we decide to keep the script. > > It is too late to improve this old script. > We should let it die and rest in peace. > >> Mainly we are tying to decide to remove the script or keep with the changes in >> this set. > > I appreciate your effort Ferruh. > It shows that almost nothing is worth to keep in this script. > >> There aren't still much comment on it, only comment by you in favor of removal, >> I haven't seen any comment to keep the script. >> >> Added more folks for comment, also techboard comments are welcome. > > My opinion is that we should follow the deprecation notice > and remove the script in 20.11. > If someone wants to keep the same VFIO manipulations, > it is possible to copy/paste from old versions. > > OK, there is already a patch to remove it, updating this series as rejected.