From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 0/2] 10G PMD: vectorized RX and TX functions
Date: Thu, 12 Jun 2014 00:33:51 +0200 [thread overview]
Message-ID: <5836928.Hv09yK42VY@xps13> (raw)
In-Reply-To: <59AF69C657FD0841A61C55336867B5B01AA35278@IRSMSX103.ger.corp.intel.com>
2014-06-11 22:27, Richardson, Bruce:
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > You are introducing a new option CONFIG_RTE_IXGBE_RX_OLFLAGS_DISABLE.
> > I feel a comment in the code would be helpful here.
>
> Comment in the code, or in the config file where the option is defined?
There are several config files so I think it's more appropriated in the code.
And it's not in DPDK habit to add comments in config files.
We are used to grep in code ;)
--
Thomas
next prev parent reply other threads:[~2014-06-11 22:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 9:56 Bruce Richardson
2014-05-12 9:56 ` [dpdk-dev] [PATCH v2 1/2] 10G PMD: New vectorized functions for RX/TX Bruce Richardson
2014-05-12 9:56 ` [dpdk-dev] [PATCH v2 2/2] 10G PMD: enable vector PMD compile for 64b linux Bruce Richardson
2014-06-06 7:11 ` [dpdk-dev] [PATCH v2 0/2] 10G PMD: vectorized RX and TX functions Cao, Waterman
2014-06-11 22:19 ` Thomas Monjalon
2014-06-11 22:27 ` Richardson, Bruce
2014-06-11 22:33 ` Thomas Monjalon [this message]
2014-06-13 22:52 ` [dpdk-dev] [PATCH v3] 10G PMD: New vectorized functions for RX/TX Bruce Richardson
2014-06-16 8:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5836928.Hv09yK42VY@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).