From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f174.google.com (mail-we0-f174.google.com
 [74.125.82.174]) by dpdk.org (Postfix) with ESMTP id 5D0F3B10A
 for <dev@dpdk.org>; Thu, 12 Jun 2014 00:34:22 +0200 (CEST)
Received: by mail-we0-f174.google.com with SMTP id u57so416230wes.33
 for <dev@dpdk.org>; Wed, 11 Jun 2014 15:34:37 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=Flem9tG3AQU3/3iAS8xki9w2jtO8sNJ6qo/EicV7xp8=;
 b=aEtGryMtaqxjFqZ/IA4hlfW0VJ6/HNONER26Ql2XFeRUXdW/xA/UTG0LRYwj0c6Lav
 eW5fodgY8g2ZxhdOyzTXzGaNRBLaJsta6HI5pFLdaXCXiWb0l5pZlCGduMSHibATFQiF
 q3ASy0ccxvaQZGCTMQWBZWl5FaemMmehnTFHOhwdODvt0R8OkrTcZs0HAoYuZ5afss9a
 de0XS4d7ssJn4ypkHG7wYaBiCgMRge7zVySPK+TOY8gTTCfS0aA6FIijbQnvQP48pjGl
 SjqDYErCrE3rxHvM7KscWQOVil5FxDKROige83bWgbByMP/6DuZCWjhVPZk+KcBuI1ll
 cdtQ==
X-Gm-Message-State: ALoCoQk2hRnFi3UT9A7dlfRiLpPfzu4o/Gw+zw7mfZbQH+utGOeaOuan16KLydddBy8m+rS7vqJS
X-Received: by 10.180.90.233 with SMTP id bz9mr986197wib.42.1402526077157;
 Wed, 11 Jun 2014 15:34:37 -0700 (PDT)
Received: from xps13.localnet (ip-96.net-80-236-123.rev.numericable.fr.
 [80.236.123.96])
 by mx.google.com with ESMTPSA id ds9sm29680201wib.20.2014.06.11.15.34.35
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 11 Jun 2014 15:34:36 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Date: Thu, 12 Jun 2014 00:33:51 +0200
Message-ID: <5836928.Hv09yK42VY@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; )
In-Reply-To: <59AF69C657FD0841A61C55336867B5B01AA35278@IRSMSX103.ger.corp.intel.com>
References: <1399888587-21068-1-git-send-email-bruce.richardson@intel.com>
 <3079600.trYA8PKFWl@xps13>
 <59AF69C657FD0841A61C55336867B5B01AA35278@IRSMSX103.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 0/2] 10G PMD: vectorized RX and TX
	functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Jun 2014 22:34:22 -0000

2014-06-11 22:27, Richardson, Bruce:
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > You are introducing a new option CONFIG_RTE_IXGBE_RX_OLFLAGS_DISABLE.
> > I feel a comment in the code would be helpful here.
> 
> Comment in the code, or in the config file where the option is defined?

There are several config files so I think it's more appropriated in the code.
And it's not in DPDK habit to add comments in config files.
We are used to grep in code ;)

-- 
Thomas