From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4B32436D1; Tue, 12 Dec 2023 12:53:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9FD6542E23; Tue, 12 Dec 2023 12:53:07 +0100 (CET) Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by mails.dpdk.org (Postfix) with ESMTP id 5547D42E1A for ; Tue, 12 Dec 2023 12:53:06 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.88.163]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4SqH5m6nh5z1L9dg; Tue, 12 Dec 2023 19:51:56 +0800 (CST) Received: from kwepemm000004.china.huawei.com (unknown [7.193.23.18]) by mail.maildlp.com (Postfix) with ESMTPS id C853F1800C8; Tue, 12 Dec 2023 19:53:03 +0800 (CST) Received: from [10.67.121.59] (10.67.121.59) by kwepemm000004.china.huawei.com (7.193.23.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 12 Dec 2023 19:53:03 +0800 Message-ID: <583cbed5-5bd4-ab4b-64d9-7438fded310d@huawei.com> Date: Tue, 12 Dec 2023 19:53:02 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH 2/3] examples/l2fwd-keepalive: don't use EAL logtype To: Stephen Hemminger , References: <20231211172437.61958-1-stephen@networkplumber.org> <20231211172437.61958-3-stephen@networkplumber.org> From: "lihuisong (C)" In-Reply-To: <20231211172437.61958-3-stephen@networkplumber.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.59] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm000004.china.huawei.com (7.193.23.18) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Huisong Li 在 2023/12/12 1:23, Stephen Hemminger 写道: > EAL logtype should be reserved for EAL library. > This example is already using printf() so just print > errors to stderr. > > Signed-off-by: Stephen Hemminger > --- > examples/l2fwd-keepalive/shm.c | 21 +++++++-------------- > 1 file changed, 7 insertions(+), 14 deletions(-) > > diff --git a/examples/l2fwd-keepalive/shm.c b/examples/l2fwd-keepalive/shm.c > index 7c7a9ea8ea3c..cbeeb511ef07 100644 > --- a/examples/l2fwd-keepalive/shm.c > +++ b/examples/l2fwd-keepalive/shm.c > @@ -5,7 +5,6 @@ > #include > > #include > -#include > #include > > #include "shm.h" > @@ -28,28 +27,23 @@ struct rte_keepalive_shm *rte_keepalive_shm_create(void) > fd = shm_open(RTE_KEEPALIVE_SHM_NAME, > O_CREAT | O_TRUNC | O_RDWR, 0666); > if (fd < 0) > - RTE_LOG(INFO, EAL, > - "Failed to open %s as SHM (%s)\n", > - RTE_KEEPALIVE_SHM_NAME, > - strerror(errno)); > + fprintf(stderr, "Failed to open %s as SHM (%s)\n", > + RTE_KEEPALIVE_SHM_NAME, strerror(errno)); > else if (ftruncate(fd, sizeof(struct rte_keepalive_shm)) != 0) > - RTE_LOG(INFO, EAL, > - "Failed to resize SHM (%s)\n", strerror(errno)); > + fprintf(stderr, "Failed to resize SHM (%s)\n", strerror(errno)); > else { > ka_shm = (struct rte_keepalive_shm *) mmap( > 0, sizeof(struct rte_keepalive_shm), > PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); > close(fd); > if (ka_shm == MAP_FAILED) > - RTE_LOG(INFO, EAL, > - "Failed to mmap SHM (%s)\n", strerror(errno)); > + fprintf(stderr, "Failed to mmap SHM (%s)\n", strerror(errno)); > else { > memset(ka_shm, 0, sizeof(struct rte_keepalive_shm)); > > /* Initialize the semaphores for IPC/SHM use */ > if (sem_init(&ka_shm->core_died, 1, 0) != 0) { > - RTE_LOG(INFO, EAL, > - "Failed to setup SHM semaphore (%s)\n", > + fprintf(stderr, "Failed to setup SHM semaphore (%s)\n", > strerror(errno)); > munmap(ka_shm, > sizeof(struct rte_keepalive_shm)); > @@ -87,7 +81,7 @@ void rte_keepalive_relayed_state(struct rte_keepalive_shm *shm, > * ka_agent is not active. > */ > if (sem_getvalue(&shm->core_died, &count) == -1) { > - RTE_LOG(INFO, EAL, "Semaphore check failed(%s)\n", > + fprintf(stderr, "Semaphore check failed(%s)\n", > strerror(errno)); > return; > } > @@ -95,8 +89,7 @@ void rte_keepalive_relayed_state(struct rte_keepalive_shm *shm, > return; > > if (sem_post(&shm->core_died) != 0) > - RTE_LOG(INFO, EAL, > - "Failed to increment semaphore (%s)\n", > + fprintf(stderr, "Failed to increment semaphore (%s)\n", > strerror(errno)); > } > }