From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2305E44103; Wed, 29 May 2024 16:39:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B7F3E402CD; Wed, 29 May 2024 16:39:01 +0200 (CEST) Received: from wfhigh7-smtp.messagingengine.com (wfhigh7-smtp.messagingengine.com [64.147.123.158]) by mails.dpdk.org (Postfix) with ESMTP id 1DDB7402B9; Wed, 29 May 2024 16:39:00 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfhigh.west.internal (Postfix) with ESMTP id CEF7F18000BB; Wed, 29 May 2024 10:38:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 29 May 2024 10:38:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1716993538; x=1717079938; bh=AFN187XGLlATvPSaQhb3s3a+SlGFs3Icg2+/Cwyq0Wc=; b= eWJ14GFn1K2v1Gosn39/zLH0OBRm4xS7xkllUfVTOD82cl1JoGrpU9NKKy3qa5nx FJxxqmYcuqlSAwMz/Nv7iuzRmgRMnt9l65LF9ocjL0X6jnV0217+ehXJvYbWdW3G /wku1Js+mzW5lRfv4DuYFVU7vWs2bqwtglzJCA1AB+F8Zs22Yd7p8pg+12PS8tfR nRlWlD1O56yuMF+QnI9rj5tP70FUID5irraR3tfWhEtO1fWWeD5YLznYB4VpCI2r A/Lb4PyaLdEO1t9FenYOkM8t4Dl2ZXUSiWQzwj7py56O1eBZrnNx7/Bmo1YJiwh3 DqYOS9gNWEbwZ4ZKxA5sYw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1716993538; x= 1717079938; bh=AFN187XGLlATvPSaQhb3s3a+SlGFs3Icg2+/Cwyq0Wc=; b=n cyo3B20ZVstZBRE2QJdko4pCjj9g9WpY12Xrz24U3vEPht7OwI16IKtb+s5NCWkS qQqE0sUDAJhvHFKlP+PCSdWOB5G6Pb8pDlinmmp9ZPVdcF0MZ/vTew0S7KkirZPU 8qVe+rufMs1ivNqOrOdF7mCFEiICHTHkohj0DlOA6dDndWVMfSeHTAMsLx837iiG 3qFdUQsQznaDpm0ZiQokdXsU0mYN6klVhXn7tkw5VVRx1HHAcFRaA9PZH3opr7aB 304d7/qRwwUr9AMten6QdOCUdyCHoYxJft3NNcUAHecdQi1SUOVwLLGD4WRhYZmJ QoZ8OOg2i6w0Mo/zA0jZw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdekuddgjeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeekueevjeffjeegtdeggeek gfdvuefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 29 May 2024 10:38:57 -0400 (EDT) From: Thomas Monjalon To: Tyler Retzlaff Cc: Stephen Hemminger , dev@dpdk.org, Harry van Haaren , Remy Horton , Reshma Pattan , stable@dpdk.org Subject: Re: [PATCH] latencystats: fix missing f suffix on literal float Date: Wed, 29 May 2024 16:38:55 +0200 Message-ID: <5842625.1B3tZ46Xf9@thomas> In-Reply-To: <20240415231405.GA31632@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1713216746-25584-1-git-send-email-roretzla@linux.microsoft.com> <20240415151738.2b85fc05@hermes.local> <20240415231405.GA31632@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 16/04/2024 01:14, Tyler Retzlaff: > On Mon, Apr 15, 2024 at 03:17:38PM -0700, Stephen Hemminger wrote: > > On Mon, 15 Apr 2024 14:32:26 -0700 > > Tyler Retzlaff wrote: > > > > > Add missing f suffix to floating point literal to avoid warning about > > > truncation from double to float. > > > > > > Fixes: 5cd3cac9ed22 ("latency: added new library for latency stats") > > > Cc: reshma.pattan@intel.com > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Tyler Retzlaff > > > --- > > > - const float alpha = 0.2; > > > + const float alpha = 0.2f; > > > > The use of floating point in fast path here is unnecessary. > > Even without doing the full per-core values, this could just change > > to an alpha of .25 and use fast fixed point math. > > agree, though my thoughts are make this code correct optimization is for > the maintainer. if they submit an alternate series i can withdraw this > patch. otherwise i think we should take it as-is. OK to fix build warning now. Applied, thanks.