From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 436F4A0548; Wed, 15 Jun 2022 08:20:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F13F140222; Wed, 15 Jun 2022 08:20:39 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id B9DA240220 for <dev@dpdk.org>; Wed, 15 Jun 2022 08:20:38 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 646C5320090A; Wed, 15 Jun 2022 02:20:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 15 Jun 2022 02:20:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1655274034; x= 1655360434; bh=+5QqguqTx1LwjCA2qN+O2RdItKbvb1t7qGGUjKeVqSU=; b=e /M3q7XDtKpg82s7akMqyLC+o1VikBvoGB/B0QW1iLG+LG5MyZsZ2wc7+2VMgDOmS JAD6229Nv8F/5CJLWFYIYT5W8gFxv2+2+CcG6fgckT+KU/tsiUAoimSGGPHiLmIE SOmctpM4YRYFhddfPxja6LR5h9SQgLHARLg6ybR/9vbO1UuGQgvfjkugc2Mh3Eq8 xw8HTE/ISXVeg5ST1lGEyaAUBjn2lz7zuIgUFUXRP51ELi7+DovjQGuouvQqpzKM uLTZJauplqUcF9MdtuVPFJDi9cGVyM+5tlPzgEL+PxrIwgug7MoagjJ3od+ihgaK f81b5jpXVRHuKBbNATnCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1655274034; x= 1655360434; bh=+5QqguqTx1LwjCA2qN+O2RdItKbvb1t7qGGUjKeVqSU=; b=W jcceZInlDhYJV5nVR9mXujwQx3sbBc5Gicv44u1w1y+unH5bVJUdIru2kgf8WRIn 4PGlaIZ/Rv1r3VOD3o+bycmriJv/cUn2nd+ziq1f2skxce/0wPzWOf8gvf34oy/E PzWcXzc4B60XD9UOgRzZ8k38KgG0xBGCzsIM3eR6yS55U3WJcDtENU2gsb6kzOwI c1xlknsNioR54Z+LiO7h29UvPZykh1QrvI6mizhdPJKMtIOBzhPIjG9blmuJsK5X FxTOjj1aQpCMeYLSpYmwikwbsvre/ojGAo+wgcHbjt6RO5z/NU+zDwNh8wfzFjDW HjlDJ6qc+IorZHDxqlkfQ== X-ME-Sender: <xms:MnqpYmTtaPEbQsAN_f2EX0cR-OyyG9gDxqbiW4hXnj78VufgbRVJbA> <xme:MnqpYrwHG-dSXf68Txd4AVlUrWhy7_sYnhNczyc3BUPfg_3UIRzrIP9w_vAjjQzY9 3L2zgxnJlpqMkzqsA> X-ME-Received: <xmr:MnqpYj2LJdDRImU0JaM8Cuz6Y9ozkctauaVveIexcqFeiCLH_mA9s81Dhb268YeExdB9WO87UgN2Yblcl12zoHO-Yg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedruddvtddguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:MnqpYiCDNOK2-aHhVEKZCPH_lYUd_rb-ylGmjs1N-5dBq7qEvEM8cQ> <xmx:MnqpYvhY7lth4hBlmm4Al_4U9h8AZVI91g_QKS71-GAZc3J2ffrvrw> <xmx:MnqpYupN8d11WNC_yO732caA71AqLaHMKFQMy3GWvrwkWZ1QYzQwEA> <xmx:MnqpYnbSLLXlXBH7tawExIRKLi1YIgVp0igu0CBmqe_0tqYoX83pMQ> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 15 Jun 2022 02:20:33 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Jakub Palider <jpalider@marvell.com> Cc: dev@dpdk.org, david.marchand@redhat.com Subject: Re: [PATCH v2] devtools: ensure proper tag sequence Date: Wed, 15 Jun 2022 08:20:31 +0200 Message-ID: <5848204.lOV4Wx5bFT@thomas> In-Reply-To: <20220613222143.1436424-1-jpalider@marvell.com> References: <20220613222143.1436424-1-jpalider@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 14/06/2022 00:21, jpalider@marvell.com: > + SEQ[0] = "Coverity issue"; > + SEQ[1] = "Bugzilla ID"; > + SEQ[2] = "Fixes"; > + SEQ[3] = "Cc"; > + SEQ[4] = "^$"; > + SEQ[5] = "Suggested-by"; > + SEQ[6] = "Reported-by"; > + SEQ[7] = "Signed-off-by"; > + latest = 0; Do you think you could check that Review, Ack and Test are added after the first Signed-off? > +Tag order > +~~~~~~~~~ > + > +There is a pattern indicating how certain tags should relate to each other. > + > +Example of proper tag sequence:: > + > + Coverity issue: > + Bugzilla ID: > + Fixes: > + Cc: > + > + Suggested-by: > + Reported-by: > + Signed-off-by: Given it is an example, you could add Reviewed-by, Acked-by and Tested-by. > + > +Between first and second tag section there is and empty line. > + > +While ``Signed-off-by:`` is an obligatory tag and must exists in each commit, > +all other tags are optional. Any tag, as long as it is in proper location > +to other adjacent tags (if present), may occur multiple times. > + > +Other tags shall be laid out in a chronological order. Yes, after the first Signed-off-by.