From: Remy Horton <remy.horton@intel.com>
To: harry.van.haaren@intel.com
Cc: Thomas Monjalon <thomas@monjalon.net>,
dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] lib/metrics: add check for invalid metric keys
Date: Fri, 27 Jul 2018 08:00:34 +0100 [thread overview]
Message-ID: <58583116-33e8-ae31-2b2f-079f3390bc47@intel.com> (raw)
In-Reply-To: <3135038.1Nyv25uGYd@xps>
Harry,
Can you add the following to the cheat-sheet? Don't do many patches
these days, and I'm not the only one to miss these recently..
..Remy
On 26/07/2018 19:11, Thomas Monjalon wrote:
> Remy,
> You are not new to DPDK. Please pay attention to details:
> - subject does not start with lib/
> - fixes of old commits must have Cc: stable@dpdk.org
>
> 20/07/2018 17:31, Ferruh Yigit:
>> On 7/6/2018 2:21 PM, Remy Horton wrote:
>>> This patchset adds a check to rte_metrics_update_values()
>>> that prevents the updating of metrics when presented with
>>> an invalid metric key. Previously, doing the latter could
>>> result in a crash.
>>>
>>> Fixes: 349950ddb9c5 ("metrics: add information metrics library")
>>>
>>> Signed-off-by: Remy Horton <remy.horton@intel.com>
>>
>> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Applied, thanks
>
>
prev parent reply other threads:[~2018-07-27 7:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 13:21 Remy Horton
2018-07-20 15:31 ` Ferruh Yigit
2018-07-26 18:11 ` Thomas Monjalon
2018-07-27 7:00 ` Remy Horton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58583116-33e8-ae31-2b2f-079f3390bc47@intel.com \
--to=remy.horton@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).