From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6FBC0A00C2; Thu, 24 Nov 2022 20:42:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0CDBD40156; Thu, 24 Nov 2022 20:42:14 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 05FB24014F for <dev@dpdk.org>; Thu, 24 Nov 2022 20:42:12 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 364D65C0159; Thu, 24 Nov 2022 14:42:12 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 24 Nov 2022 14:42:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1669318932; x= 1669405332; bh=vbgoC9cQ4cAzjR35MuCPlWDHE8GxWtYAM0FGxI0PVQ8=; b=Y kk8dHMMKR6IuvyzGK4hDI5EKj5D8m/sKZaFI5u3/lkVavcnUOlQvk03AfzsY211K YehcLhYhbFMSN0SaxfiPjo0Gd3QIxz/zf7DP/YmcqjMq3GT86QXH6qXPGeaOzsqA AieBJF8v0vE+58so09HrnQ+td6ihO2VfkNBXTg9me13iVc4NSnqsGUEpE7Y9GaDZ eJ25CO86vzG9c7+wD4pQnxBaahHmMXbN/mXvHAH2UEa9FNi8TnDz2jaUZUIdrvTO B3SkkpsPP/YhVaq1Cz/5qxGKh0O5kuvHvATJKvQjXsOFES3wJ0r7yz6AL03D+xWN rZcDYahiddsmxpM0n98Rg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1669318932; x= 1669405332; bh=vbgoC9cQ4cAzjR35MuCPlWDHE8GxWtYAM0FGxI0PVQ8=; b=b C8MdxzOkKXhkDo688+lXpwiOo7bEWnH7e5m3+Lfqn8hVOsrOwn+/hzEyk8TzkGr5 zQHi/vxzZp7FqYoeKqFb9jIOA3POmwOES24RzBl+arr/fTcWacqU1SBwUdzV2UDO jcJaRgcRK84uIrdEV/iAVeKIUcdE9hJVvYQzakTYJSScW2X0yyVmlMqkTjphxs/4 1QwYauacNWTrykLvH20P4pJJhmKIP1rpaJ5gLYVvud+I6v9uNsvBeOL4tXs4h0v4 Vc0wiV1xsGQ9eqIlY3xutBuFi5KQLKBvsZiogyaz/6hu5ZluEWaihQcWa5URH3fk 22X5q72hGODqLXoWIIzDw== X-ME-Sender: <xms:E8l_Y4XrQYJy7cDE6VGdmazJSA8ItDfweHXCKM3sTxfD2GlJkR3tYg> <xme:E8l_Y8nhPGy-0yHooJlH1w8ehDiA2l14WHyC99eWMzWih6FpHq4tpZEyDvIROszlg rpOYr-ebHzePAcUNg> X-ME-Received: <xmr:E8l_Y8YQczPh9TFFspfczIa8y5wlp2XhgNj4Kl-TyQMitiFMFF18BXF5PDB0sNIB1R_DlerABh_zeFGc0rdwKG1zHg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrieefgdduvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:E8l_Y3V0e7iMgRVwAqdi0wVG2oGj7NUACPLmmn4v-l17Q1Qfk7SCuA> <xmx:E8l_Yyl4UYVRr_t8E2uDEv_XtXDdM3WBaXEQ_jRWtrcFw-wAo6bRmw> <xmx:E8l_Y8ebV8q1IvuRz_XlzG_xBsoCZHQ2slP45-FfhYhydnk1rbNy1w> <xmx:FMl_Y3wB2lp2b8ELB8Ym2-DhGgpgW-KR5Fu39hmrAzki1E5hgA1arw> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 24 Nov 2022 14:42:11 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: Ferruh Yigit <ferruh.yigit@amd.com> Cc: David Marchand <david.marchand@redhat.com>, dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com> Subject: Re: [PATCH v5] mailmap: add file to DPDK Date: Thu, 24 Nov 2022 20:42:09 +0100 Message-ID: <5858528.alqRGMn8q6@thomas> In-Reply-To: <a405343e-c03e-9678-2438-78e6f10973a4@amd.com> References: <20201020130722.304989-1-bruce.richardson@intel.com> <2605498.Isy0gbHreE@thomas> <a405343e-c03e-9678-2438-78e6f10973a4@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 24/11/2022 18:34, Ferruh Yigit: > On 11/24/2022 5:26 PM, Thomas Monjalon wrote: > > 24/11/2022 18:21, Ferruh Yigit: > >> On 11/24/2022 3:44 PM, David Marchand wrote: > >>> From: Bruce Richardson <bruce.richardson@intel.com> > >>> > >>> Since a number of contributors to DPDK have submitted patches to DPDK > >>> under more than one email address, we should maintain a mailmap file to > >>> properly track their commits using "shortlog". > >>> > >>> It also helps fix up any mangled names, for example, with > >>> surname/firstname reversed, or with incorrect capitalization. > >>> By keeping this file in the DPDK repository, rather than committers > >>> maintaining their own copies, it allows individual contributors to edit > >>> it to update their own email address preferences if so desired. > >>> > >>> While at it, update our checkpatches.sh script and add some > >>> documentation to help new contributors. > >>> > >>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> > >>> Signed-off-by: David Marchand <david.marchand@redhat.com> > >> > >> <...> > >> > >>> @@ -148,6 +148,9 @@ Make your planned changes in the cloned ``dpdk`` repo. Here are some guidelines > >>> > >>> * Follow the :ref:`coding_style` guidelines. > >>> > >>> +* If you are a new contributor, or if your mail address changed, please update the ``.mailmap`` file. > >> > >> There is no benefit for new contributors to update .mailmap file, but it > >> adds another thing to update. > >> > >> I think it is simpler to keep .mailmap only for users that has multiple > >> email address in the git repo, and ask only from contributors in this > >> catagory to update the .mailmap instead of all contributors. > > > > We are doing checks on name and email. Typos are very common. > > So we are maintaining such a file privately. > > We would like to make it public so people can change it if needed. > > > > If it looks a problem for newcomers, we can reword the doc to say > > if they are missing in the file and not added themselves, > > it will be added with their first patch by maintainers. > > Is it better? > > > > ACK, this is an internal file for project maintenance, so I think better > to batch update it per release etc.. (This approach also may give easy > list of new contributors for that release.) I prefer to squash the change with the first patch. So the check runs for next patch. In any case, we can get the list of new contributors easily this way.