From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 99338A0A05;
	Wed, 20 Jan 2021 10:23:55 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 45C33140D13;
	Wed, 20 Jan 2021 10:23:55 +0100 (CET)
Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com
 [64.147.123.17])
 by mails.dpdk.org (Postfix) with ESMTP id 8637A140D21
 for <dev@dpdk.org>; Wed, 20 Jan 2021 10:23:53 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
 by mailnew.west.internal (Postfix) with ESMTP id 41BD813AC;
 Wed, 20 Jan 2021 04:23:51 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Wed, 20 Jan 2021 04:23:52 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm3; bh=
 1jU5lm9SB2SAJxzWVFJTsEt4L+369pYuJKQkOZ8p6RY=; b=UG0Bm1WZ+CRhbMh9
 tdvL54EM/ct6baiz/flUiCg2ANP+Wj4xGYmfcLtnbK0U4aVrdYHSKTDbFKx4qsc2
 mFmZVIKyjz8WoF7nexd32vcFpQqMd4Il9XGYITNelmytyNphfVsSW8xEkCFG+LMZ
 zxBnNAYRe0XWsys0z8I1Z7AGVuhOuB/+2Q/FApFZTEAYbvmyThiZHdkYK+KSCL0Y
 /hOpu3UThtLeP0+FNY4zgr6fw+2Q+qnnCa71gCMUekrsoU1Fbs0Sz2DL5YgydAZP
 s8reSWRgrISz1fd/jef5Yv/mRRE9CihXxE+5jBM3P1GHlk3kuGJ88ETb15xajhHk
 iV1ggw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=1jU5lm9SB2SAJxzWVFJTsEt4L+369pYuJKQkOZ8p6
 RY=; b=i+QXS9WpD7n86WylXJ48Fj2DFCPz9sV0XJZKfjzCACMF2YxtNWkTGABKB
 KyLv6ICejoMB2ZTqkvnfbcUFmi6Vl7lnBXyuL9PlBs7LHqb9DvI5S4p0khSLchAp
 eagPh8C3VWAwjJzauznr65Id1rKJDG2rvBLfaUhIjFxgIKbPjc4XIxr2tlLudvKn
 UZIHnICIhTxuyZx40dnAW0Jw59/TRdCDHeIPPDpYVNFsQ9UIwTRo3yr6wPZ14aPB
 ECePgNDb0u0gUMRqo+8tcU+GjY21x6A4eSkpSh2sOUUYCqt6BWen+4cAuZE/dMYU
 29Vx+NkThaNkrP1yA7AymkllLMlog==
X-ME-Sender: <xms:pvYHYCoVTjIFnk3r666hSeb2_o58waEXBRYqVJ9ef2fHa_JdLRgnjA>
 <xme:pvYHYArb8MgNF7hLLSls-HYZOOODGAAL0aim0pacN-2-ZjdiTw8fedthytxuyYBiN
 NgHh6A9Q245Rnqdlw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddvgddtgecutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
 fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
 ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf
 frrghtthgvrhhnpeffgefguefhfeevkeeltedtvdfhteefvdduteekffetgefgteehjeeg
 veffteegfeenucffohhmrghinhepohgsjhdrugdqohdpughpughkrdhorhhgnecukfhppe
 ejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr
 mhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght
X-ME-Proxy: <xmx:pvYHYHOX8INcQxH8VrjMOZJKWCRsaSSiLyvDKRssdCJ5E5svjPw3Hw>
 <xmx:pvYHYB46afIErgzTxzcqwWA6YWK_sqr4xwZaWszd22TUUjqEvGdYew>
 <xmx:pvYHYB538JQoRfR7Qpe66GRUIdsEvlKmPFVbH9V_mpHCnzhqdU4OBw>
 <xmx:pvYHYNiQjh1sdlZIBaMx9PYcING7PlZ76_46NhASPbBnixoflGWDCpzynmI>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 226FA1080057;
 Wed, 20 Jan 2021 04:23:49 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Tal Shnaiderman <talshn@nvidia.com>,
 David Marchand <david.marchand@redhat.com>
Cc: Ali Alnubani <alialnu@nvidia.com>, Ferruh Yigit <ferruh.yigit@intel.com>,
 Odi Assli <odia@nvidia.com>, "Rong, Leyi" <leyi.rong@intel.com>, "Zhang,
 Qi Z" <qi.z.zhang@intel.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
 "Richardson, Bruce" <bruce.richardson@intel.com>, "Xing,
 Beilei" <beilei.xing@intel.com>, "Kadam, Pallavi" <pallavi.kadam@intel.com>,
 "Menon, Ranjit" <ranjit.menon@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
 Raslan Darawsheh <rasland@nvidia.com>
Date: Wed, 20 Jan 2021 10:23:46 +0100
Message-ID: <5859779.zrh4IzKrC7@thomas>
In-Reply-To: <CAJFAV8y3m4ucODUPazNZR2gMJ2hDiVpkbOmUXe4B5sGCL2J5QA@mail.gmail.com>
References: <20201215021945.103396-1-leyi.rong@intel.com>
 <DM6PR12MB3945A6FE02C47F856D48415BA4A20@DM6PR12MB3945.namprd12.prod.outlook.com>
 <CAJFAV8y3m4ucODUPazNZR2gMJ2hDiVpkbOmUXe4B5sGCL2J5QA@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v3 0/3] AVX512 vPMD on i40e
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

20/01/2021 09:36, David Marchand:
> On Wed, Jan 20, 2021 at 7:26 AM Tal Shnaiderman <talshn@nvidia.com> wrote:
> > > The patch "add AVX512 vector path" also caused a build failure when cross
> > > compiling on Linux using mingw, and it's still reproducing in next-net
> > > (517969c95).
> > >
> > > ```
> > > $ meson --werror --buildtype=debugoptimized --cross-file config/x86/cross-
> > > mingw -Dexamples=helloworld build  && ninja-build -C build -j32
> > >
> > > [221/232] Generating symbol file lib/librte_mbuf-21.dll.p/librte_mbuf-
> > > 21.dll.symbols
> > > [222/232] Generating symbol file lib/librte_hash-21.dll.p/librte_hash-
> > > 21.dll.symbols
> > > [223/232] Linking target lib/librte_net-21.dll [224/232] Compiling C object
> > > drivers/net/i40e/libi40e_avx512_lib.a.p/i40e_rxtx_vec_avx512.c.obj
> > > FAILED: drivers/net/i40e/libi40e_avx512_lib.a.p/i40e_rxtx_vec_avx512.c.obj
> > > ...
> > > drivers/net/i40e/libi40e_avx512_lib.a.p/i40e_rxtx_vec_avx512.c.obj.d -o
> > > drivers/net/i40e/libi40e_avx512_lib.a.p/i40e_rxtx_vec_avx512.c.obj -c
> > > ../../root/dpdk/drivers/net/i40e/i40e_rxtx_vec_avx512.c
> > > {standard input}: Assembler messages:
> > > {standard input}:112: Error: invalid register for .seh_savexmm {standard
> > > input}:114: Error: invalid register for .seh_savexmm ...
> > > ...
> > > {standard input}:25351: Error: invalid register for .seh_savexmm {standard
> > > input}:25352: Error: invalid register for .seh_savexmm [225/232] Generating
> > > symbol file lib/librte_net-21.dll.p/librte_net-21.dll.symbols
> > > ninja: build stopped: subcommand failed.
> > > ```
> > >
> > > OS: Fedora 32
> > > Meson: 0.55.3
> > > MinGW: Fedora MinGW 9.2.1-6.fc32
> > >
> > > - Ali
> >
> > Those errors were detected in the CI tests for this patch [1], we should pay more attention to those now that 2 PMDs are supported on Windows.
> >
> > [1]: https://lab.dpdk.org/results/dashboard/patchsets/15164/
> 
> I won't grmbl about how CI reports are not being looked at (or maybe I
> just did :)).
> 
> This simple patch seems to work for me:
> 
> diff --git a/drivers/net/i40e/meson.build b/drivers/net/i40e/meson.build
> index c0acdf4fd4..c9a1a50407 100644
> --- a/drivers/net/i40e/meson.build
> +++ b/drivers/net/i40e/meson.build
> @@ -54,7 +54,7 @@ if arch_subdir == 'x86'
>                 cc.has_argument('-mavx512f') and
>                 cc.has_argument('-mavx512bw'))
> 
> -       if i40e_avx512_cpu_support == true or i40e_avx512_cc_support == true
> +       if not is_windows and (i40e_avx512_cpu_support == true or
> i40e_avx512_cc_support == true)
>                 cflags += ['-DCC_AVX512_SUPPORT']
>                 avx512_args = [cflags, '-mavx512f', '-mavx512bw']
>                 if cc.has_argument('-march=skylake-avx512')
> 
> 
> If nobody has a better fix, I'll send it later.


For info, I don't reproduce the compilation issue on my machine.