From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 609F9A04FE; Tue, 9 Jun 2020 17:07:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 49C311BE83; Tue, 9 Jun 2020 17:07:32 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130058.outbound.protection.outlook.com [40.107.13.58]) by dpdk.org (Postfix) with ESMTP id 1ADB51BC24 for ; Tue, 9 Jun 2020 17:07:31 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UjVwJ13KjJs+rTRAICuTg9TpI4VCYwc0GRcHULYI3tAepF+rRLTHqBljgrsn0mNU7VkPEvQtnS3vagS69yIKYoWOQgR9tNZZ7dzx98ClIZJd4ch1zg2HtF30cTiiTl8RFlq5ygT9W2ysJVHf+uEiQf4R/qSs9Q/hbxNQj4DjKYpWiMVUAJeqextse0ZpQqZJHXXmRFaD6s6l5rn3557+ZU6byqJNleVo61hz+CvwK3JL26H8C3CwZaB1wefrNDf8trc+7bdAEyb+6BSPmRwlux+CTffIUX6E/n1oUT5NtykSQzvMyAIwYB74mcEF8/EVFsIQe3u0Iqv9kKfpkroQ6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6RQ6YlzPMMq0kE999r0S63Hij5C0T5NsCXaPraxcCi4=; b=IO7O3JhwP/MJNk4bTnybmEXCoiTxXUHyyBTYAd5ScHRpPRF1xfiShakwxy3iLxNFGkkPT9+B8SIKXKJRi2LBg1kMrH17uKvQHtgEBwcQfAbUUeVy2bqbFD/L80a69mAurXIdL8ApUH+2qamJV65RFWxjl4g2f/Ip1jgOABOGWft8MXxVcSzWPZh3244d55BOnOCPZ2TTZIOiESUek+Bd2LfFdBAa9WfWMl0REx/jFa2LZmyfjCN8/r7S8/U9zAl/7m2pv4h4pbU0tavGyOacRKhE7qBhiDNzXfaNqCDruzbNTkKJdR5HcImKsli0IrqBVg4sZxbJGCqYE4ekTXUGqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6RQ6YlzPMMq0kE999r0S63Hij5C0T5NsCXaPraxcCi4=; b=E9mxda7f/t1fDtndXO65Ru25Ni2UvJ06REtEv7sNe02niz9lK8D3wnc/CgOXiHCebV5xk+5skE05BpDWcWtKdw98g8n51mLwiBkpq1WXBt3cJiDCllGcJe5MEClM5cABLkzrPh7c6F8nbeIjxtBIIAnJCMW9Ljx36SaQZHxuCKY= Authentication-Results: broadcom.com; dkim=none (message not signed) header.d=none;broadcom.com; dmarc=none action=none header.from=mellanox.com; Received: from AM0PR0502MB3924.eurprd05.prod.outlook.com (2603:10a6:208:20::30) by AM0PR0502MB3745.eurprd05.prod.outlook.com (2603:10a6:208:24::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.18; Tue, 9 Jun 2020 15:07:29 +0000 Received: from AM0PR0502MB3924.eurprd05.prod.outlook.com ([fe80::cd67:f25f:c3aa:f459]) by AM0PR0502MB3924.eurprd05.prod.outlook.com ([fe80::cd67:f25f:c3aa:f459%2]) with mapi id 15.20.3066.023; Tue, 9 Jun 2020 15:07:29 +0000 To: dev@dpdk.org Cc: Thomas Monjalon , Ori Kam , Eli Britstein , Sriharsha Basavapatna , Hemal Shah From: Oz Shlomo Message-ID: <5862610e-76cc-7783-7d66-2b2173eeb974@mellanox.com> Date: Tue, 9 Jun 2020 18:07:26 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM4PR0202CA0001.eurprd02.prod.outlook.com (2603:10a6:200:89::11) To AM0PR0502MB3924.eurprd05.prod.outlook.com (2603:10a6:208:20::30) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.14.169] (79.181.214.192) by AM4PR0202CA0001.eurprd02.prod.outlook.com (2603:10a6:200:89::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.18 via Frontend Transport; Tue, 9 Jun 2020 15:07:28 +0000 X-Originating-IP: [79.181.214.192] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 1cdf2f96-5b73-4d0f-a855-08d80c86d3f4 X-MS-TrafficTypeDiagnostic: AM0PR0502MB3745: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-Forefront-PRVS: 042957ACD7 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1q98N3DrPzblCBq9DIabJLeKwoVOuz4KKou981lSK85QiWSjv4TGwLQ6WfLwQK99E+zTtJKy8QDFCuhnhZ4X2IvilBss38du8DgzJwWa/2owm4UN0lgQe6Rw8c/Z8lCY0XY9cEYxV2xSWzb7s8uHPFcGBEWvkkS2p9n2NtubgMqHbCOazHrL/xsKMelqsp6Lh4WltcmNvjW380sEQOwu2enuwLsZOMm8cydJB2SmZN2MgQ/x9JNZIKPOcC9vBaZsqHS3UfRerdlQqFBtlMsSLrJwzFGaPkH8WUDh6n9kndFYgBfcz/ETAschBcT1neTP2Qa5np1jdTzecanYda3MMRd08Ejw7UC0vFUw/R47DHtm4zqyaiONE/IzyIhrkIcq X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR0502MB3924.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(366004)(39860400002)(346002)(376002)(396003)(31686004)(26005)(5660300002)(4326008)(52116002)(2906002)(8676002)(8936002)(16576012)(316002)(31696002)(6486002)(86362001)(54906003)(66946007)(66476007)(83380400001)(66556008)(186003)(956004)(16526019)(36756003)(478600001)(6916009)(2616005)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: s4Y46h8hwbsLB7MogErHgINC9mfBsHGW3MfFJrUkn54xZA80nKPoXo4u8CgeuEbf0I8FQWQZy16KP1KUUvVNp9Nl/4fGqwC+H9tSZo7hUl+cjD4Z8yPUXl6hnvX/Ck3kowadFP7IkTE9NFnTDydh+ev6QwWOjCyfH5wNtRopGiXwB8BHeDQQoQ/a3/XaJ7J2bzuJ61h1XpqcB6n37JVSHiybZWdz2pzWCAynnVybYc4KxjdqKIiMqUwCy81dP14co1NcNhHMlr1vDWHv4FrBjzyZflGylcFG7xwVKF12Lbguf+9awzn5HDiXxhlSVB1+BaUDYGsc9oskbbaJuwef/Sx1va1loT6LZePmLYchAyc3YNQh3NXDG+hTe73SOUkCSv8JOBawqW1QTlwq28/tvJ+HgO1s+3U4Ji3uOdF62xAFxzUpM+JMGmFxVtx8t5h3Klw+8yJJz2Gl3R2AjBaKCevbMDpSznirgvi2BjNz2NPWJuEQwcG5SWzwkKlYFZTp X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1cdf2f96-5b73-4d0f-a855-08d80c86d3f4 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2020 15:07:29.4972 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 74X+Ut1s94L7PH/lC/ZuqVx8Hz643vLEBsIvARRWbLJxBFM4wJrmOL/PPr9XDQd5Qsh5Rtj/Ag/vy4QGNGvFwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3745 Subject: [dpdk-dev] [RFC] - Offloading tunnel ports X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Rte_flow API provides the building blocks for vendor agnostic flow classification offloads. The rte_flow match and action primitives are fine grained, thus enabling DPDK applications the flexibility to offload network stacks and complex pipelines. Applications wishing to offload complex data structures (e.g. tunnel virtual ports) are required to use the rte_flow primitives, such as group, meta, mark, tag and others to model their high level objects. The hardware model design for high level software objects is not trivial. Furthermore, an optimal design is often vendor specific. The goal of this RFC is to provide applications with the hardware offload model for common high level software objects which is optimal in regards to the underlying hardware. Tunnel ports are the first of such objects. Tunnel ports ------------ Ingress processing of tunneled traffic requires the classification of the tunnel type followed by a decap action. In software, once a packet is decapsulated the in_port field is changed to a virtual port representing the tunnel type. The outer header fields are stored as packet metadata members and may be matched by proceeding flows. Openvswitch, for example, uses two flows: 1. classification flow - setting the virtual port representing the tunnel type For example: match on udp port 4789 actions=tnl_pop(vxlan_vport) 2. steering flow according to outer and inner header matches match on in_port=vxlan_vport and outer/inner header matches actions=forward to port X The benefits of multi-flow tables are described in [1]. Offloading tunnel ports ----------------------- Tunnel ports introduce a new stateless field that can be matched on. Currently the rte_flow library provides an API to encap, decap and match on tunnel headers. However, there is no rte_flow primitive to set and match tunnel virtual ports. There are several possible hardware models for offloading virtual tunnel port flows including, but not limited to, the following: 1. Setting the virtual port on a hw register using the rte_flow_action_mark/ rte_flow_action_tag/rte_flow_set_meta objects. 2. Mapping a virtual port to an rte_flow group 3. Avoiding the need to match on transient objects by merging multi-table flows to a single rte_flow rule. Every approach has its pros and cons. The preferred approach should take into account the entire system architecture and is very often vendor specific. The proposed rte_flow_tunnel_port_set helper function (drafted below) is designed to provide a common, vendor agnostic, API for setting the virtual port value. The helper API enables PMD implementations to return vendor specific combination of rte_flow actions realizing the vendor's hardware model for setting a tunnel port. Applications may append the list of actions returned from the helper function when creating an rte_flow rule in hardware. Similarly, the rte_flow_tunnel_port_match helper (drafted below) allows for multiple hardware implementations to return a list of fte_flow items. Miss handling ------------- Packets going through multiple rte_flow groups are exposed to hw misses due to partial packet processing. In such cases, the software should continue the packet's processing from the point where the hardware missed. We propose a generic rte_flow_restore structure providing the state that was stored in hardware when the packet missed. Currently, the structure will provide the tunnel state of the packet that missed, namely: 1. The group id that missed 2. The tunnel port that missed 3. Tunnel information that was stored in memory (due to decap action). In the future, we may add additional fields as more state may be stored in the device memory (e.g. ct_state). Applications may query the state via a new rte_flow_get_restore_info(mbuf) API, thus allowing a vendor specific implementation. API draft is provided below --- diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h index b0e4199192..49c871fc46 100644 --- a/lib/librte_ethdev/rte_flow.h +++ b/lib/librte_ethdev/rte_flow.h @@ -3324,6 +3324,193 @@ int rte_flow_get_aged_flows(uint16_t port_id, void **contexts, uint32_t nb_contexts, struct rte_flow_error *error); +/* Tunnel information. */ +__rte_experimental +struct rte_flow_ip_tunnel_key { + rte_be64_t tun_id; /**< Tunnel identification. */ + union { + struct { + rte_be32_t src; /**< IPv4 source address. */ + rte_be32_t dst; /**< IPv4 destination address. */ + } ipv4; + struct { + uint8_t src[16]; /**< IPv6 source address. */ + uint8_t dst[16]; /**< IPv6 destination address. */ + } ipv6; + } u; + bool is_ipv6; /**< True for valid IPv6 fields. Otherwise IPv4. */ + rte_be16_t tun_flags; /**< Tunnel flags. */ + uint8_t tos; /**< TOS for IPv4, TC for IPv6. */ + uint8_t ttl; /**< TTL for IPv4, HL for IPv6. */ + rte_be32_t label; /**< Flow Label for IPv6. */ + rte_be16_t tp_src; /**< Tunnel port source. */ + rte_be16_t tp_dst; /**< Tunnel port destination. */ +}; + + +/* Tunnel has a type and the key information. */ +__rte_experimental +struct rte_flow_tunnel { + /** Tunnel type, for example RTE_FLOW_ITEM_TYPE_VXLAN, + * RTE_FLOW_ITEM_TYPE_NVGRE etc. */ + enum rte_flow_item_type type; + struct rte_flow_ip_tunnel_key tun_info; /**< Tunnel key info. */ +}; + +/** + * Indicate that the packet has a tunnel. + */ +#define RTE_FLOW_RESTORE_INFO_TUNNEL (1ULL << 0) + +/** + * Indicate that the packet has a non decapsulated tunnel header. + */ +#define RTE_FLOW_RESTORE_INFO_ENCAPSULATED (1ULL << 1) + +/** + * Indicate that the packet has a group_id. + */ +#define RTE_FLOW_RESTORE_INFO_GROUP_ID (1ULL << 2) + +/** + * Restore information structure to communicate the current packet processing + * state when some of the processing pipeline is done in hardware and should + * continue in software. + */ +__rte_experimental +struct rte_flow_restore_info { + /** Bitwise flags (RTE_FLOW_RESTORE_INFO_*) to indicate validation of + * other fields in struct rte_flow_restore_info. + */ + uint64_t flags; + uint32_t group_id; /**< Group ID. */ + struct rte_flow_tunnel tunnel; /**< Tunnel information. */ +}; + +/** + * Allocate an array of actions to be used in rte_flow_create, to implement + * tunnel-set for the given tunnel. + * Sample usage: + * actions vxlan_decap / tunnel_set(tunnel properties) / jump group 0 / end + * + * @param port_id + * Port identifier of Ethernet device. + * @param[in] tunnel + * Tunnel properties. + * @param[out] actions + * Array of actions to be allocated by the PMD. This array should be + * concatenated with the actions array provided to rte_flow_create. + * @param[out] num_of_actions + * Number of actions allocated. + * @param[out] error + * Perform verbose error reporting if not NULL. PMDs initialize this + * structure in case of error only. + * + * @return + * 0 on success, a negative errno value otherwise and rte_errno is set. + */ +__rte_experimental +int +rte_flow_tunnel_set(uint16_t port_id, + struct rte_flow_tunnel *tunnel, + struct rte_flow_action **actions, + uint32_t *num_of_actions, + struct rte_flow_error *error); + +/** + * Allocate an array of items to be used in rte_flow_create, to implement + * tunnel-match for the given tunnel. + * Sample usage: + * pattern tunnel-match(tunnel properties) / outer-header-matches / + * inner-header-matches / end + * + * @param port_id + * Port identifier of Ethernet device. + * @param[in] tunnel + * Tunnel properties. + * @param[out] items + * Array of items to be allocated by the PMD. This array should be + * concatenated with the items array provided to rte_flow_create. + * @param[out] num_of_items + * Number of items allocated. + * @param[out] error + * Perform verbose error reporting if not NULL. PMDs initialize this + * structure in case of error only. + * + * @return + * 0 on success, a negative errno value otherwise and rte_errno is set. + */ +__rte_experimental +int +rte_flow_tunnel_match(uint16_t port_id, + struct rte_flow_tunnel *tunnel, + struct rte_flow_item **items, + uint32_t *num_of_items, + struct rte_flow_error *error); + +/** + * Populate the current packet processing state, if exists, for the given mbuf. + * + * @param port_id + * Port identifier of Ethernet device. + * @param[in] m + * Mbuf struct. + * @param[out] info + * Restore information. Upon success contains the HW state. + * @param[out] error + * Perform verbose error reporting if not NULL. PMDs initialize this + * structure in case of error only. + * + * @return + * 0 on success, a negative errno value otherwise and rte_errno is set. + */ +__rte_experimental +int +rte_flow_get_restore_info(uint16_t port_id, + struct rte_mbuf *m, + struct rte_flow_restore_info *info, + struct rte_flow_error *error); + +/** + * Release the action array as allocated by rte_flow_tunnel_set. + * + * @param port_id + * Port identifier of Ethernet device. + * @param[in] actions + * Array of actions to be released. + * @param[out] error + * Perform verbose error reporting if not NULL. PMDs initialize this + * structure in case of error only. + * + * @return + * 0 on success, a negative errno value otherwise and rte_errno is set. + */ +__rte_experimental +int +rte_flow_action_release(uint16_t port_id, + struct rte_flow_action *actions, + struct rte_flow_error *error); + +/** + * Release the item array as allocated by rte_flow_tunnel_match. + * + * @param port_id + * Port identifier of Ethernet device. + * @param[in] items + * Array of items to be released. + * @param[out] error + * Perform verbose error reporting if not NULL. PMDs initialize this + * structure in case of error only. + * + * @return + * 0 on success, a negative errno value otherwise and rte_errno is set. + */ +__rte_experimental +int +rte_flow_item_release(uint16_t port_id, + struct rte_flow_item *items, + struct rte_flow_error *error); + #ifdef __cplusplus } #endif