From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 612DBC508 for ; Tue, 28 Apr 2015 11:51:02 +0200 (CEST) Received: by wgyo15 with SMTP id o15so144940913wgy.2 for ; Tue, 28 Apr 2015 02:51:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=KhVGVi/1ATrkJ7wWCeVpzrvgtuxdlq/5MCKZDmpYphc=; b=QsYHME1TyegmPUa/3auhZsH2aTByj82z+YD9u9YrCg7sqPvHt67J7WsItwnMlSbPe6 BTYkouI5fYh4364CO1JKMNGBvpl2T7I36U3UifS9wce9hY1bBbbB7xpYHm8Jy+e6hcBg +CgjX4H3n5EhrECCWGw8CGuZ4y5a6H1Qe+4Y/M8YmXasD6PAjNaVQdjt+NvF6zpUKBtz IsOUMZUzwDGzbpbhvwHSmRMx7DtvTTAcx+EZRBmjlDIzK6bHzoPtjqJOtpYD9am2Bmix osj/m6PIHJRafZn/bB2v1ZrPljdhyhBcqib8rcQ2OY4/JHe9Y5qf1YymMsG3GT+JTZW6 YuGw== X-Gm-Message-State: ALoCoQmcYM8ZZBAbFHgLSKIG5ZPmb9SsSw0Ren5UVgMYxo/bhW1hw9uzMHnk9KxJAOf52DgfInyy X-Received: by 10.194.192.65 with SMTP id he1mr6343153wjc.118.1430214662267; Tue, 28 Apr 2015 02:51:02 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id g5sm25466675wjq.6.2015.04.28.02.51.00 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Apr 2015 02:51:01 -0700 (PDT) From: Thomas Monjalon To: Olivier Matz Date: Tue, 28 Apr 2015 11:50:20 +0200 Message-ID: <5863036.r8K7YaoNjh@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <2601191342CEEE43887BDE71AB97725821420BD6@irsmsx105.ger.corp.intel.com> References: <1429610122-30943-1-git-send-email-olivier.matz@6wind.com> <1429696650-9043-1-git-send-email-olivier.matz@6wind.com> <2601191342CEEE43887BDE71AB97725821420BD6@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 00/13] mbuf: enhancements of mbuf clones X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Apr 2015 09:51:02 -0000 > > The first objective of this series is to fix the support of indirect > > mbufs when the application reserves a private area in mbufs. It also > > removes the limitation that rte_pktmbuf_clone() is only allowed on > > direct (non-cloned) mbufs. The series also contains some enhancements > > and fixes in the mbuf area that makes the implementation of the > > last patches easier. > > > > Changes in v6: > > - restore the priv_size in mbuf structure, version 4 broke the > > attachment between mbufs having different private size > > - add a test case to ensure it won't be broken again > > - replace 0xffff by UINT16_MAX > > - fix some minor checkpatch issues > > > > Changes in v5: > > - update rte_mbuf_version.map to fix compilation with shared libraries > > > > Changes in v4: > > - do not add a priv_size in mbuf structure, having a proper accessor > > to read it from the pool private area is clearer > > - prepend some reworks in the mbuf area to simplify the implementation > > (fix mbuf initialization by not using a hardcoded mbuf size, add > > accessors for mbuf pool private area, add a helper to create a > > mbuf pool) > > > > Changes in v3: > > - a mbuf can now attach to another one that have a different private > > size. In this case, the m->priv_size corresponds to the size of the > > private area of the direct mbuf. > > - add comments to reflect these changes > > - minor style modifications > > > > Changes in v2: > > - do not change the use of MBUF_EXT_MEM() in vhost > > - change rte_mbuf_from_baddr() to rte_mbuf_from_indirect(), removing > > one parameter > > - fix and rework rte_pktmbuf_detach() > > - move m->priv_size in second mbuf cache line > > - fix mbuf free in test error case > > > > Olivier Matz (13): > > mbuf: fix mbuf data room size calculation rte_pktmbuf_pool_init > > examples: always initialize mbuf_pool private area > > mbuf: add accessors to get data room size and private size > > mbuf: fix rte_pktmbuf_init when mbuf private size is not zero > > testpmd: use standard functions to initialize mbufs and mbuf pool > > mbuf: introduce a new helper to create a mbuf pool > > apps: use rte_pktmbuf_pool_create to create mbuf pools > > mbuf: fix clone support when application uses private mbuf data > > mbuf: allow to clone an indirect mbuf > > test/mbuf: rename mc variable in m > > test/mbuf: enhance mbuf refcnt test > > test/mbuf: verify that cloning a clone works properly > > test/mbuf: add a test case for clone with different priv size > > Acked-by: Konstantin Ananyev Applied, thanks