Re: [dpdk-dev] [PATCH v12 11/14] build: disable Arm drivers

[Thomas Monjalon <thomas@monjalon.net>]

16/11/2020 08:56, Juraj Linkeš:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 
> > What do you mean by "disable Arm drivers"?
> > What are "Arm drivers"
> > 
> 
> These are the drivers that we're disableing for Arm builds. I'll change it to something more clearer like "disable drivers in Arm builds"
> 
> > 13/11/2020 15:31, Juraj Linkeš:
> > > A few options that disabled drivers in the old makefiles were
> > > improperly ported to the meson build system. Fix this by adding a to
> > > the list of disabled drivers, similarly how the command line option
> > > works. Remove unneeded driver options ported from the old makefile system.
> > > Add support for removing drivers for cross builds.
> > >
> > > Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> > > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> > > Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > [...]
> > > -	['RTE_NET_FM10K', false],
> > > -	['RTE_NET_AVP', false],
> > 
> > Isn't it enabling drivers?
> > 
> 
> These options don't do anything in the way the current meson build system is set up, since they'll be overwritten in drivers/meson.build. The order is, from meson.build (in the git root):
> subdir('config')   # here we're setting arm specific flags
> ...
> subdir('drivers')  # and here they'd be overwritten

Should this change be in the same patch as disabling some drivers?
If yes, please explain in the commit log.


> > [...]
> > > +if meson.is_cross_build()
> > > +	disabled_drivers += meson.get_cross_property('disabled_drivers', [])
> > > +endif
> > 
> > Why is it specific to cross build?
> 
> I don't understand the question, what is "it"? This is adding support for disabling drivers in cross builds so I guess that part is specific to cross builds?

OK I understand.