From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FA25A04DB; Mon, 16 Nov 2020 09:22:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C29AE323E; Mon, 16 Nov 2020 09:22:42 +0100 (CET) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id CD9712BF1 for ; Mon, 16 Nov 2020 09:22:39 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 70EC1580415; Mon, 16 Nov 2020 03:22:35 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 16 Nov 2020 03:22:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 0NzK8NRfQl+dRqzk2Xwz/uD67NrjQcLU3hk5SjLE2iE=; b=AzQNL4ZRg566ilxp z8ieWrhQdR9cfSPvwwYaZDB+ghCMV1RoNa/dOlUizaeiMSvnJI3Ppy86gwsMZVrb 9LS5si3v44sre31wEfjmIS0grqYmPPdEcD6Td3ZqYyRBQew0eepNIQuS43MlxsSu bD/qyJzImUIHk8cvSGO7oaLjJGQmhCf00IGTumfaYh6tBWGfC9jiRcGOdLSM7T0q 3VUlIY3c9ZRrF31TKV6rLIZvY7lM8lDIhneSNXsAJWZvOGe3Z708befmAITcF7Mm 9O/Z5CmoSH5zWPwxYbtGOwV/O/hc7+fYMGnF4klgj1sE7DoGRVsEzL46ZnThnlGy KX4xpQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=0NzK8NRfQl+dRqzk2Xwz/uD67NrjQcLU3hk5SjLE2 iE=; b=J9IIbehk+wLAUgCC828aBdfVyGZ4B35lENwKWiJno8oAK0O3YspISId6c M09dkhkSXmdi+woIX4770pZEw+oM+0OUvp/0KTcfdMQBmo48ZDeOlVTOsLB6aH5z jv9RE0cik4qbPT2vSXV6E67cM+YAAO7gtGTXnj4+2266W/oRrEBOJ3Q6pnyTlVKl CQkQDXBCSsxiw7skEeInfVPt6bMTua80nQw2s7d07ppAIR/rv5co16QXwnwl5AUA L4weOA97Rttfe0BcG73II4cIeXEiuxBiLJRBK/SdApS3zP4xLbPWZcayL2wXrWcn 7zpmQHyTSRMVZk6vBx27fZ+YAbfbw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeftddguddvudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeekteehtdeivefhieegjeelgedufeejheekkeetueevieeuvdev uedtjeevheevteenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D4AA43064AA7; Mon, 16 Nov 2020 03:22:32 -0500 (EST) From: Thomas Monjalon To: Juraj =?utf-8?B?TGlua2XFoQ==?= Cc: "bruce.richardson@intel.com" , "Ruifeng.Wang@arm.com" , "Honnappa.Nagarahalli@arm.com" , "Phil.Yang@arm.com" , "vcchunga@amazon.com" , "Dharmik.Thakkar@arm.com" , "jerinjacobk@gmail.com" , "hemant.agrawal@nxp.com" , "ajit.khaparde@broadcom.com" , "ferruh.yigit@intel.com" , "dev@dpdk.org" Date: Mon, 16 Nov 2020 09:22:31 +0100 Message-ID: <5863230.hsDCxHRDzd@thomas> In-Reply-To: References: <1605267483-13167-1-git-send-email-juraj.linkes@pantheon.tech> <2916126.8mV2de1Bsu@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v12 11/14] build: disable Arm drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/11/2020 08:56, Juraj Linke=C5=A1: > From: Thomas Monjalon > >=20 > > What do you mean by "disable Arm drivers"? > > What are "Arm drivers" > >=20 >=20 > These are the drivers that we're disableing for Arm builds. I'll change i= t to something more clearer like "disable drivers in Arm builds" >=20 > > 13/11/2020 15:31, Juraj Linke=C5=A1: > > > A few options that disabled drivers in the old makefiles were > > > improperly ported to the meson build system. Fix this by adding a to > > > the list of disabled drivers, similarly how the command line option > > > works. Remove unneeded driver options ported from the old makefile sy= stem. > > > Add support for removing drivers for cross builds. > > > > > > Signed-off-by: Juraj Linke=C5=A1 > > > Acked-by: Bruce Richardson > > > Reviewed-by: Honnappa Nagarahalli > > [...] > > > - ['RTE_NET_FM10K', false], > > > - ['RTE_NET_AVP', false], > >=20 > > Isn't it enabling drivers? > >=20 >=20 > These options don't do anything in the way the current meson build system= is set up, since they'll be overwritten in drivers/meson.build. The order = is, from meson.build (in the git root): > subdir('config') # here we're setting arm specific flags > ... > subdir('drivers') # and here they'd be overwritten Should this change be in the same patch as disabling some drivers? If yes, please explain in the commit log. > > [...] > > > +if meson.is_cross_build() > > > + disabled_drivers +=3D meson.get_cross_property('disabled_drivers', = []) > > > +endif > >=20 > > Why is it specific to cross build? >=20 > I don't understand the question, what is "it"? This is adding support for= disabling drivers in cross builds so I guess that part is specific to cros= s builds? OK I understand.