From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE4F0A00C5; Mon, 31 Oct 2022 16:46:38 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A5D1D40223; Mon, 31 Oct 2022 16:46:38 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 941D040151 for ; Mon, 31 Oct 2022 16:46:37 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 4E6B15C01B0; Mon, 31 Oct 2022 11:46:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 31 Oct 2022 11:46:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1667231197; x= 1667317597; bh=fYlkO7GsCIOoVpTFPCyWsCFERekemY2Gjoya7o+Sqpg=; b=t p1Aw2fobmTmxm1vkpdjyWFWIZX3+o5lrkHH1obQ4tFNA5Oc2sMwt2oZYbespyUbm OXkARBQSzWQqV1IJtZlQ4soi/aW/hASuJOUTM53jD+MjZmJCj8Mb+A/cXoIcdItm qZNTa3sJizIx5EpENKNgrqM2++UkYy6h3J/PAeo7qanvVl75kSIMYnmQ4DXalZ4a TT9iH389GOwBGA/9P8xbtimURfrX4OGEnPf+GcOWYYzoj4GSoVIt1AOojkTN41JY yPujEDk3PtVvYzt1HwWke0Ez6vzXoOFFJ/3syHVRSgK3gWhA8ewB2fz0Amt733gB SjdobR+ZnfFsEQEkVi1Qg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1667231197; x= 1667317597; bh=fYlkO7GsCIOoVpTFPCyWsCFERekemY2Gjoya7o+Sqpg=; b=i s/3z9p94u+ZpH0PW7reK7c1TCigObZzFEtBhlIEHK6dHmuZA38eLhL1ga633HZjl khB7Ci+BsYxNIz7ttAhYleWwGe3kYimJpXHVl+eiTO1h/YZREbEKaCOFMKDrVJHv iBRrnXNWCfoq/QZtLXw7UxPDB1uLTl5gLxwsZkVBt0ErZ13N7f86bggRKANcGWxo YpJ6Hlh9DvHVyuR1Gyx42Yxa4CABxNIdhtM6C+UxYtSgK9jA4Qs6hkAKe6AQZxzQ rD61rnMwQ7AA9LBOBnFT1DEICwqesIyGA49S9jysg9x7lJrHOY5QBdAOypn0gqHo D6x3V6ZFLfIO1BA8SjmTg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrudefgdektdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheplefgfeeifeeghfegtdffgeetueegveehvefhudehudfflefguddu feehueeuvdefnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 31 Oct 2022 11:46:36 -0400 (EDT) From: Thomas Monjalon To: Ali Alnubani Cc: Ferruh Yigit , David Marchand , dev@dpdk.org, Chaoyong He Subject: Re: [PATCH v2] devtools: check for supported git version Date: Mon, 31 Oct 2022 16:46:34 +0100 Message-ID: <5871955.31tnzDBltd@thomas> In-Reply-To: References: <20221024153706.3117107-1-alialnu@nvidia.com> <81d75a97-6e5f-2a89-2b18-ac02f5195503@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 26/10/2022 10:34, Chaoyong He: > > On 10/26/2022 7:24 AM, David Marchand wrote: > > > On Tue, Oct 25, 2022 at 12:15 PM Ali Alnubani wrote: > > >> > > >> The script devtools/parse-flow-support.sh uses the git-grep option > > >> (-o, --only-matching), which is only supported from git version 2.19 > > >> and onwards.[1] > > >> > > >> The script now exits early providing a clear message to the user > > >> about the required git version instead of showing the following error > > >> messages multiple times: > > >> error: unknown switch `o' > > >> usage: git grep [] [-e] [...] [[--] ...] > > >> [..] > > >> > > >> [1] > > >> https://github.com/git/git/blob/v2.19.0/Documentation/RelNotes/2.19.0 > > >> .txt > > >> > > >> Signed-off-by: Ali Alnubani > > >> Signed-off-by: Thomas Monjalon > > > > > > I don't have a "non working" git, but the patch lgtm. > > > > > > Acked-by: David Marchand > > > > > > > +Chaoyong, > > > > He had observed the problem, perhaps he can help to test. > > I test in my host, it does work. > > $ git --version > git version 2.18.5 > > Before this patch: > $ ./devtools/check-doc-vs-code.sh > error: unknown switch `o' > usage: git grep [] [-e] [...] [[--] ...] > --cached search in index instead of in the work tree > ... > repeat many times. > > After this patch: > $ ./devtools/check-doc-vs-code.sh > git version >= 2.19 is required Applied, thanks.