From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 51ADD8D89;
 Sat, 19 May 2018 16:25:18 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id BFF832221F;
 Sat, 19 May 2018 10:25:17 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Sat, 19 May 2018 10:25:17 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=GdursQcCDxcl0P8bgRES1rVGru
 S4C5elDmF/HFx0eB8=; b=dYgtAkbK4gX7Wv2aC1Cy9reM8EgihEjeNUYb3Jg4Ou
 NsdE24LgptqWRId/m+EpYDcw4uov3Th58k88dYYwzm2XP9DXbDRlXR9aTqVNTiqu
 Lqt9van7+2/c++7VQNhKnexoMixDklXKjpFob7Izazis1MPx7FwdvKTsfL2effpe
 k=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=GdursQ
 cCDxcl0P8bgRES1rVGruS4C5elDmF/HFx0eB8=; b=So564wpXBRaVt3dS2uHMCl
 7czLjb9hPw/wjCjY2DMC/1GIht4XX+9xH54jnPeVjYU1p2EWbGZfbY3S7TdPlJDn
 nwEJAKiIF5jJ6FVXMq2WvO5FcGIMmphXFTiU2uI89C/BA1gb/uM8+k6a+kEhSxEh
 LGJ/geQDJ/ZLRxJIJ6EyhG3vuZM1WpuDIsMo22Aiu1/TREIG0iLkB2UZ23nCduuV
 VzanDruy3qyzjCE+LH4bMoPDXA3dh8PJd+Ra1ptXhNNq8gZox9Vh8SmpG1UnvZaO
 AssO3L8KcCyZWOvcT5qLcYhUq4lfs6wMmOTMoyjhd+g9BeKaddFAlEqpNeBCNkbw
 ==
X-ME-Proxy: <xmx:zTMAWzHNlv0i-fmGxg8HGZJLqrHPrJ_11yFkg3j5UwMZ_z6t1DrzsQ>
X-ME-Proxy: <xmx:zTMAWyXrJxxNIE4wa5WIj3IN7IpKsXBeoBHr-eFQNXJ3w2UW2NBd5A>
X-ME-Proxy: <xmx:zTMAW5cRmWgmNG3EpJPCBRLuSH2Xp5VLXjcmqD9DDpp2d_2N9ogRog>
X-ME-Proxy: <xmx:zTMAW5RDElrUJh0xWXjPcp97vw0n6-v73Volx7BWZYOnlsE3P5jiEg>
X-ME-Proxy: <xmx:zTMAWzBzjzEzxQXYjrfDgnuQaMlpwJMSNLzfC_9nwpmRFoby_Jx1rQ>
X-ME-Proxy: <xmx:zTMAW5oH8QSCpqoerYiNfp0OX6ZtIdFUDfTqd-jc4lJi044xUBx6mw>
X-ME-Sender: <xms:zTMAW1um7aYTLDtU55ETisughALGmel0h7Ct2ha3P7FEaXUJzaLfcg>
Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114])
 by mail.messagingengine.com (Postfix) with ESMTPA id 09B6910252;
 Sat, 19 May 2018 10:25:16 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org, stable@dpdk.org,
 Qi Zhang <qi.z.zhang@intel.com>
Date: Sat, 19 May 2018 16:25:15 +0200
Message-ID: <58726116.gJB1vlhU96@xps>
In-Reply-To: <465390c3-5aa9-e015-52bd-cec695d84c4c@intel.com>
References: <20180516154052.16836-1-adrien.mazarguil@6wind.com>
 <20180516154052.16836-2-adrien.mazarguil@6wind.com>
 <465390c3-5aa9-e015-52bd-cec695d84c4c@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH 2/2] ethdev: fix shallow copy of flow API RAW
	item
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 19 May 2018 14:25:18 -0000

18/05/2018 19:06, Ferruh Yigit:
> On 5/16/2018 4:41 PM, Adrien Mazarguil wrote:
> > Like original commit mentioned below, this fix synchronizes flow rule copy
> > function with testpmd's own implementation following "app/testpmd: fix copy
> > of raw flow item (revisited)".
> > 
> > Fixes: d0ad8648b1c5 ("ethdev: fix shallow copy of flow API RSS action")
> > Cc: stable@dpdk.org
> > Cc: Qi Zhang <qi.z.zhang@intel.com>
> > 
> > Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> 
> Hi Thomas,
> 
> What do you suggest about this one?
> Scope is limited to rte_flow but still many features are now relies on rte_flow,
> what is your comment on getting this in rc5?

We need to know exactly what is broken.
If nothing serious, it can wait 18.08.

Adrien, please can you describe the use case, the issue and the impact?