From: Thomas Monjalon <thomas@monjalon.net>
To: Andrius Sirvys <andrius.sirvys@intel.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com, ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH] build: add meson support for icc
Date: Tue, 26 Feb 2019 18:44:41 +0100 [thread overview]
Message-ID: <5876940.G3kBTdO44F@xps> (raw)
In-Reply-To: <1551190689-139613-1-git-send-email-andrius.sirvys@intel.com>
26/02/2019 15:18, Andrius Sirvys:
> When building with mason, checks if the compiler is icc. If they match,
> the warning_flags are changed to ensure icc compilation is successful.
>
> Disabled error 3656: "variable may be used before its value is set"
> in librte_telemetry, bnx2x, ixgbe and sfc as they were false positives.
>
> Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
> Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
I'm really not sure about supporting icc.
It may be hard to get a license for icc.
And it is not available as a simple package.
It means we are adding code that the community cannot test.
I think we should rely on free compilers only.
PS: I'm not even talking about the suspicious verification done
by the installers of the suites including icc.
prev parent reply other threads:[~2019-02-26 17:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 14:18 Andrius Sirvys
2019-02-26 14:26 ` Bruce Richardson
2019-02-26 17:44 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5876940.G3kBTdO44F@xps \
--to=thomas@monjalon.net \
--cc=andrius.sirvys@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).