From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 64CAA2C39 for ; Tue, 26 Feb 2019 18:44:44 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E6CA1221D1; Tue, 26 Feb 2019 12:44:43 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 26 Feb 2019 12:44:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=5JI65HtMMbNDQ5vtwroP35MLexwifNOQ1NF3iAWlwos=; b=bLtezQta+aTt 4bqHiTX1zpeAYLaCV7eV7kBTzuGDCl/U3f5gXBbDNQZsYl6aphVlSfaRWWbxxJTd +K5C3WWqDWPw6YFUQmBwztkfIt4FJFF9lZHbg5kwCuTSGgk2sMATwhuOeKB0NmhC DGn7tGfO/fM4OYDD/UHL4rVTdi2zfM4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=5JI65HtMMbNDQ5vtwroP35MLexwifNOQ1NF3iAWlw os=; b=bBqI6ESqNDcFuPGp4FhWIRbUUK15dqDXKy981Z2jnsIO+HOpSrbpb9KgN 7cUYQhaGFQ61WarlnM+LEvrfYCIJU5t0yFWVQ0yyS+qfZWzQqujdSo6WUK84ggNR 1COdvWRTgOxLQ3w4OGeQgSYzcp2cYWdXhXmu2S2L20yipHcztR/GrxIKY816/FtL BT5xm8gP7uS2Et+HZhJGm3CamNldDolwQp8OEisSGVG7So9zT017aFsJReLhwAsb +XrVJE2I5W+HnwZPzZd736HcJPnptIGLNHD2772AuNyDl21CCRSWn/2eq8EGYPRN J5BTW9/jupoDtLCW1NJPhnn3rm0PQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrudelgddutdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BF6FF10336; Tue, 26 Feb 2019 12:44:42 -0500 (EST) From: Thomas Monjalon To: Andrius Sirvys Cc: dev@dpdk.org, bruce.richardson@intel.com, ferruh.yigit@intel.com Date: Tue, 26 Feb 2019 18:44:41 +0100 Message-ID: <5876940.G3kBTdO44F@xps> In-Reply-To: <1551190689-139613-1-git-send-email-andrius.sirvys@intel.com> References: <1551190689-139613-1-git-send-email-andrius.sirvys@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] build: add meson support for icc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2019 17:44:44 -0000 26/02/2019 15:18, Andrius Sirvys: > When building with mason, checks if the compiler is icc. If they match, > the warning_flags are changed to ensure icc compilation is successful. > > Disabled error 3656: "variable may be used before its value is set" > in librte_telemetry, bnx2x, ixgbe and sfc as they were false positives. > > Signed-off-by: Andrius Sirvys > Tested-by: Ferruh Yigit I'm really not sure about supporting icc. It may be hard to get a license for icc. And it is not available as a simple package. It means we are adding code that the community cannot test. I think we should rely on free compilers only. PS: I'm not even talking about the suspicious verification done by the installers of the suites including icc.