From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2A36EA0573;
	Wed, 19 Oct 2022 08:55:32 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id AF68B4069C;
	Wed, 19 Oct 2022 08:55:31 +0200 (CEST)
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com
 [64.147.123.25])
 by mails.dpdk.org (Postfix) with ESMTP id 36DEC40041;
 Wed, 19 Oct 2022 08:55:30 +0200 (CEST)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.west.internal (Postfix) with ESMTP id 8A8F13200932;
 Wed, 19 Oct 2022 02:55:28 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute4.internal (MEProxy); Wed, 19 Oct 2022 02:55:29 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:cc:content-transfer-encoding:content-type:date:date:from:from
 :in-reply-to:in-reply-to:message-id:mime-version:references
 :reply-to:sender:subject:subject:to:to; s=fm3; t=1666162528; x=
 1666248928; bh=ajoRBgPmiyMZKAI8gQzsDLmuXJRB50/L+uz4mfmahzE=; b=h
 6sEj2qP2g4VzlcYdd1se7fzBZmMRdwUBv491uCR520kUmIJY7UhfSZfI/+gGiHbQ
 nwqzMM5BJMtZO+ZYSOkMKIGuqmhLigRUZmZA4b03ed0oyvENYNUppIxdLE5lxiyd
 0neFv7JKlOJG9T7mj4QJEyXvqnjhcuMYCPwdbNGnjidWdLWj6abhuKE70cyE/eum
 qHi6Ufh6WthjWIwW2jTt79jyuskBu4qb3WYM2K+sfuIs29AUgIlpGJMCgKHPjjAi
 3KfW9z9WaSz0UCcMxvHwmk1ctGS1gh6SkTrZop8tEtc4I210E1FTnmHYqjKLiKh6
 shADAvgsJ6WAKFFIGKsnA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:date:date:feedback-id:feedback-id:from:from
 :in-reply-to:in-reply-to:message-id:mime-version:references
 :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1666162528; x=
 1666248928; bh=ajoRBgPmiyMZKAI8gQzsDLmuXJRB50/L+uz4mfmahzE=; b=G
 gJYpsixSqmEUU+eeJQ7qIsPoO6mkw9g+ECQznNqRQx6sAplIGV9UArczZGX6CLvH
 4HhdebJDuBrNdSzSqOlK90V75HNQChwWLhNuSQfwf6lgRkuA33YLGZ6ZdvwcjLqK
 PbNv2jMuRUNrTNe8ZAXyfHzq1aymcQo+kpnd07PjYIBzMZ8FWORrYJKlBX6juwuw
 HAGHJ6CLUbJ24eGerjqYwYA9dlSW0psp/bZSj6QMtWmkDUk/zMOI+Iy+Z8MvjRNP
 YmPXvuSsHAnKX990Gv5BX/MudTgTe/Mq0aCdFHuh6zsigeAXLjXxii1m8dqP/fq/
 gwCAEFfjspwIoK2AntWwg==
X-ME-Sender: <xms:X59PY17UBrMkyu4U6WMoSZqZ2-ID08acAH0S61YRdlyx-miOYcigGQ>
 <xme:X59PYy78Uu9s8JzIk7Wkj5PSv_OsoQcWn3sAZ4ljyWGA6CHUGzG_uIuOO-Q4VSs9z
 4F80D2YLGgDgTasVw>
X-ME-Received: <xmr:X59PY8cLr8oFxvpoQZpN_sYLghll9jRErxFPtAExvO43gdhvRbpau1LW_vVkspb1DyhyVA3Xt1MW0gGXQM0u22FWHg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeelfedgudduvdcutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enucfjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhho
 mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne
 cuggftrfgrthhtvghrnhepffdtgfduvdffvdekteegtedujedvuefgveduvefghfegteek
 keehhfethedtvedtnecuffhomhgrihhnpeguphgukhdrohhrghdpghhithhhuhgsrdgtoh
 hmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhh
 ohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:X59PY-I5dEN9DEKZCdBIP463BJNDypw0EsqxELXPMVwo0BqLkIHT3w>
 <xmx:X59PY5J1Gbn8tmhO-APr5MCqKXFWNxy7Cp1Fng2qCbWrv16gptuv2A>
 <xmx:X59PY3zX9i4t5WdnBeOluZlZj7bD3UNrpY7nnV__wb1C58W1Ng1mcQ>
 <xmx:YJ9PY2FgnfjzrjsJ16v2UeYaSXfsk3x6MtMYt8yQyVPydJFlMcN2NA>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
 19 Oct 2022 02:55:26 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Zhangfei Gao <zhangfei.gao@linaro.org>, Akhil Goyal <gakhil@marvell.com>
Cc: "techboard@dpdk.org" <techboard@dpdk.org>, "dev@dpdk.org" <dev@dpdk.org>,
 "acc@openeuler.org" <acc@openeuler.org>,
 Zhangfei Gao <zhangfei.gao@linaro.org>
Subject: Re: crypto/uadk: introduce uadk crypto driver
Date: Wed, 19 Oct 2022 08:55:24 +0200
Message-ID: <5877730.88bMQJbFj6@thomas>
In-Reply-To: <dea6abea-7274-1f1a-19ee-838c329da16e@linaro.org>
References: <CO6PR18MB44848DBA263658B2245AA71ED8299@CO6PR18MB4484.namprd18.prod.outlook.com>
 <316c505f-8072-5da8-0ca0-d5105ea479a6@linaro.org>
 <dea6abea-7274-1f1a-19ee-838c329da16e@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

18/10/2022 12:52, Zhangfei Gao:
>=20
> On 2022/10/18 =E4=B8=8B=E5=8D=886:07, Zhangfei Gao wrote:
> > Hi, Akhil
> >
> >>
> >> On 2022/10/17 =E4=B8=8B=E5=8D=883:02, Akhil Goyal wrote:
> >>>
> >>> Hi everyone,
> >>>
> >>> We have a new crypto PMD submitted on ML=20
> >>> (http://patches.dpdk.org/project/dpdk/cover/20221008083747.6559-1-zha=
ngfei.gao@linaro.org/)
> >>>
> >>> This PMD is dependent on an external library which needs to be cross=
=20
> >>> compiled for ARM on x86.
> >>>
> >>> It mandatorily need =E2=80=9Cnumactl=E2=80=9D also cross-compiled and=
 instead of=20
> >>> using pkg-config of libnuma, it need the library and headers to be=20
> >>> copied manually to aarch toolchain.
> >>>
> >>> And if that is also done, it is not generating pkg-config which DPDK=
=20
> >>> can use to compile the PMD.
> >>>
> >>
> >> Thanks for the guidance
> >>
> >> We are trying to provide pkgconfig file for uadk libs
> >> https://github.com/Linaro/uadk/pull/513
> >>
> >> And have fixed the x86 local build.
> >> https://github.com/Linaro/uadk/pull/512
> >
> > Under this git pull, I have verified building and installing dpdk on=20
> > x86 with this diff to switch to pkg-config
> >
> > diff --git a/drivers/crypto/uadk/meson.build=20
> > b/drivers/crypto/uadk/meson.build
> > index dda6c6b257..f6fae0a239 100644
> > --- a/drivers/crypto/uadk/meson.build
> > +++ b/drivers/crypto/uadk/meson.build
> > @@ -8,18 +8,12 @@ if not is_linux
> >      subdir_done()
> >  endif
> >
> > -if arch_subdir !=3D 'arm' or not dpdk_conf.get('RTE_ARCH_64')
> > -    build =3D false
> > -    reason =3D 'only supported on aarch64'
> > -    subdir_done()
> > -endif
> > -
> >  sources =3D files(
> >          'uadk_crypto_pmd.c',
> >  )
> >
> >  deps +=3D 'bus_vdev'
> > -dep =3D cc.find_library('libwd_crypto', required: false)
> > +dep =3D dependency('libwd_crypto', required: false, method: 'pkg-confi=
g')
> >  if not dep.found()
> >         build =3D false
> >         reason =3D 'missing dependency, "libwd_crypto"'
> > @@ -27,7 +21,7 @@ else
> >         ext_deps +=3D dep
> >  endif
> >
> > -dep =3D cc.find_library('libwd', required: false)
> > +dep =3D dependency('libwd', required: false, method: 'pkg-config')
> >  if not dep.found()
> >         build =3D false
> >         reason =3D 'missing dependency, "libwd"'
> >
> >
> > One uncertainty is numa,  "Requires: numa",
> > This requires numa.pc has to be installed, so numa only can be=20
> > installed from source code (make install).
> > While apt-get install libnuma-dev does not install numa.pc, so system=20
> > can not search numa.
> > So do we have to build numa from source code?
>=20
> By the way.
>=20
> When trying to use +Libs.Private: -lnuma,
> I found Even remove building uadk, the dpdk fails if no numa.pc, though=20
> apt-get insall libnuma-dev
>=20
> /usr/bin/ld: lib/librte_eal.so.23.0: version node not found for symbol=20
> numa_run_on_node_mask@@libnuma_1.2
> /usr/bin/ld: failed to set dynamic section sizes: bad value
> collect2: error: ld returned 1 exit status
> [2813/3314] Compiling C object=20
> 'drivers/a715181@@tmp_rte_event_cnxk@sta/event_cnxk_tx_cn10k_tx_112_127_s=
eg.c.o'.
> ninja: build stopped: subcommand failed.

libnuma is a general requirement of DPDK.
numa.pc should be installed by the NUMA package.
Maybe a problem with your distribution.