From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 2/3] cfgfile: use RTE_LOG for errors
Date: Fri, 19 Jul 2019 00:39:09 +0200 [thread overview]
Message-ID: <5878380.7GULtWgYen@xps> (raw)
In-Reply-To: <20190718171812.3209-3-stephen@networkplumber.org>
18/07/2019 19:18, Stephen Hemminger:
> In general, DPDK libraries to not print error messages to
> stdout because that is often redirected to /dev/null for daemons.
> This patch changes cfgfile library to use RTE_LOG with its
> own type.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> lib/Makefile | 1 +
> lib/librte_cfgfile/rte_cfgfile.c | 38 +++++++++++++++++++++++---------
> 2 files changed, 29 insertions(+), 10 deletions(-)
>
> --- a/lib/Makefile
> +++ b/lib/Makefile
> DIRS-$(CONFIG_RTE_LIBRTE_CFGFILE) += librte_cfgfile
> +DEPDIRS-librte_cfgfile := librte_eal
You are missing LDLIBS += -lrte_eal in the librte_cfgfile Makefile.
I can add it while applying.
next prev parent reply other threads:[~2019-07-18 22:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 17:27 [dpdk-dev] [PATCH 0/3] cfgfile: cleanup patches Stephen Hemminger
2019-07-16 17:27 ` [dpdk-dev] [PATCH 1/3] cfgfile: remove unnecessary initialization Stephen Hemminger
2019-07-16 17:27 ` [dpdk-dev] [PATCH 2/3] cfgfile: use RTE_LOG for errors Stephen Hemminger
2019-07-17 21:01 ` Thomas Monjalon
2019-07-17 22:10 ` Stephen Hemminger
2019-07-16 17:27 ` [dpdk-dev] [PATCH 3/3] cfgfile: use calloc Stephen Hemminger
2019-07-17 13:38 ` [dpdk-dev] [PATCH 0/3] cfgfile: cleanup patches Bruce Richardson
2019-07-18 0:48 ` [dpdk-dev] [PATCH v2 " Stephen Hemminger
2019-07-18 0:48 ` [dpdk-dev] [PATCH v2 1/3] cfgfile: remove unnecessary initialization Stephen Hemminger
2019-07-18 0:48 ` [dpdk-dev] [PATCH v2 2/3] cfgfile: use RTE_LOG for errors Stephen Hemminger
2019-07-18 8:31 ` Bruce Richardson
2019-07-18 14:34 ` Stephen Hemminger
2019-07-18 14:36 ` Bruce Richardson
2019-07-18 14:41 ` Stephen Hemminger
2019-07-18 17:12 ` Stephen Hemminger
2019-07-18 0:48 ` [dpdk-dev] [PATCH v2 3/3] cfgfile: use calloc Stephen Hemminger
2019-07-18 17:18 ` [dpdk-dev] [PATCH v3 0/3] cfgfile: cleanup patches Stephen Hemminger
2019-07-18 17:18 ` [dpdk-dev] [PATCH v3 1/3] cfgfile: remove unnecessary initialization Stephen Hemminger
2019-07-18 17:18 ` [dpdk-dev] [PATCH v3 2/3] cfgfile: use RTE_LOG for errors Stephen Hemminger
2019-07-18 22:39 ` Thomas Monjalon [this message]
2019-07-18 17:18 ` [dpdk-dev] [PATCH v3 3/3] cfgfile: use calloc Stephen Hemminger
2019-07-18 22:44 ` [dpdk-dev] [PATCH v3 0/3] cfgfile: cleanup patches Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5878380.7GULtWgYen@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).