From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B63BEA0471 for ; Fri, 19 Jul 2019 00:39:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 37396231E; Fri, 19 Jul 2019 00:39:14 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id C10251DBF for ; Fri, 19 Jul 2019 00:39:12 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 82281418; Thu, 18 Jul 2019 18:39:11 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 18 Jul 2019 18:39:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=SrnMX0usFPba6L15XfWJGZ4M9GjJoK13dXqjwQiel6s=; b=Lq+a+D5jWdke HJYUm57iPeAZOFzk0pduYrM8d0u08H+hahaVdbxYljCh14BDt7TzH17usDgcZc0W nQLu/AkrQH+rTF5bL8q4759yzgpUJJEyAFNW/S6srHpr8BODOrfWY+vg1Ew7ena3 yXUFWaIAjTENYaBAu48lyjwy9phlBFA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=SrnMX0usFPba6L15XfWJGZ4M9GjJoK13dXqjwQiel 6s=; b=Is1bZD6ElqztTb+yr/1E973olw+ogzYDlzdm4xG2hhD1TUYxLa+GjQiua lZ4MMT+rqZ1qOQZY5Fa0x5SUlZrgyIqP0DOx187HmDNufD7s1vEnXp10QZLctkmu GoFglGwu/zvt4XAYflZSZtT9JhFGlMrBwbK3734W2/F9EabRo3TSwJbfNFXJ1h1i Qqr1/2hET2nFUVlg2oAoBv5EqRKFVCcC7Vgu1cZ7xjPSqa/UWKjdn1aPo5Ynm2n+ 0XX4Zr5ToAGd9U/Pvoa6MgUQg+q7DYPJAjhclGQ+LvLH6BFWXI0sv/rcGjqLmcN/ EAYbkcfBR7WmdQ4081NtP/ZY3pUsg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrieeigddufecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2822B80059; Thu, 18 Jul 2019 18:39:10 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org Date: Fri, 19 Jul 2019 00:39:09 +0200 Message-ID: <5878380.7GULtWgYen@xps> In-Reply-To: <20190718171812.3209-3-stephen@networkplumber.org> References: <20190716172741.21399-1-stephen@networkplumber.org> <20190718171812.3209-1-stephen@networkplumber.org> <20190718171812.3209-3-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 2/3] cfgfile: use RTE_LOG for errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 18/07/2019 19:18, Stephen Hemminger: > In general, DPDK libraries to not print error messages to > stdout because that is often redirected to /dev/null for daemons. > This patch changes cfgfile library to use RTE_LOG with its > own type. > > Signed-off-by: Stephen Hemminger > --- > lib/Makefile | 1 + > lib/librte_cfgfile/rte_cfgfile.c | 38 +++++++++++++++++++++++--------- > 2 files changed, 29 insertions(+), 10 deletions(-) > > --- a/lib/Makefile > +++ b/lib/Makefile > DIRS-$(CONFIG_RTE_LIBRTE_CFGFILE) += librte_cfgfile > +DEPDIRS-librte_cfgfile := librte_eal You are missing LDLIBS += -lrte_eal in the librte_cfgfile Makefile. I can add it while applying.