From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17FB9A0C45; Fri, 3 Dec 2021 13:24:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A0D744014F; Fri, 3 Dec 2021 13:24:35 +0100 (CET) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by mails.dpdk.org (Postfix) with ESMTP id CCFA440041 for <dev@dpdk.org>; Fri, 3 Dec 2021 13:24:34 +0100 (CET) Received: by mail-wm1-f51.google.com with SMTP id c6-20020a05600c0ac600b0033c3aedd30aso2057994wmr.5 for <dev@dpdk.org>; Fri, 03 Dec 2021 04:24:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=/xPJfrgnem/luLYcoM/HqYHQ4vVfv+ETfIIWbMNqtFw=; b=Zoe1XipyjY2wEkVMGmsCH0CkZ+n18RQ8qPOBYfsz+kFj8Y4de9BIVvhsPMPAiqFpP/ CcVehPTPZf9/AJVfcsd0CBmz3Q2rjv2eYwTJSZ4RhfiiIFCsNUg6FkJyurMVaqyb9KAf h2knhnjogwr2yHaD3xb9tJJc0XENhQOqaklWLr+i4v7lFigxvlEZk2M2fbAfxzlfzpFY 6L/ASPCETm6TJsysFDQ/yRGnSYGYkJX8X0qgUrm8OKJTefuc4p09ChrvZZDZHuBy8GNd 8NCKkuth5VlW3V5p32bofl5P8HhXyfJx0wKxt/38E647TrtJXwwM/8WLaO2wYcK7Z5cq hfkA== X-Gm-Message-State: AOAM532Q35Z8GSjTyXX1sckH3YbxLwkorMu4L8p0GV83wOC18yT7Ny9S Q6JSg4sEEVOJCjqsRNpN8mQ= X-Google-Smtp-Source: ABdhPJxkPje437SuVn4HU1ZcfTvG/H2dDHdfs8jJ9Uc4vdSragJomT3D6oz/HrLRWGJNKIo2TIK8bQ== X-Received: by 2002:a1c:2685:: with SMTP id m127mr14754311wmm.42.1638534274516; Fri, 03 Dec 2021 04:24:34 -0800 (PST) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id q26sm2483858wrc.39.2021.12.03.04.24.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Dec 2021 04:24:33 -0800 (PST) Message-ID: <587c8a79c6d314d5782f550f414cbdf12370843a.camel@debian.org> Subject: Re: [PATCH v2 1/2] devtools: don't include headline "fix" in backports From: Luca Boccassi <bluca@debian.org> To: christian.ehrhardt@canonical.com, dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, Xueming Li <xuemingl@nvidia.com>, David Marchand <david.marchand@redhat.com>, Kevin Traynor <ktraynor@redhat.com>, Maxime Coquelin <maxime.coquelin@redhat.com> Date: Fri, 03 Dec 2021 12:24:33 +0000 In-Reply-To: <20211203075415.4083502-1-christian.ehrhardt@canonical.com> References: <20211203075415.4083502-1-christian.ehrhardt@canonical.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.38.3-1+plugin MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Fri, 2021-12-03 at 08:54 +0100, christian.ehrhardt@canonical.com wrote: > From: Christian Ehrhardt <christian.ehrhardt@canonical.com> >=20 > It was important in the past to select anything with "fix" in the > headline, but recently more often created false positives and work > to sort tihngs out than identifying many helpful patches. >=20 > The community and processes aroudn DPDK matured enough that developers > (rightfully) expect to rely on "Fixes:" and "stable@" marking for > backprots. >=20 > Therefore do no more include patches that just include the word fix > in the backport candidate list. >=20 > Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> > --- > =C2=A0devtools/git-log-fixes.sh | 5 ++--- > =C2=A01 file changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh > index 210c8dcf25..27ec9088d4 100755 > --- a/devtools/git-log-fixes.sh > +++ b/devtools/git-log-fixes.sh > @@ -13,7 +13,7 @@ print_help () > =C2=A0 cat <<- END_OF_HELP > =C2=A0 >=20 > =C2=A0 Find fixes to backport on previous versions. > - It looks for the word "fix" in the headline or a tag "Fixes" or "Revert= s". > + It looks for a tag "Fixes" or "Reverts" and for recipient stable@dpdk.o= rg. > =C2=A0 The oldest bug origin is printed as well as partially fixed versio= ns. > =C2=A0 END_OF_HELP > =C2=A0} > @@ -109,8 +109,7 @@ while read id headline ; do > =C2=A0 origins=3D$(origin_filter $id) > =C2=A0 stable=3D$(stable_tag $id) > =C2=A0 fixes=3D$(fixes_tag $id) > - [ "$stable" =3D "S" ] || [ "$fixes" =3D "F" ] || [ -n "$origins" ] || \ > - echo "$headline" | grep -q fix || continue > + [ "$stable" =3D "S" ] || [ "$fixes" =3D "F" ] || [ -n "$origins" ] || c= ontinue > =C2=A0 version=3D$(commit_version $id) > =C2=A0 if [ -n "$origins" ] ; then > =C2=A0 origver=3D"$(origin_version $origins)" Acked-by: Luca Boccassi <bluca@debian.org> --=20 Kind regards, Luca Boccassi