DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>
To: "Анатолий Дубинский" <ard@amicon.ru>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Chas Williams <3chas3@gmail.com>
Subject: Re: [dpdk-dev] small error in rte_eth_bond_api.c
Date: Mon, 22 Jun 2020 16:42:06 +0800	[thread overview]
Message-ID: <587ceb90-ce0e-0259-6dee-b9c36de7fc75@huawei.com> (raw)
In-Reply-To: <f46953b6d870425da11e227a6600812d@amicon.ru>

Hi, Anatoly Dubinsky

it looks you are right. Maybe you can send a patch to fix it.

Thanks, Xavier

On 2020/6/20 2:12, Анатолий Дубинский wrote:
> Hello!
>
> I've found a small error in .../drivers/net/bonding/rte_eth_bond_api.c :
>
> Func rte_eth_bond_create:
> ret = rte_vdev_init(name, devargs);
> if (ret)
> return -ENOMEM;
>
> So, we get ENOMEM error regardless of the actual error code.
>
> This code would be more applicable.
> ret = rte_vdev_init(name, devargs);
> if (ret)
> return ret;
>
>
> Yours sincerely, Anatoly Dubinsky.
>
>
>


  reply	other threads:[~2020-06-22  8:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-19 18:12 Анатолий Дубинский
2020-06-22  8:42 ` Wei Hu (Xavier) [this message]
2020-07-14 15:14 ` Анатолий Дубинский

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=587ceb90-ce0e-0259-6dee-b9c36de7fc75@huawei.com \
    --to=xavier.huwei@huawei.com \
    --cc=3chas3@gmail.com \
    --cc=ard@amicon.ru \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).