From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E66EA0579; Thu, 8 Apr 2021 16:54:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB5F91410E1; Thu, 8 Apr 2021 16:54:49 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 323674068B; Thu, 8 Apr 2021 16:54:49 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 8381D5C00B1; Thu, 8 Apr 2021 10:54:48 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 08 Apr 2021 10:54:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= +WLyeTLkTyBZgoAI872OPZIhrVfXjlrcgbbVKsr/7xY=; b=1pZBZfMaxGUWUbRt rDwHHwwFKmtQKp2K0LkcfB6F8t34lARlZqblPN0FDUzBQrJJBNt4UpDrJluUfsAY KH0g9NEKDLb9L3Pcf6Big/f71L7QM4NCoaDaUIxI+5dE7uOOwb68BnggwN27O0hT tY3ukV5ubnp3+N1/yfPtuyUKuz4TO6fXw/Qget6mbSm+9FsPIMVVhzTEKmi3hkEH HmEBNtVOtBxT+YDcMqxiIzashHmLfpBfqNNDicEJUExRPCQHb9UGGFQSInOZAyQk mu8+MVjWs0d8t3XgRQH4qthxy6pad6IwbdaOM/PaOTZ42+l2C8wiuquIQNW50FRT SektPg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=+WLyeTLkTyBZgoAI872OPZIhrVfXjlrcgbbVKsr/7 xY=; b=t6QM03sNsb2jzYwkFGNG6lzNkEfMUVdI8mpYdQeRO/FwBrBaaYwA2GAuS CbrZ4po2m8KxdDn6GjzwLXiVNzo4j9rTgf9pjmbrYlY5seHm2dqdSkUTxg6+f5T3 jqZ5yljDniQOpk1eQLpQGzNA4AQikLg+NgLbQjqN737TwOKIMGSKNRJsyVcSA62j wVWeSM/V+c0cHF7zW1782oRz8Xq3JLZu1RfZv2AG/NZudUgVL+ElncZKtfuz83tL 0b5sSCZtZ/N6wG3NL/yTBWE/kXTdOPr6bCyO3vzOXwd3KRggPeT0S+zgjnRSC+5E yvItI1/7NZJBEq2SjKcX3qHdlFlWA== X-ME-Sender: <xms:NxlvYCd_5YV2ZlVQY6oh-_NrJzP3fHPzpDKjW8JVmlXhrYtBcuhalw> <xme:NxlvYAlnOQUjY1xIPIAF2XRHYBxXy77uqL_WLBGBOJ5c-uLS65uvoPyZ1aWMY450b IJq7T5TDICz-x0WFQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudejledgkeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: <xmx:NxlvYBYy_cj5aeDqkG3Wt-bIpz6F_jJ-w4iLFa31U-3sOaIAUP28dg> <xmx:NxlvYN6toJWpML2i2uutRQgJtyrh1X9cbcHTiP79D0onKIzriujHqw> <xmx:NxlvYDBNRglgfZu_z22fZfpUUT2IjFJQODWKegt22gN-Ym3HqTp9CA> <xmx:OBlvYL6K24M1lpaU_OK6hY28lmVUfK3msQaVJARH95HQk7FJEtUfHQ> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C5897108005C; Thu, 8 Apr 2021 10:54:46 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: "Van Haaren, Harry" <harry.van.haaren@intel.com>, David Marchand <david.marchand@redhat.com> Cc: dev@dpdk.org, "stable@dpdk.org" <stable@dpdk.org>, Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>, Dodji Seketeli <dodji@redhat.com> Date: Thu, 08 Apr 2021 16:54:45 +0200 Message-ID: <5884528.Z6T7s29bap@thomas> In-Reply-To: <CAJFAV8zQOL-O_qLJvOtWsqMnWZeNR_7Dh8kE73FJxzYKXO48UQ@mail.gmail.com> References: <20210407090656.29176-1-david.marchand@redhat.com> <BYAPR11MB3143B5EF130FFE371BCD61BBD7749@BYAPR11MB3143.namprd11.prod.outlook.com> <CAJFAV8zQOL-O_qLJvOtWsqMnWZeNR_7Dh8kE73FJxzYKXO48UQ@mail.gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] service: clean references to removed symbol X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 08/04/2021 16:04, David Marchand: > On Thu, Apr 8, 2021 at 3:08 PM Van Haaren, Harry > <harry.van.haaren@intel.com> wrote: > > > > For rte_service.h doc changes I'm all fine. > > > > > > > > For ABI consistency, this removes a function from the DPDK_21 version map that > > > didn't exist in > > > > the shared object itself. I'm not sure if that's an ABI break or not... I see ABI > > > experts on CC, > > > > and will let them comment on that topic. > > > > > > The symbol is not in the API anymore. > > > Applications can't have a reference to this symbol without a definition. > > > > Agreed, however I'm not familiar enough with linking/ABI stability to > > know if removing a symbol (even when not available in the API) could > > affect the resulting shared object's ABI. > > After a discussion with Dodji and looking at binutils, I understand > that the versioning is applied for each symbol found in an elf object. > So at least with binutils, non-existent nodes in a version script are > harmless and have no impact on the generated elf. Yes I don't see how it could break ABI. Acked-by: Thomas Monjalon <thomas@monjalon.net>