From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D563BA0093; Sat, 25 Jun 2022 04:12:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C6EE340E03; Sat, 25 Jun 2022 04:12:49 +0200 (CEST) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by mails.dpdk.org (Postfix) with ESMTP id 24F87400EF for ; Sat, 25 Jun 2022 04:12:48 +0200 (CEST) Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4LVHYk0rZqzDsNj; Sat, 25 Jun 2022 10:12:10 +0800 (CST) Received: from kwepemm600004.china.huawei.com (7.193.23.242) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 25 Jun 2022 10:12:43 +0800 Received: from [10.67.103.231] (10.67.103.231) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 25 Jun 2022 10:12:42 +0800 Message-ID: <5884a54f-24cb-19ae-f48b-0e5df33e9336@huawei.com> Date: Sat, 25 Jun 2022 10:12:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH V5 2/7] app/testpmd: unify the name of L2 payload offload To: Ferruh Yigit , , , CC: , , , References: <20220429102445.23711-1-lihuisong@huawei.com> <20220624072401.21839-1-lihuisong@huawei.com> <20220624072401.21839-3-lihuisong@huawei.com> <62028c08-cec3-74f4-f91d-423b8a415705@xilinx.com> From: "lihuisong (C)" In-Reply-To: <62028c08-cec3-74f4-f91d-423b8a415705@xilinx.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.231] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600004.china.huawei.com (7.193.23.242) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 在 2022/6/24 21:53, Ferruh Yigit 写道: > On 6/24/2022 8:23 AM, Huisong Li wrote: >> Currently, the "port config all rss xx" command uses 'ether' name to >> match >> and to set 'RTE_ETH_RSS_L2_PAYLOAD' offload. However, others RSS >> command, >> such as, "port config rss-hash-key" and "show port >> rss-hash key", use 'l2-payload' to represent this offload. So this patch >> unifies the name of 'RTE_ETH_RSS_L2_PAYLOAD' offload. >> >> Signed-off-by: Huisong Li > > ack > > But I wonder if we should continue to support 'ether' with an > exception to not break the interface, at least for a while like to > next LTS. It's supposed to have a very small impact, and it is just an optional input of this command in testpmd. What's more, patch 3/7 has to use "l2-payload" to match. This shouldn't affect the optimization progress of "port config all rss xx" command, right? > >> --- >>   app/test-pmd/cmdline.c                      | 6 +++--- >>   doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +- >>   2 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c >> index 9a7fd5fc35..a701bac953 100644 >> --- a/app/test-pmd/cmdline.c >> +++ b/app/test-pmd/cmdline.c >> @@ -694,7 +694,7 @@ static void cmd_help_long_parsed(void >> *parsed_result, >>               "receive buffers available.\n\n" >>                 "port config all rss (all|default|ip|tcp|udp|sctp|" >> - >> "ether|port|vxlan|geneve|nvgre|vxlan-gpe|ecpri|mpls|ipv4-chksum|l2tpv2|" >> + >> "l2-payload|port|vxlan|geneve|nvgre|vxlan-gpe|ecpri|mpls|ipv4-chksum|l2tpv2|" >> "none|level-default|level-outer|level-inner|)\n" >>               "    Set the RSS mode.\n\n" >>   @@ -2080,7 +2080,7 @@ cmd_config_rss_parsed(void *parsed_result, >>           rss_conf.rss_hf = RTE_ETH_RSS_TCP; >>       else if (!strcmp(res->value, "sctp")) >>           rss_conf.rss_hf = RTE_ETH_RSS_SCTP; >> -    else if (!strcmp(res->value, "ether")) >> +    else if (!strcmp(res->value, "l2_payload")) >>           rss_conf.rss_hf = RTE_ETH_RSS_L2_PAYLOAD; >>       else if (!strcmp(res->value, "port")) >>           rss_conf.rss_hf = RTE_ETH_RSS_PORT; >> @@ -2203,7 +2203,7 @@ static cmdline_parse_inst_t cmd_config_rss = { >>       .f = cmd_config_rss_parsed, >>       .data = NULL, >>       .help_str = "port config all rss " >> - "all|default|eth|vlan|ip|tcp|udp|sctp|ether|port|vxlan|geneve|" >> + "all|default|eth|vlan|ip|tcp|udp|sctp|l2-payload|port|vxlan|geneve|" >> "nvgre|vxlan-gpe|l2tpv3|esp|ah|pfcp|ecpri|mpls|ipv4-chksum|l2tpv2|" >> "none|level-default|level-outer|level-inner|", >>       .tokens = { >> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst >> b/doc/guides/testpmd_app_ug/testpmd_funcs.rst >> index 0b7a53fdf1..cc299cff6c 100644 >> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst >> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst >> @@ -2144,7 +2144,7 @@ port config - RSS >>     Set the RSS (Receive Side Scaling) mode on or off:: >>   -   testpmd> port config all rss >> (all|default|eth|vlan|ip|tcp|udp|sctp|ether|port|vxlan|geneve|nvgre|vxlan-gpe|l2tpv3|esp|ah|pfcp|ecpri|mpls|l2tpv2|none) >> +   testpmd> port config all rss >> (all|default|eth|vlan|ip|tcp|udp|sctp|l2-payload|port|vxlan|geneve|nvgre|vxlan-gpe|l2tpv3|esp|ah|pfcp|ecpri|mpls|l2tpv2|none) >>     RSS is on by default. > > .