From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id AA8EEFAD7 for ; Thu, 9 Feb 2017 19:22:54 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP; 09 Feb 2017 10:22:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,137,1484035200"; d="scan'208";a="63189257" Received: from sdoyle1-mobl1.ger.corp.intel.com (HELO [10.252.0.133]) ([10.252.0.133]) by fmsmga005.fm.intel.com with ESMTP; 09 Feb 2017 10:22:52 -0800 To: Pablo de Lara , declan.doherty@intel.com References: <1486643265-244932-1-git-send-email-pablo.de.lara.guarch@intel.com> Cc: dev@dpdk.org From: "Zhang, Roy Fan" Message-ID: <589CB37B.7060404@intel.com> Date: Thu, 9 Feb 2017 18:22:51 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1486643265-244932-1-git-send-email-pablo.de.lara.guarch@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix incorrect padding addition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Feb 2017 18:22:55 -0000 On 09/02/2017 12:27, Pablo de Lara wrote: > L2fwd-crypto app was padding an incoming buffer, > to be aligned with the algorithm block size, in all cases. > This was not the right approach, as padding is only necessary > when using block cipher algorithms, such as AES-CBC. > In case of using a stream cipher algorithm, such as SNOW3G UEA2, > there is no need to include padding and increase the buffer size. > > Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application") > > Signed-off-by: Pablo de Lara > Acked-by : Fan Zhang