From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C15F3A00C3;
	Mon,  3 Oct 2022 15:20:28 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id B48D9410D2;
	Mon,  3 Oct 2022 15:20:28 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 6B94E40695
 for <dev@dpdk.org>; Mon,  3 Oct 2022 15:20:27 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id B680566;
 Mon,  3 Oct 2022 16:20:26 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru B680566
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1664803226;
 bh=1GDg8iQLiZer8KTFNrPXlBOB73jojvkkRrbWeHsLnK0=;
 h=Date:From:Subject:To:Cc:References:In-Reply-To:From;
 b=MEC69Wu7W1cjGDqY4uPMzwA3ULkHyl+gcwnsZZLmyrHVl0K+MwTGiWshGQbr7E0T4
 7VoTH1FogUPmUMDA89AWjW+r4oBgdRe/YbWpEyfcekkaPGNt/W0JUKu7KtJCVAJHje
 kL8g8OcxeEPyHEUO4kfOBUhg3dZEdwwhYgrrl65I=
Message-ID: <589eed67-dd79-d454-422c-7f8a0b4d72ce@oktetlabs.ru>
Date: Mon, 3 Oct 2022 16:20:26 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [PATCH v2 02/14] net/idpf/base: add logs and OS specific
 implementation
To: Junfeng Guo <junfeng.guo@intel.com>, qi.z.zhang@intel.com,
 jingjing.wu@intel.com, beilei.xing@intel.com
Cc: dev@dpdk.org, xiao.w.wang@intel.com
References: <20220803113104.1184059-1-junfeng.guo@intel.com>
 <20220905105828.3190335-1-junfeng.guo@intel.com>
 <20220905105828.3190335-3-junfeng.guo@intel.com>
Content-Language: en-US
Organization: OKTET Labs
In-Reply-To: <20220905105828.3190335-3-junfeng.guo@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 9/5/22 13:58, Junfeng Guo wrote:
> Add PMD logs.
> Add some MACRO definations and small functions which are specific
> for DPDK.
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>

The patch adds dead code as well. Added headers are used
nowhere.

One more question is what's the point to have two things in one
patch? Typically such descriptions suggest that it could be
separate patches in a right order.