From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f179.google.com (mail-wr0-f179.google.com [209.85.128.179]) by dpdk.org (Postfix) with ESMTP id 3024C2BB0 for ; Tue, 11 Apr 2017 14:13:25 +0200 (CEST) Received: by mail-wr0-f179.google.com with SMTP id c55so93922802wrc.3 for ; Tue, 11 Apr 2017 05:13:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-transfer-encoding; bh=UY6JRpQs5jSiHHNldG8mrnm/Ya0pcBiF0QdLVkr2Y6E=; b=m/C83XFTl8Zx7mjbg7jM5cQte0uSXlh4Cc+CUVtaAPKQleshMkm2csrRNJ/YSojze4 upvmtNDv8ddo0X1sqN8nHcaAP6p1JpSFog99IJhTBJ1hS9+QmEZq0xbdhsNcBV89wnsF UukFpRquRg170vpEK3i+PSe1usIovKab1GHfyEifZvLCYdu0ZiZLy7EHsfgeI2QzQTKk 87EdPX+0mydWXN/Erk/mFciVP7mi56utTsMYrvFTtcIk4SFyAeUawzK433pr+8RNVV// qSHbZPbBogMnCqLtDlyvaDDU1/uhHM4Bq0b5oZ2K2vq4BFkRtw9/VhhTV+WiT9jdgWG/ hn1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-transfer-encoding; bh=UY6JRpQs5jSiHHNldG8mrnm/Ya0pcBiF0QdLVkr2Y6E=; b=IQxP7NH9JaQmqN4pB5JOhPhWtKjY6pCbVe8GRhwcdy7PeaO2wZp9N1oDHJcP4QzoXv LO8w2V29vcBepo1gU4UCswJTBODIKw0OFyvkUO2IcGD+eBbypX7n1FLW9FlI4uY/7PnA CuKRyebEfDVEdDJQQYTEuKZuqrRt/Tb1pRNsqNSCDuW1FI8Ymt6vkp8clE1Zhf3dgwly WE1SkxLturkzZdw3ydifjV/cIhiSt33IAGu6fC5/BvT2cZoJIybMBedc0Epf8GPQwrwK 6v4Vc4PI5P2d6LSVIQatMcJMxJHAhZP3tS2BynD05DszWEJPkfW4J02f3tRM96wuHmJ/ SlyQ== X-Gm-Message-State: AFeK/H2awT72n9w27ljaSlPRhZZS5WdkgfnIFS3AlgvgI5dSxp8HqCtNZwN052c9/82J9TbD X-Received: by 10.223.168.23 with SMTP id l23mr28802038wrc.185.1491912804832; Tue, 11 Apr 2017 05:13:24 -0700 (PDT) Received: from [10.16.0.207] (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.googlemail.com with ESMTPSA id n198sm2252392wmd.30.2017.04.11.05.13.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Apr 2017 05:13:24 -0700 (PDT) Message-ID: <58ECC85D.4010403@6wind.com> Date: Tue, 11 Apr 2017 14:13:17 +0200 From: Laurent Hardy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Ferruh Yigit , "Dai, Wei" , Olivier Matz , "dev@dpdk.org" , "Zhang, Helin" , "Ananyev, Konstantin" References: <1479403792-11928-1-git-send-email-laurent.hardy@6wind.com> <1487262721-22370-1-git-send-email-olivier.matz@6wind.com> <20170330111959.43ac9078@platinum> <49759EB36A64CF4892C1AFEC9231E8D650A23CB0@PGSMSX101.gar.corp.intel.com> <58E24CC8.1080406@6wind.com> <8ce85605-3e52-6088-754e-29ee892681c6@intel.com> In-Reply-To: <8ce85605-3e52-6088-754e-29ee892681c6@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: ensure link status is updated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Apr 2017 12:13:25 -0000 On 04/10/2017 03:36 PM, Ferruh Yigit wrote: > On 4/3/2017 2:23 PM, Laurent Hardy wrote: >> Hi Wei, >> Thanks for your reply. >> >> If autoneg is false, then we set a default speed to the highest value >> before performing the link setup. >> You are right, there is no relevant reason to keep this check on speed >> mask> should be: >> + if (!autoneg) >> + speed = IXGBE_LINK_SPEED_10GB_FULL; > Hi Laurent, > > Should we expect a new version of the patch with above update? Hi Ferruh, yes, I will send a new version today. regards, Laurent > Thanks, > ferruh > >> Patch has been tested using testpmd with following setups: >> >> Autoneg setup: >> ========= >> - On dut, both ports of 82599 are connected to a switch with 1Gb ports >> - auto-negotiate option is enabled on switch >> >> Defined speed setup: >> ============ >> - set link speed to 1Gb on both ports of the switch connected to the dut >> > <...> > >> >> Thanks & regards, >> Laurent >> >> On 03/30/2017 06:32 PM, Dai, Wei wrote: >>> Hi, Olivier >>> >>> Has anyone already tested this patch ? >>> Can you present some useful info on how to test it ? >>> Can I use ethtool with some argument to downgrade or upgrade the rate of peer port ? >>> >>> I have just run testpmd with 82599, the hw->phy. autoneg_advertised is 0 after rte_eal_init() and rte_eth_dev_start(). >>> So I think the codes in if (!speed) { ... } is likely to be run. >>> I agree with most of your codes. >>> But why to limit speed of NIC to 10Gbps if autoneg is false and 10Gbps is supported ? >>> In this case, how about setting multiple speed ? >>> >>> Thanks >>> -Wei >>> >>> > <...> > >