From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Dekel Peled <dekelp@mellanox.com>, <adrien.mazarguil@6wind.com>,
<wenzhuo.lu@intel.com>, <jingjing.wu@intel.com>,
<bernard.iremonger@intel.com>, <yskoh@mellanox.com>,
<shahafs@mellanox.com>, <viacheslavo@mellanox.com>
Cc: <dev@dpdk.org>, <orika@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v7 1/3] ethdev: add actions to modify TCP header fields
Date: Thu, 27 Jun 2019 20:54:57 +0300 [thread overview]
Message-ID: <58b03d51-5aec-3943-cf63-0a4f93fbef4b@solarflare.com> (raw)
In-Reply-To: <91371a891418062bcf88069bbd24c1cc4759f1ab.1561656978.git.dekelp@mellanox.com>
On 6/27/19 8:39 PM, Dekel Peled wrote:
> Add actions:
> - INC_TCP_SEQ - Increase sequence number in the outermost TCP header.
> - DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header.
> - INC_TCP_ACK - Increase acknowledgment number in the outermost TCP
> header.
> - DEC_TCP_ACK - Decrease acknowledgment number in the outermost TCP
> header.
>
> Original work by Xiaoyu Min.
>
> This patch introduces a new approach, using a simple integer instead
> of using an action-specific structure for each of these actions.
> This approach can be later applied to modify existing actions which
> require only a single integer.
If we allow it, may be we should fix at least experimental API and
remove dummy structures.
I think ideally it should be a pre-patch which allows to avoid structures.
Right now it is a mixture of two logical changes.
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
A nit below (plus above), other than that
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
[...]
> diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
> index f3a8fb1..8c962d0 100644
> --- a/lib/librte_ethdev/rte_flow.h
> +++ b/lib/librte_ethdev/rte_flow.h
> @@ -1650,6 +1650,46 @@ enum rte_flow_action_type {
> * See struct rte_flow_action_set_mac.
> */
> RTE_FLOW_ACTION_TYPE_SET_MAC_DST,
> +
> + /**
> + * Increase sequence number in the outermost TCP header.
> + *
> + * Using this action on non-matching traffic will result in
> + * undefined behavior.
> + *
> + * See struct rte_flow_integer_action.
There is no rte_flow_integer_action, please, fix.
[...]
next prev parent reply other threads:[~2019-06-27 17:55 UTC|newest]
Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 14:18 [dpdk-dev] [PATCH 0/3] add actions to modify " Dekel Peled
2019-03-21 14:18 ` Dekel Peled
2019-03-21 14:18 ` [dpdk-dev] [PATCH 1/3] ethdev: add actions to modify TCP " Dekel Peled
2019-03-21 14:18 ` Dekel Peled
2019-03-26 9:24 ` Dekel Peled
2019-03-26 9:24 ` Dekel Peled
2019-03-29 13:58 ` Adrien Mazarguil
2019-03-29 13:58 ` Adrien Mazarguil
2019-03-31 13:09 ` Dekel Peled
2019-03-31 13:09 ` Dekel Peled
2019-03-21 14:18 ` [dpdk-dev] [PATCH 2/3] app/testpmd: " Dekel Peled
2019-03-21 14:18 ` Dekel Peled
2019-03-29 13:58 ` Adrien Mazarguil
2019-03-29 13:58 ` Adrien Mazarguil
2019-03-31 13:10 ` Dekel Peled
2019-03-31 13:10 ` Dekel Peled
2019-03-21 14:18 ` [dpdk-dev] [PATCH 3/3] net/mlx5: update modify header using Direct Verbs Dekel Peled
2019-03-21 14:18 ` Dekel Peled
2019-04-02 15:13 ` [dpdk-dev] [PATCH v2 0/3] add actions to modify header fields Dekel Peled
2019-04-02 15:13 ` Dekel Peled
2019-04-10 11:26 ` [dpdk-dev] [PATCH v3 " Dekel Peled
2019-04-10 11:26 ` Dekel Peled
2019-04-10 11:26 ` [dpdk-dev] [PATCH v3 1/3] ethdev: add actions to modify TCP " Dekel Peled
2019-04-10 11:26 ` Dekel Peled
2019-04-10 11:26 ` [dpdk-dev] [PATCH v3 2/3] app/testpmd: " Dekel Peled
2019-04-10 11:26 ` Dekel Peled
2019-04-10 11:26 ` [dpdk-dev] [PATCH v3 3/3] net/mlx5: update modify header using Direct Verbs Dekel Peled
2019-04-10 11:26 ` Dekel Peled
2019-04-10 11:50 ` [dpdk-dev] [PATCH v4 0/3] add actions to modify header fields Dekel Peled
2019-04-10 11:50 ` Dekel Peled
2019-04-10 11:50 ` [dpdk-dev] [PATCH v4 1/3] ethdev: add actions to modify TCP " Dekel Peled
2019-04-10 11:50 ` Dekel Peled
2019-04-18 12:30 ` Adrien Mazarguil
2019-04-18 12:30 ` Adrien Mazarguil
2019-04-22 7:15 ` Dekel Peled
2019-04-22 7:15 ` Dekel Peled
2019-04-10 11:50 ` [dpdk-dev] [PATCH v4 2/3] app/testpmd: " Dekel Peled
2019-04-10 11:50 ` Dekel Peled
2019-04-10 11:50 ` [dpdk-dev] [PATCH v4 3/3] net/mlx5: update modify header using Direct Verbs Dekel Peled
2019-04-10 11:50 ` Dekel Peled
2019-04-22 11:22 ` [dpdk-dev] [PATCH v5 0/3] add actions to modify header fields Dekel Peled
2019-04-22 11:22 ` Dekel Peled
2019-04-22 11:22 ` [dpdk-dev] [PATCH v5 1/3] ethdev: add actions to modify TCP " Dekel Peled
2019-04-22 11:22 ` Dekel Peled
2019-04-22 11:22 ` [dpdk-dev] [PATCH v5 2/3] app/testpmd: " Dekel Peled
2019-04-22 11:22 ` Dekel Peled
2019-04-22 11:22 ` [dpdk-dev] [PATCH v5 3/3] net/mlx5: update modify header using Direct Verbs Dekel Peled
2019-04-22 11:22 ` Dekel Peled
2019-06-02 8:18 ` [dpdk-dev] [PATCH v5 0/3] add actions to modify header fields Dekel Peled
2019-06-04 5:13 ` Dekel Peled
2019-06-04 8:14 ` Dekel Peled
2019-06-17 6:12 ` [dpdk-dev] [PATCH v6 " Dekel Peled
2019-06-17 6:12 ` [dpdk-dev] [PATCH v6 1/3] ethdev: add actions to modify TCP " Dekel Peled
2019-06-17 6:12 ` [dpdk-dev] [PATCH v6 2/3] app/testpmd: " Dekel Peled
2019-06-17 6:12 ` [dpdk-dev] [PATCH v6 3/3] net/mlx5: update modify header using Direct Verbs Dekel Peled
2019-06-27 17:39 ` [dpdk-dev] [PATCH v7 0/3] add actions to modify header fields Dekel Peled
2019-06-30 7:59 ` [dpdk-dev] [PATCH v8 " Dekel Peled
2019-06-30 7:59 ` [dpdk-dev] [PATCH v8 1/3] ethdev: add actions to modify TCP " Dekel Peled
2019-07-01 8:55 ` Adrien Mazarguil
2019-07-01 9:58 ` Dekel Peled
2019-06-30 7:59 ` [dpdk-dev] [PATCH v8 2/3] app/testpmd: " Dekel Peled
2019-06-30 7:59 ` [dpdk-dev] [PATCH v8 3/3] net/mlx5: update modify header using Direct Verbs Dekel Peled
[not found] ` <cover.1561656977.git.dekelp@mellanox.com>
2019-06-27 17:39 ` [dpdk-dev] [PATCH v7 1/3] ethdev: add actions to modify TCP header fields Dekel Peled
2019-06-27 17:54 ` Andrew Rybchenko [this message]
2019-06-28 16:18 ` Adrien Mazarguil
2019-06-27 17:39 ` [dpdk-dev] [PATCH v7 2/3] app/testpmd: " Dekel Peled
2019-06-27 17:39 ` [dpdk-dev] [PATCH v7 3/3] net/mlx5: update modify header using Direct Verbs Dekel Peled
2019-04-02 15:13 ` [dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header fields Dekel Peled
2019-04-02 15:13 ` Dekel Peled
2019-04-02 16:33 ` Ori Kam
2019-04-02 16:33 ` Ori Kam
2019-04-03 9:14 ` Adrien Mazarguil
2019-04-03 9:14 ` Adrien Mazarguil
2019-04-03 10:49 ` Dekel Peled
2019-04-03 10:49 ` Dekel Peled
2019-04-03 12:49 ` Adrien Mazarguil
2019-04-03 12:49 ` Adrien Mazarguil
2019-04-04 9:01 ` Ori Kam
2019-04-04 9:01 ` Ori Kam
2019-04-04 13:25 ` Adrien Mazarguil
2019-04-04 13:25 ` Adrien Mazarguil
2019-04-05 11:54 ` Andrew Rybchenko
2019-04-05 11:54 ` Andrew Rybchenko
2019-04-08 13:36 ` Dekel Peled
2019-04-08 13:36 ` Dekel Peled
2019-04-08 13:53 ` Andrew Rybchenko
2019-04-08 13:53 ` Andrew Rybchenko
2019-04-08 14:21 ` Adrien Mazarguil
2019-04-08 14:21 ` Adrien Mazarguil
2019-04-02 15:13 ` [dpdk-dev] [PATCH v2 2/3] app/testpmd: " Dekel Peled
2019-04-02 15:13 ` Dekel Peled
2019-04-02 16:33 ` Ori Kam
2019-04-02 16:33 ` Ori Kam
2019-04-02 15:13 ` [dpdk-dev] [PATCH v2 3/3] net/mlx5: update modify header using Direct Verbs Dekel Peled
2019-04-02 15:13 ` Dekel Peled
2019-04-02 16:34 ` Ori Kam
2019-04-02 16:34 ` Ori Kam
2019-04-03 8:27 ` Shahaf Shuler
2019-04-03 8:27 ` Shahaf Shuler
2019-07-01 15:43 ` [dpdk-dev] [PATCH v9 0/3] add actions to modify header fields Dekel Peled
2019-07-01 15:43 ` [dpdk-dev] [PATCH v9 1/3] ethdev: add actions to modify TCP " Dekel Peled
2019-07-02 8:14 ` Andrew Rybchenko
2019-07-02 9:52 ` Dekel Peled
2019-07-02 10:33 ` Adrien Mazarguil
2019-07-02 12:01 ` Dekel Peled
2019-07-01 15:43 ` [dpdk-dev] [PATCH v9 2/3] app/testpmd: " Dekel Peled
2019-07-01 15:43 ` [dpdk-dev] [PATCH v9 3/3] net/mlx5: update modify header using Direct Verbs Dekel Peled
2019-07-02 14:44 ` [dpdk-dev] [PATCH v10 0/3] add actions to modify header fields Dekel Peled
2019-07-02 14:44 ` [dpdk-dev] [PATCH v10 1/3] ethdev: add actions to modify TCP " Dekel Peled
2019-07-03 5:04 ` Slava Ovsiienko
2019-07-02 14:44 ` [dpdk-dev] [PATCH v10 2/3] app/testpmd: " Dekel Peled
2019-07-03 6:30 ` Slava Ovsiienko
2019-07-02 14:44 ` [dpdk-dev] [PATCH v10 3/3] net/mlx5: update modify header using Direct Verbs Dekel Peled
2019-07-03 6:30 ` Slava Ovsiienko
2019-07-02 15:15 ` [dpdk-dev] [PATCH v10 0/3] add actions to modify header fields Adrien Mazarguil
2019-07-03 14:59 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58b03d51-5aec-3943-cf63-0a4f93fbef4b@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=adrien.mazarguil@6wind.com \
--cc=bernard.iremonger@intel.com \
--cc=dekelp@mellanox.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=orika@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=viacheslavo@mellanox.com \
--cc=wenzhuo.lu@intel.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).