From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 1CA285F72 for ; Thu, 15 Mar 2018 18:38:17 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Mar 2018 10:38:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,311,1517904000"; d="scan'208";a="211662473" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.62]) ([10.237.221.62]) by fmsmga006.fm.intel.com with ESMTP; 15 Mar 2018 10:38:15 -0700 To: Stephen Hemminger , dev@dpdk.org References: <20180126020151.979-1-stephen@networkplumber.org> From: Ferruh Yigit Message-ID: <58d25cba-6586-71c6-78c0-a4e200c0f431@intel.com> Date: Thu, 15 Mar 2018 17:38:15 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180126020151.979-1-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8 00/15] common linkstatus functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2018 17:38:18 -0000 On 1/26/2018 2:01 AM, Stephen Hemminger wrote: > While writing hyper-v driver, noticed a lot of unnecessary > duplication of code in drivers for handling the eth_dev link status > information. While consolidating this, it also became obvious that > some drivers behave differently for no good reason. > > It also was a good chance to introduce atomic exchange primitives > in EAL because there are other places using cmpset where not > necessary (such as bonding). > > Mostly only compile tested only, don't have all of the hardware > available (except ixgbe and virtio) to test. > > v8 > - fix typo in 32bit exchange > - fix build of dpaa2 > - go back to same return value as original code > - reduce number of lines changed > > v7 > - add exchange functions for PPC64 > - move linkstatus helpers to rte_ethdev_driver > - rebase to 18.02 > > Stephen Hemminger (15): > eal: introduce atomic exchange operation > ethdev: add linkstatus get/set helper functions > net/virtio: use eth_linkstatus_set > net/vmxnet3: use rte_eth_linkstatus_set > net/dpaa2: use rte_eth_linkstatus_set > net/nfp: use rte_eth_linkstatus functions > net/e1000: use rte_eth_linkstatus helpers > net/ixgbe: use rte_eth_linkstatus functions > net/sfc: use new rte_eth_linkstatus functions > net/i40e: use rte_eth_linkstatus functions > net/liquidio: use rte_eth_linkstatus_set > net/thunderx: use rte_eth_linkstatus_set > net/szedata: use _rte_eth_linkstatus_set > net/octeontx: use rte_eth_linkstatus_set > net/enic: use rte_eth_linkstatus_set For series Reviewed-by: Ferruh Yigit