From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DB76A04DC; Mon, 19 Oct 2020 10:31:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D0E66BC06; Mon, 19 Oct 2020 10:31:32 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 444FCBBC6 for ; Mon, 19 Oct 2020 10:31:31 +0200 (CEST) IronPort-SDR: 4vsJe/yoM3MMMheG/sry/59dpW/FIpha1qePR3XvLNHD5xKvkG2q9oZWM0iY1Ivq1L9lkbllql AXUNdm9hUawA== X-IronPort-AV: E=McAfee;i="6000,8403,9778"; a="167105538" X-IronPort-AV: E=Sophos;i="5.77,394,1596524400"; d="scan'208";a="167105538" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2020 01:31:28 -0700 IronPort-SDR: 0QLn5YeaYtL2LXDJhhQP5TErQKI+c09RKkp98fLu6T6MtbWRQFGmKVxqFNMFMVGk6gsHG4uRHd XDTrSBI3jJjQ== X-IronPort-AV: E=Sophos;i="5.77,394,1596524400"; d="scan'208";a="347358406" Received: from padraigr-mobl.ger.corp.intel.com (HELO [10.252.19.15]) ([10.252.19.15]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2020 01:31:25 -0700 To: Gregory Etelson , dev@dpdk.org Cc: matan@nvidia.com, rasland@nvidia.com, elibr@nvidia.com, ozsh@nvidia.com, mdr@ashroe.eu, Ori Kam , Thomas Monjalon , Andrew Rybchenko References: <20200625160348.26220-1-getelson@mellanox.com> <20201018121523.4408-1-getelson@nvidia.com> From: Ferruh Yigit Message-ID: <58eeba67-58fb-180b-7009-fdd800c7864e@intel.com> Date: Mon, 19 Oct 2020 09:31:22 +0100 MIME-Version: 1.0 In-Reply-To: <20201018121523.4408-1-getelson@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ethdev: rename tunnel offload callbacks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/18/2020 1:15 PM, Gregory Etelson wrote: > rename new rte_flow ops callbacks to emphasize relation to tunnel > offload API. > > Signed-off-by: Gregory Etelson > Acked-by: Ori Kam > --- > lib/librte_ethdev/rte_flow.c | 13 +++++++------ > lib/librte_ethdev/rte_flow_driver.h | 4 ++-- > 2 files changed, 9 insertions(+), 8 deletions(-) > > diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c > index 380c5cae2c..d3e5cbc194 100644 > --- a/lib/librte_ethdev/rte_flow.c > +++ b/lib/librte_ethdev/rte_flow.c > @@ -1223,10 +1223,11 @@ rte_flow_tunnel_action_decap_release(uint16_t port_id, > > if (unlikely(!ops)) > return -rte_errno; > - if (likely(!!ops->action_release)) { > + if (likely(!!ops->tunnel_action_decap_release)) { +1 to rename. Acked-by: Ferruh Yigit