From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 2C1F11B44C; Thu, 31 Jan 2019 15:52:22 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 680168050A; Thu, 31 Jan 2019 14:52:21 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-117-200.ams2.redhat.com [10.36.117.200]) by smtp.corp.redhat.com (Postfix) with ESMTP id A9A2C19C7B; Thu, 31 Jan 2019 14:52:18 +0000 (UTC) To: Viacheslav Ovsiienko , shahafs@mellanox.com Cc: dev@dpdk.org, stable@dpdk.org, Thomas Monjalon , Yongseok Koh , Luca Boccassi References: <1545924885-6215-1-git-send-email-viacheslavo@mellanox.com> From: Kevin Traynor Organization: Red Hat Message-ID: <590129bf-3012-25bf-bac5-fedf1c705a25@redhat.com> Date: Thu, 31 Jan 2019 14:52:17 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <1545924885-6215-1-git-send-email-viacheslavo@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 31 Jan 2019 14:52:21 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 0/5] net/mlx5: add inner tunnel items support on E-Switch X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2019 14:52:22 -0000 On 12/27/2018 03:34 PM, Viacheslav Ovsiienko wrote: > The generic Flow rule for tunnels looks like: > > flow create \ > \ > \ > > > Current design supports only L2 addresses as inner pattern > items. This patchset adds support for L3 (IPv4/IPv6) addresses > and L4 (TCP/UDP) ports items as inner tunnel parameters. > > Also this patchset adds support for inner and outer ethernet > types for the E-Switch Flows with tunnels. Inner and outer ethernet > type match can be specified with ethernet items, vlan items, or > implicitly deduced from IP address items. The tcm_info field > in Netlink message tcm structure is filled always with outer > protocol. > > Cc: stable@dpdk.org > Hi Viacheslav - these are new features, not a bugfixes. Are the stable@dpdk.org tags intentional? From http://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be-backported -- Features should not be backported to stable releases. It may be acceptable, in limited cases, to back port features for the LTS release where: There is a justifiable use case (for example a new PMD). The change is non-invasive. The work of preparing the backport is done by the proposer. There is support within the community. -- Kevin. > Signed-off-by: Viacheslav Ovsiienko > > Viacheslav Ovsiienko (5): > net/mlx5: remove checks for outer tunnel items on E-Switch > net/mlx5: add tunnel inner items validation on E-Switch > net/mlx5: add tunnel inner items support on E-Switch > net/mlx5: add ethernet type validation on E-Switch > net/mlx5: add ethernet type support for tunnels on E-Switch > > drivers/net/mlx5/mlx5_flow_tcf.c | 690 ++++++++++++++++++++++----------------- > 1 file changed, 399 insertions(+), 291 deletions(-) >