From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 1E0AA1B53 for ; Wed, 19 Sep 2018 11:23:09 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Sep 2018 02:23:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,393,1531810800"; d="scan'208";a="91847343" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.252.28.16]) ([10.252.28.16]) by orsmga001.jf.intel.com with ESMTP; 19 Sep 2018 02:23:06 -0700 To: Ajit Khaparde , dev@dpdk.org Cc: Somnath Kotur , stable@broadcom.com References: <20180901043254.51000-1-ajit.khaparde@broadcom.com> <20180901043254.51000-3-ajit.khaparde@broadcom.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <590319ec-4fa9-fef1-5430-941ae3d715dc@intel.com> Date: Wed, 19 Sep 2018 10:23:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180901043254.51000-3-ajit.khaparde@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/7] net/bnxt: fix uninitialized ptr access in transmit handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Sep 2018 09:23:10 -0000 On 9/1/2018 5:32 AM, Ajit Khaparde wrote: > From: Somnath Kotur > > bnxt_start_xmit() was attempting to access an uninitialized ptr - txbd1 > which would lead to segmentation fault. > Fix to initialize ptr to NULL and check for the same before access. > > Fixes: f10258e39ec2 ("net/bnxt: fix HW Tx checksum offload check") > Cc: stable@broadcom.com dpdk.org