From: "Tootoonchian, Amin" <amin.tootoonchian@intel.com>
To: "Kerlin, MarcinX" <marcinx.kerlin@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: ensure consistent port id assignment
Date: Fri, 22 Jul 2016 19:56:26 +0000 [thread overview]
Message-ID: <5905C8E33883CA46A8878E2D7724E2151739E7@ORSMSX109.amr.corp.intel.com> (raw)
In-Reply-To: <68D830D942438745AD09BAFA99E33E81275B25@IRSMSX102.ger.corp.intel.com>
Inline:
> > This is the intended behavior with this patch. Ports are to be created
> > only by the primary process. This is required for correct operation
> > IMO, because if we allow secondary processes to create ports
> > dynamically (and locally use conflicting port ids) without any
> > synchronization mechanism, they're guaranteed to overwrite each other's
> rte_eth_dev_data.
>
> Thanks Amin for clarification,
> I had another approach, that rte_eth_devices and rte_eth_dev_data should have
> different offset of port_id and secondary process can also add devices.
That wouldn't work without some rather intrusive changes. As of now, rte_eth_dev_data includes port_id and therefore should be consistent across processes.
> as I now understand with this patch we will not be able do something like:
> Primary:
> ./test-pmd -c 0xf -n 4 --socket-mem='512,0' -w 03:00.1 -w 03:00.0
> --proc-type=primary --file-prefix=xz1 -- -i
> Secondary:
> ./test-pmd -c 0xf0 --socket-mem='512,0' -n 4 -v -b 03:00.1 -b 03:00.0 --vdev
> 'eth_pcap0,rx_pcap=/var/log/device1.pcap,tx_pcap=/var/log/device2.pcap'
> --proc-type=secondary --file-prefix=xz1 -- -i
>
> Because secondary processes "Ports are to be created only by the primary
> process"?
Right, that wouldn't work.
Amin
prev parent reply other threads:[~2016-07-22 19:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 2:01 Tootoonchian, Amin
2016-07-20 8:51 ` Kerlin, MarcinX
2016-07-20 15:07 ` Tootoonchian, Amin
2016-07-20 15:11 ` Thomas Monjalon
2016-07-20 17:25 ` Tootoonchian, Amin
2016-08-24 22:17 ` Tootoonchian, Amin
2017-09-04 14:53 ` Sergio Gonzalez Monroy
2018-12-21 15:30 ` Ferruh Yigit
2016-07-21 13:54 ` Kerlin, MarcinX
2016-07-22 19:56 ` Tootoonchian, Amin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5905C8E33883CA46A8878E2D7724E2151739E7@ORSMSX109.amr.corp.intel.com \
--to=amin.tootoonchian@intel.com \
--cc=dev@dpdk.org \
--cc=marcinx.kerlin@intel.com \
--cc=sergio.gonzalez.monroy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).