From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 64D43C45A for ; Thu, 28 Jan 2016 14:53:24 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id 128so11530329wmz.1 for ; Thu, 28 Jan 2016 05:53:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=ae3YkOngQ/2p1LLOIETmMA2Q1ion6eAsskIjVTz1Z2w=; b=W+D3meGFkmbC98F7pxb57BT2dNsQLf8kuCF7PDJmSIPYyTPpYXr/h8oYW1qcmEv6k3 vnv80uCiEgjMvImIVghEl/qpNudz8yMzwsZ4yAiMPs+qoNtBnr4FfEiINPpIQmHik3ab xngibMdvJZJHVqRX8Sai39IOIOuv0kphHLCeur1sHDvCVgbYebvb0tll89jTceP6dBRf TXGOUNP6ei29zce4Z3tR538sXEbU3zL8X7TlvxQQYMrarJv7rh7yfyxs3Dgx+9GYpgPO KfVkahzwI6sF1YR+JVqXi4U3oNvhAoonj+H40AfM6NlJ/r6Yfybd42dfiTjbvDICzkL5 CPTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=ae3YkOngQ/2p1LLOIETmMA2Q1ion6eAsskIjVTz1Z2w=; b=dcYp1WAgmy9QPAkuIyap9kkK760O2YUjoRI56wqqmSKQRQ49jh6pONaPUVKQXP8C4U bHAIqmOjgvY+DH0I8EE1NY7EHObCvtORt6W3brUMQk0RWzQpUcw1SRQkvRh9jTyZi+kf AkYDAZ9RJ2JaVeQvNp2ZSPXI+8Syux/aneAafIT6sKjC2Pp5RraF7hmqXU8CqmGe0mFW +bNiNbsE6sowmxXZsdKKBRhpw0ZHNTvQXoM6KbSxcAbpCCBYPttHs06YDmC/i5M0TtMc O3JzrDVQtap0TGXw39dgWJdrJzDzuGr0rVbpiOEbyHmPfrZ4WofNM03lvg0EJVG5L6hB YPYw== X-Gm-Message-State: AG10YOSonNMUXi6N5m4rraiklnFdCZm31GOgvUuo0R6ZG4BBmGe403eNiPNXVOshOSakejdO X-Received: by 10.194.19.101 with SMTP id d5mr3245547wje.72.1453989204123; Thu, 28 Jan 2016 05:53:24 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id i196sm2966238wmf.23.2016.01.28.05.53.23 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 28 Jan 2016 05:53:23 -0800 (PST) From: Thomas Monjalon To: Kamil Rytarowski Date: Thu, 28 Jan 2016 14:52:12 +0100 Message-ID: <5908931.I9BmIPpWAU@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <56A9F8D3.3010605@caviumnetworks.com> References: <1449667198-27218-1-git-send-email-Kamil.Rytarowski@caviumnetworks.com> <1872674.ygjbT6ghrC@xps13> <56A9F8D3.3010605@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 1/2] tools: Add support for handling built-in kernel modules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jan 2016 13:53:24 -0000 2016-01-28 12:17, Kamil Rytarowski: > > W dniu 26.01.2016 o 16:23, Thomas Monjalon pisze: > > 2016-01-20 10:48, krytarowski@caviumnetworks.com: > >> --- a/tools/dpdk_nic_bind.py > >> +++ b/tools/dpdk_nic_bind.py > >> - for line in loaded_mods: > >> + try: > >> + # Get list of syfs modules, some of them might be builtin and merge with mods > > Please could you explain this comment? > > Is it remaining from previous versions of the patch? > > Yes. It might be changed to: > # Get list of sysfs modules (both built-in and dynamically loaded) OK > > [...] > >> + # special case for vfio_pci (module is named vfio-pci, > >> + # but its .ko is named vfio_pci) > > Isn't it common to have dash replaced by underscore for kernel modules? > > > > I retained the logic for special case of vfio-pci. At the moment > (according to my knowledge) there are no other DPDK modules with this > name replacement. > > I checked few example Linux modules and if a module is named with dash, > it's being replaced to underscore. The modprobe(8) tool can accept both > names as interchangeable (with dash and underscore). > > Would you like to make it a general rule and replace all dashes with > underscores? I don't know. Do what you think is best. Thanks