From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 09C8F1B4F6 for ; Wed, 3 Apr 2019 19:06:28 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9053D22062; Wed, 3 Apr 2019 13:06:27 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 03 Apr 2019 13:06:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=N4h8YRFbmVKsZU8cUbWV9yPNRNRYTPUOgOOq+KMjpgs=; b=YtFyLAmgg4ir 4CLgGuC70YFRoeOSYfyMuc21FnsvTXxUz/sjX1pspet9tgbIWXhi1ljPw0iqzIXq vQY4JI6TaPIVK3/4jAfH/PhpfaIaZcxds6HVHg4/huOoDADk6bcBR0ftWIxvqSWI fRWhDXRRdf4ETCcgo0Y670Hzcjug7CA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=N4h8YRFbmVKsZU8cUbWV9yPNRNRYTPUOgOOq+KMjp gs=; b=eHYz6py/CJjhhXFroyFpW5Wi+p8Sga96AXgZlaQvWGiJJwff84zm4XfxU jwhAWLi2b+/bCjmaem6rmR/vjqmne7idjxJjYQcGa5zn4TO1NLNH8PysUGajgGQr ds2uPURp6dHXkqHYrSjXCpYaFpKG6fmoNZZdxPgO0YUdKYHjNAIaw087obqtoknj u+w196+suhF/PhAkjg8dDoVn+rAEX3KiohUxeUs8lNkpP7ESxPfBnQC5krfbBnyY LgpWXnCaWRgc53/nfYLS+Ql/B4dZsBRDogVtoDSyeBhHhSmQpVTjvOa56D2kX2pL WZMyp9ndqIDH8BkedEjFYX3ELyidQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtdefgdekvdculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgepud X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9007610394; Wed, 3 Apr 2019 13:06:25 -0400 (EDT) From: Thomas Monjalon To: Gage Eads Cc: dev@dpdk.org, Honnappa Nagarahalli , "olivier.matz@6wind.com" , "arybchenko@solarflare.com" , "bruce.richardson@intel.com" , "konstantin.ananyev@intel.com" , "Gavin Hu (Arm Technology China)" , nd Date: Wed, 03 Apr 2019 19:06:24 +0200 Message-ID: <5912114.tna7mvfDTn@xps> In-Reply-To: References: <20190401001238.17625-1-gage.eads@intel.com> <20190401211429.20282-2-gage.eads@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 1/8] stack: introduce rte stack library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Apr 2019 17:06:28 -0000 02/04/2019 13:14, Honnappa Nagarahalli: > > Subject: [PATCH v6 1/8] stack: introduce rte stack library > > > > The rte_stack library provides an API for configuration and use of a bounded > > stack of pointers. Push and pop operations are MT-safe, allowing concurrent > > access, and the interface supports pushing and popping multiple pointers at a > > time. > > > > The library's interface is modeled after another DPDK data structure, rte_ring, > > and its lock-based implementation is derived from the stack mempool > > handler. An upcoming commit will migrate the stack mempool handler to > > rte_stack. > > > > Signed-off-by: Gage Eads > > Reviewed-by: Olivier Matz > > --- > Reviewed-by: Honnappa Nagarahalli It does not compile for Arm: lib/librte_stack/rte_stack_std.h: In function '__rte_stack_std_pop': lib/librte_stack/rte_stack_std.h:68:6: error: implicit declaration of function 'unlikely' From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D1F3CA0679 for ; Wed, 3 Apr 2019 19:06:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 92CFD1B4F9; Wed, 3 Apr 2019 19:06:29 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 09C8F1B4F6 for ; Wed, 3 Apr 2019 19:06:28 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9053D22062; Wed, 3 Apr 2019 13:06:27 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 03 Apr 2019 13:06:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=N4h8YRFbmVKsZU8cUbWV9yPNRNRYTPUOgOOq+KMjpgs=; b=YtFyLAmgg4ir 4CLgGuC70YFRoeOSYfyMuc21FnsvTXxUz/sjX1pspet9tgbIWXhi1ljPw0iqzIXq vQY4JI6TaPIVK3/4jAfH/PhpfaIaZcxds6HVHg4/huOoDADk6bcBR0ftWIxvqSWI fRWhDXRRdf4ETCcgo0Y670Hzcjug7CA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=N4h8YRFbmVKsZU8cUbWV9yPNRNRYTPUOgOOq+KMjp gs=; b=eHYz6py/CJjhhXFroyFpW5Wi+p8Sga96AXgZlaQvWGiJJwff84zm4XfxU jwhAWLi2b+/bCjmaem6rmR/vjqmne7idjxJjYQcGa5zn4TO1NLNH8PysUGajgGQr ds2uPURp6dHXkqHYrSjXCpYaFpKG6fmoNZZdxPgO0YUdKYHjNAIaw087obqtoknj u+w196+suhF/PhAkjg8dDoVn+rAEX3KiohUxeUs8lNkpP7ESxPfBnQC5krfbBnyY LgpWXnCaWRgc53/nfYLS+Ql/B4dZsBRDogVtoDSyeBhHhSmQpVTjvOa56D2kX2pL WZMyp9ndqIDH8BkedEjFYX3ELyidQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtdefgdekvdculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgepud X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9007610394; Wed, 3 Apr 2019 13:06:25 -0400 (EDT) From: Thomas Monjalon To: Gage Eads Cc: dev@dpdk.org, Honnappa Nagarahalli , "olivier.matz@6wind.com" , "arybchenko@solarflare.com" , "bruce.richardson@intel.com" , "konstantin.ananyev@intel.com" , "Gavin Hu (Arm Technology China)" , nd Date: Wed, 03 Apr 2019 19:06:24 +0200 Message-ID: <5912114.tna7mvfDTn@xps> In-Reply-To: References: <20190401001238.17625-1-gage.eads@intel.com> <20190401211429.20282-2-gage.eads@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v6 1/8] stack: introduce rte stack library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190403170624.kKzqGxeQznw7TBuDajWd2lT7B1C8HOxYlmOkKA8Bc2k@z> 02/04/2019 13:14, Honnappa Nagarahalli: > > Subject: [PATCH v6 1/8] stack: introduce rte stack library > > > > The rte_stack library provides an API for configuration and use of a bounded > > stack of pointers. Push and pop operations are MT-safe, allowing concurrent > > access, and the interface supports pushing and popping multiple pointers at a > > time. > > > > The library's interface is modeled after another DPDK data structure, rte_ring, > > and its lock-based implementation is derived from the stack mempool > > handler. An upcoming commit will migrate the stack mempool handler to > > rte_stack. > > > > Signed-off-by: Gage Eads > > Reviewed-by: Olivier Matz > > --- > Reviewed-by: Honnappa Nagarahalli It does not compile for Arm: lib/librte_stack/rte_stack_std.h: In function '__rte_stack_std_pop': lib/librte_stack/rte_stack_std.h:68:6: error: implicit declaration of function 'unlikely'