From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 9C7F641E80;
Sun, 12 Mar 2023 15:16:58 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 3115240F18;
Sun, 12 Mar 2023 15:16:58 +0100 (CET)
Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com
[64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 3C971406A2
for <dev@dpdk.org>; Sun, 12 Mar 2023 15:16:56 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.west.internal (Postfix) with ESMTP id 002BE3200488;
Sun, 12 Mar 2023 10:16:54 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Sun, 12 Mar 2023 10:16:55 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:cc:content-transfer-encoding:content-type:content-type:date
:date:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:sender:subject:subject:to:to; s=fm2; t=
1678630614; x=1678717014; bh=AZopp7VzfDI1iJxM6toUE9r4O74TARoA8eq
vb3DoXC0=; b=rFapKvsdHH1M9yByzI1fZyRJW5NZXAo9LIpUkWDqQROH7fU06Ji
mmIYfGtRwjne0/FOOcAGPLLjJO6tZwjBB7oMns0eM1NjnCPcRYYfpd0N4jhCunbU
4Hz5kccaZxtnulveaqnO4jCwdhl0l+6bDww4Z8FP1XrEEjrVeIYvFr/sBI/q20DA
EkGiOUHD9K3qACMMA4FYb5fLYxDo3/upVOObYZTOk9W2TNs5f10XjpppvlOXPQnM
7rcv6qUeVCxeI8OG6iM8NguZCgS/loywV+2c7jVUjlQoGo1aceqmUXzZGufJzR5Z
n2uk+jQhoMHrFo6UErfr1KK0np72nv2I66w==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:content-type:date:date:feedback-id:feedback-id
:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:sender:subject:subject:to:to:x-me-proxy
:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=
1678630614; x=1678717014; bh=AZopp7VzfDI1iJxM6toUE9r4O74TARoA8eq
vb3DoXC0=; b=uu9WUzWhh06te56jUqTSgEdSAUIv61DyuiC0hVHm/fvjWNKLZMr
h2uqZh8cwNaTuMYt+mCqP/w1yDJX9ebxpSVYkRVvQulmbbjcU2vPhKwU4l25pn25
Ni8AvO4HbBDboKIORiHQ6rUDkKqenfX+L72NqOhLJOv/h+18Se7Am8ZLM8Q9eh18
NVoAbqi8EhpRAVUAA4ihysRHW+5SS71S6qB7Sv7M2BLUYSDj02Z++USsjA+Ff99E
ee8R2iYc9aa6KuTp9BgEDvVNvNE0ijq76kQdp/HxOktsseDRluLSAEZzsgD+g1Go
MyNTNha747L2gIu4mtldVGLBxPzI5cKoyhg==
X-ME-Sender: <xms:1t4NZB9dcgbUQ9eMpMBtgf6ZnzBeDBo97vUvV0ZJMHmQsyGCDkZCug>
<xme:1t4NZFuc5YClWyJE6vLXYXIPG4mOULxvavHrDojKZNuwilk6eWuLFNrdn9pqGU3g0
AMk_ABXkgklRx9b8g>
X-ME-Received: <xmr:1t4NZPCsgTE_iP_ck21czyn0hNk_wj3FtxyFuN8b3slj_P_qN00lGlDywBqpcHHOEIQvl3A1AmH2tsD6KQedF2ieeA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddvvddgieduucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei
kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh
hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght
X-ME-Proxy: <xmx:1t4NZFeuuWceZqwD4iKt7V3-j15z91KR8nuuCU08QgzGqRkQwJAz_Q>
<xmx:1t4NZGMpKWOMP2rZMuV2cAeoQVo83MwPBEUrm6gdGwXA4Hva-tGiZw>
<xmx:1t4NZHkt4LXIgOVT3Pht3Df7nl39vMsylFtaDjDw0w_zbQOrshzmIA>
<xmx:1t4NZAV4HSP-x0OlkFy1PtMKwNDaVdzkEsT7Myf9N7hVfCKXgPEQ0g>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
12 Mar 2023 10:16:54 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH] app/dumpcap: don't pass negative value to strerror() on
error
Date: Sun, 12 Mar 2023 15:16:53 +0100
Message-ID: <5912203.31tnzDBltd@thomas>
In-Reply-To: <20230207170050.1093917-1-stephen@networkplumber.org>
References: <20230207170050.1093917-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
07/02/2023 18:00, Stephen Hemminger:
> If eth_stats_get fails (for example with -ENOTSUPP) then
> dumpcap would pass that to strerror which is incorrect.
>
> Fixes: 8744f84bb255 ("app/dumpcap: add statistics mode")
> Coverity issue: 383136
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Changed the title to highlight the user facing change:
app/dumpcap: fix error message when getting statistics
Applied, thanks.