From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id CDE2158DB for <dev@dpdk.org>; Wed, 2 Dec 2015 03:19:11 +0100 (CET) Received: by wmww144 with SMTP id w144so38088967wmw.0 for <dev@dpdk.org>; Tue, 01 Dec 2015 18:19:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=CBRkpnF4z93UPYr5mBD2SUN4OjyzQAO5RSyp2se+x8A=; b=kdttKOiDzeVBftVyZ/1iOFGIe/qg4JUKbG4TFyhmOyEzNKOTksANJ7fLjTCJpxO9+j PVptJHf0hLF75t2RpJdlPoMyhUINfvexe7tQJuyRDH0AuBdgYYWU/F7bo1nMfoPhfz+M Ujtrn9Lm4iKM6aOY6pR450WukQQl0hiZPiU+svT2FQccbHC0JhN2WQu31SBOKmESQ9/U nobTtPUzhESDUtYUjcQr7bIpYqanAg/CySSYd9AiZ3nERS3AI51PxPFULTLuMWLrMo+v 0Y2zqj2c13c5e+DgRVlhSeCR4e55ChO0izJvQk6DlRchRAreES0pl/OVbFumsB4IIOiP mb9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=CBRkpnF4z93UPYr5mBD2SUN4OjyzQAO5RSyp2se+x8A=; b=bfHg6g3mI7njD5Wd+X3P3a22PV2/flXJy31B0dH6swpjHmDWVNgvIrXKY3zZ759EkA vc6qwU4lOBXSrRuqzCsBSjThUAEUpflM/BmGnim6+Ug49CjJ497GjBRiaILqYDzzfM17 ZNWP17rCCrmjn4OwSQ7bPcpzKOShv+knYUmtuT+BwKAnO4eObkU+noLq5q8zpB3cPL8Z gRRYNqR/EzlAAnYNZg3F9GKNT6/bo9fzwsADuueYEQWlJ2yTotr3DilvXzsN19LQlaTM 8p3rveMej+spsa33C0sB2gOUh15+TN0cMKeYgTzWbMgratqC5Vs0vHM0CFNlH8rinyyF Ntbw== X-Gm-Message-State: ALoCoQkh+j3ct4phtQ2qyVjwYjvqjdL/HROgsuS/RMT1526tBsH2NqyqloHz3e4d9i7nYupIJ06H X-Received: by 10.28.90.132 with SMTP id o126mr2143951wmb.1.1449022751679; Tue, 01 Dec 2015 18:19:11 -0800 (PST) Received: from xps13.localnet ([93.158.53.139]) by smtp.gmail.com with ESMTPSA id gl10sm527373wjb.30.2015.12.01.18.19.10 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 01 Dec 2015 18:19:10 -0800 (PST) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Michael Qiu <michael.qiu@intel.com> Date: Wed, 02 Dec 2015 03:18:01 +0100 Message-ID: <5915028.hIVKuBcS7U@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1449022194-25510-1-git-send-email-michael.qiu@intel.com> References: <1448534997-24297-1-git-send-email-michael.qiu@intel.com> <1449022194-25510-1-git-send-email-michael.qiu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] lib/librte_sched: Fix compile with gcc 4.3.4 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 02 Dec 2015 02:19:12 -0000 2015-12-02 10:09, Michael Qiu: > gcc 4.3.4 does not include "immintrin.h", and will post below error: > lib/librte_sched/rte_sched.c:56:23: error: > immintrin.h: No such file or directory This compiler issue is fixed with rte_vect.h. > To avoid this issue, a gcc version check is need and a flag to indicate > vector ablility. It is another issue: we need SSE2 support. > --- a/lib/librte_sched/rte_sched.c > +++ b/lib/librte_sched/rte_sched.c > @@ -42,6 +42,7 @@ > #include <rte_prefetch.h> > #include <rte_branch_prediction.h> > #include <rte_mbuf.h> > +#include <rte_vect.h> Shouldn't be in #ifdef RTE_SCHED_VECTOR ? > #include "rte_sched.h" > #include "rte_bitmap.h" > @@ -53,7 +54,11 @@ > #endif > > #ifdef RTE_SCHED_VECTOR > -#include <immintrin.h> > + > +#if defined(__SSE2__) > +#define SCHED_VECTOR_ENABLE > +#endif I think the flag should SCHED_VECTOR_SSE2 With this fix, the need for disabling SCHED_VECTOR for non-x86 platforms should disappear. But it may be safe to disable it (another patch). Thanks