From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D4CD4237E; Mon, 9 Jan 2023 12:08:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 72E0C40687; Mon, 9 Jan 2023 12:08:59 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 04B7F4067C for ; Mon, 9 Jan 2023 12:08:58 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 93A8A5C00A2; Mon, 9 Jan 2023 06:08:55 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 09 Jan 2023 06:08:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1673262535; x= 1673348935; bh=NMXJh1i7c8ty0nepKNPi6+jnMnDFjwuHjjo6Tu+68OE=; b=X NGALHc3TlkRH9QJPNukQjhg8k1Zkv75zHzv+8enPf6x5adraHjiVJPBgLXmhY63p rOOfzGP1gtVM2keGlcah+eQYA6UDwB62UJiV2T/cgnTXJstP81FSxeaJ6WaHx+vE 7JmsVzJ2eLpEmVt4Ly9Mgd+2FucHSlj5Y00iJLyGlqTkrP73LTw7NDzzOFNZaYky nVdYRGqT5rIn/K7TBRhZwR9lYiX//QIsKXUsmaOa9tB92dfZKyq6taNGxOrUm09i imyWMMctt89n32+qGNj6jHxjTQMyabqChdHt7y0UXsJfPtbyWG9apRnWZcKswOnN noGjHV/zr5HwwE7xAat7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1673262535; x= 1673348935; bh=NMXJh1i7c8ty0nepKNPi6+jnMnDFjwuHjjo6Tu+68OE=; b=o nrSZGHtMAve5zNHU4hLugh/YV/0Y8t0HX8h3sxgE3hm29RGSbfY7nwmmQgqjcXXp yyJbu/rlsNlWSYvZVCS1csV5P0OAh1xiBUhVfjE9q9luqTUciBwkba/smP2uL9zE A2RfCZJBbSC+gxWAN5ev6O2CQYhLVBsKqz1VBXgGHpKACtZ26uyVo/Z1bJfw77bf GTcjGoOl9ziDksYeSomh1Z29ZJbqVkpURhMHZrBiCVudGrUN1pmbmrDRxzl5K6ZI pcAZ9CkaUf5Y7WnE8+m4N8BK4r3zK9Gybcy78ufVjMdql9r33wl5HrMifUpKc4k+ 7pxkA+/eHO0wcXG6oH0CQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrkeeigddvtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepfefhjeeluedvvedtuddtuedtvefhieejtefhffeujefhteduudev tdektdeikeffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 9 Jan 2023 06:08:53 -0500 (EST) From: Thomas Monjalon To: Morten =?ISO-8859-1?Q?Br=F8rup?= Cc: dev@dpdk.org, roretzla@linux.microsoft.com, rmody@marvell.com, timothy.mcdaniel@intel.com, matan@nvidia.com, viacheslavo@nvidia.com, ruifeng.wang@arm.com, zhoumin@loongson.cn, drc@linux.vnet.ibm.com, kda@semihalf.com, bruce.richardson@intel.com, konstantin.v.ananyev@yandex.ru Subject: Re: [PATCH v5 1/4] eal: add nonnull and access function attributes Date: Mon, 09 Jan 2023 12:08:50 +0100 Message-ID: <5925056.DvuYhMxLoT@thomas> In-Reply-To: <20221228151019.101309-1-mb@smartsharesystems.com> References: <20221202153432.131023-1-mb@smartsharesystems.com> <20221228151019.101309-1-mb@smartsharesystems.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 28/12/2022 16:10, Morten Br=F8rup: > Add "nonnull" function attribute to help the compiler detect a NULL > pointer being passed to a function not accepting NULL pointers as an > argument at build time. >=20 > Add "access" function attribute to tell the compiler how a function > accesses its pointer arguments. Why access specification is needed? Isn't it enough to have the const keyword? I'm afraid we are going to make the code ugly to read with such attribute.