DPDK patches and discussions
 help / color / mirror / Atom feed
* Re: [dpdk-dev] [PATCH V2] net/bonding: delete redundant code
       [not found] <20878f97-ff83-4f39-b603-bcd8379fa5a9@DGGEMS414-HUB.china.huawei.com>
@ 2020-07-04  1:22 ` Wei Hu (Xavier)
  2020-07-17 11:22   ` Wei Hu (Xavier)
  2020-07-20 22:51   ` [dpdk-dev] [dpdk-stable] [PATCH V2] net/bonding: delete redundant code Ferruh Yigit
  0 siblings, 2 replies; 5+ messages in thread
From: Wei Hu (Xavier) @ 2020-07-04  1:22 UTC (permalink / raw)
  To: 197020236; +Cc: dev, stable



On 2020/7/4 9:15, 197020236@qq.com wrote:
> From: pandongyang <197020236@qq.com>
>
> The function valid_bonded_port_id() has already contains function
> rte_eth_dev_is_valid_port(), so delete redundant check.
>
> Fixes: 588ae95e7983 ("net/bonding: fix port ID check")
> Cc: stable@dpdk.org
>
> Signed-off-by: pandongyang <197020236@qq.com>
Reviewed-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
> ---
> v1 -> v2: Adjust commit info
> ---
>   drivers/net/bonding/rte_eth_bond_8023ad.c | 6 ------
>   1 file changed, 6 deletions(-)
>
> diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
> index b77a37ddb..339374337 100644
> --- a/drivers/net/bonding/rte_eth_bond_8023ad.c
> +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
> @@ -1675,9 +1675,6 @@ rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port)
>   	dev = &rte_eth_devices[port];
>   	internals = dev->data->dev_private;
>   
> -	if (check_for_bonded_ethdev(dev) != 0)
> -		return -1;
> -
>   	if (bond_8023ad_slow_pkt_hw_filter_supported(port) != 0)
>   		return -1;
>   
> @@ -1704,9 +1701,6 @@ rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port)
>   	dev = &rte_eth_devices[port];
>   	internals = dev->data->dev_private;
>   
> -	if (check_for_bonded_ethdev(dev) != 0)
> -		return -1;
> -
>   	/* Device must be stopped to set up slow queue */
>   	if (dev->data->dev_started)
>   		return -1;


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH V2] net/bonding: delete redundant code
  2020-07-04  1:22 ` [dpdk-dev] [PATCH V2] net/bonding: delete redundant code Wei Hu (Xavier)
@ 2020-07-17 11:22   ` Wei Hu (Xavier)
  2020-07-17 12:46     ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
  2020-07-20 22:51   ` [dpdk-dev] [dpdk-stable] [PATCH V2] net/bonding: delete redundant code Ferruh Yigit
  1 sibling, 1 reply; 5+ messages in thread
From: Wei Hu (Xavier) @ 2020-07-17 11:22 UTC (permalink / raw)
  To: 197020236; +Cc: dev, stable, Wei Hu (Xavier), Ferruh Yigit

Reviewed-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>


On 2020/7/4 9:22, Wei Hu (Xavier) wrote:
>
>
> On 2020/7/4 9:15, 197020236@qq.com wrote:
>> From: pandongyang <197020236@qq.com>
>>
>> The function valid_bonded_port_id() has already contains function
>> rte_eth_dev_is_valid_port(), so delete redundant check.
>>
>> Fixes: 588ae95e7983 ("net/bonding: fix port ID check")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: pandongyang <197020236@qq.com>
> Reviewed-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
>> ---
>> v1 -> v2: Adjust commit info
>> ---
>>   drivers/net/bonding/rte_eth_bond_8023ad.c | 6 ------
>>   1 file changed, 6 deletions(-)
>>
>> diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c 
>> b/drivers/net/bonding/rte_eth_bond_8023ad.c
>> index b77a37ddb..339374337 100644
>> --- a/drivers/net/bonding/rte_eth_bond_8023ad.c
>> +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
>> @@ -1675,9 +1675,6 @@ 
>> rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port)
>>       dev = &rte_eth_devices[port];
>>       internals = dev->data->dev_private;
>>   -    if (check_for_bonded_ethdev(dev) != 0)
>> -        return -1;
>> -
>>       if (bond_8023ad_slow_pkt_hw_filter_supported(port) != 0)
>>           return -1;
>>   @@ -1704,9 +1701,6 @@ 
>> rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port)
>>       dev = &rte_eth_devices[port];
>>       internals = dev->data->dev_private;
>>   -    if (check_for_bonded_ethdev(dev) != 0)
>> -        return -1;
>> -
>>       /* Device must be stopped to set up slow queue */
>>       if (dev->data->dev_started)
>>           return -1;
>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH V2] net/bonding: delete redundant code
  2020-07-17 11:22   ` Wei Hu (Xavier)
@ 2020-07-17 12:46     ` Ferruh Yigit
  2020-07-18  2:29       ` [dpdk-dev] =?gb18030?b?u9i4tKO6IFtkcGRrLXN0YWJsZV0gW1BBVENIIFYy?= =?gb18030?q?=5D_net/bonding=3A_delete_redundant_code?= =?gb18030?B?19S/2MXLtqzR8w==?=
  0 siblings, 1 reply; 5+ messages in thread
From: Ferruh Yigit @ 2020-07-17 12:46 UTC (permalink / raw)
  To: 197020236; +Cc: Wei Hu (Xavier), dev, stable

On 7/17/2020 12:22 PM, Wei Hu (Xavier) wrote:
> Reviewed-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
> 
> 
> On 2020/7/4 9:22, Wei Hu (Xavier) wrote:
>>
>>
>> On 2020/7/4 9:15, 197020236@qq.com wrote:
>>> From: pandongyang <197020236@qq.com>
>>>
>>> The function valid_bonded_port_id() has already contains function
>>> rte_eth_dev_is_valid_port(), so delete redundant check.
>>>
>>> Fixes: 588ae95e7983 ("net/bonding: fix port ID check")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: pandongyang <197020236@qq.com>

Hi pandongyang,

Can you please provide the sign-off in following format:
Name Surname <email@address.com>

We need this to be able to accept the patch.

Thanks,
ferruh


>> Reviewed-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
>>> ---
>>> v1 -> v2: Adjust commit info
>>> ---
>>>   drivers/net/bonding/rte_eth_bond_8023ad.c | 6 ------
>>>   1 file changed, 6 deletions(-)
>>>
>>> diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c 
>>> b/drivers/net/bonding/rte_eth_bond_8023ad.c
>>> index b77a37ddb..339374337 100644
>>> --- a/drivers/net/bonding/rte_eth_bond_8023ad.c
>>> +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
>>> @@ -1675,9 +1675,6 @@ 
>>> rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port)
>>>       dev = &rte_eth_devices[port];
>>>       internals = dev->data->dev_private;
>>>   -    if (check_for_bonded_ethdev(dev) != 0)
>>> -        return -1;
>>> -
>>>       if (bond_8023ad_slow_pkt_hw_filter_supported(port) != 0)
>>>           return -1;
>>>   @@ -1704,9 +1701,6 @@ 
>>> rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port)
>>>       dev = &rte_eth_devices[port];
>>>       internals = dev->data->dev_private;
>>>   -    if (check_for_bonded_ethdev(dev) != 0)
>>> -        return -1;
>>> -
>>>       /* Device must be stopped to set up slow queue */
>>>       if (dev->data->dev_started)
>>>           return -1;
>>
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dpdk-dev] =?gb18030?b?u9i4tKO6IFtkcGRrLXN0YWJsZV0gW1BBVENIIFYy?= =?gb18030?q?=5D_net/bonding=3A_delete_redundant_code?=
  2020-07-17 12:46     ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
@ 2020-07-18  2:29       ` =?gb18030?B?19S/2MXLtqzR8w==?=
  0 siblings, 0 replies; 5+ messages in thread
From: =?gb18030?B?19S/2MXLtqzR8w==?= @ 2020-07-18  2:29 UTC (permalink / raw)
  To: =?gb18030?B?RmVycnVoIFlpZ2l0?=, =?gb18030?B?Y2hhczM=?=,
	=?gb18030?B?ZGV2?=, =?gb18030?B?eGF2aWVyLmh1d2Vp?=

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb18030", Size: 3542 bytes --]

Ok, my signature is :
&nbsp; &nbsp; &nbsp; Dongyang Pan <197020236@qq.com&gt;
Thanks!




------------------&nbsp;ԭʼÓʼþ&nbsp;------------------
·¢¼þÈË:                                                                                                                        "Ferruh Yigit"                                                                                    <ferruh.yigit@intel.com&gt;;
·¢ËÍʱ¼ä:&nbsp;2020Äê7ÔÂ17ÈÕ(ÐÇÆÚÎå) ÍíÉÏ8:46
ÊÕ¼þÈË:&nbsp;"×Ô¿ØÅ˶¬Ñó"<197020236@qq.com&gt;;
³­ËÍ:&nbsp;"Wei Hu (Xavier)"<xavier.huwei@huawei.com&gt;;"dev"<dev@dpdk.org&gt;;"stable"<stable@dpdk.org&gt;;
Ö÷Ìâ:&nbsp;Re: [dpdk-stable] [PATCH V2] net/bonding: delete redundant code



On 7/17/2020 12:22 PM, Wei Hu (Xavier) wrote:
&gt; Reviewed-by: Wei Hu (Xavier) <xavier.huwei@huawei.com&gt;
&gt; 
&gt; 
&gt; On 2020/7/4 9:22, Wei Hu (Xavier) wrote:
&gt;&gt;
&gt;&gt;
&gt;&gt; On 2020/7/4 9:15, 197020236@qq.com wrote:
&gt;&gt;&gt; From: pandongyang <197020236@qq.com&gt;
&gt;&gt;&gt;
&gt;&gt;&gt; The function valid_bonded_port_id() has already contains function
&gt;&gt;&gt; rte_eth_dev_is_valid_port(), so delete redundant check.
&gt;&gt;&gt;
&gt;&gt;&gt; Fixes: 588ae95e7983 ("net/bonding: fix port ID check")
&gt;&gt;&gt; Cc: stable@dpdk.org
&gt;&gt;&gt;
&gt;&gt;&gt; Signed-off-by: pandongyang <197020236@qq.com&gt;

Hi pandongyang,

Can you please provide the sign-off in following format:
Name Surname <email@address.com&gt;

We need this to be able to accept the patch.

Thanks,
ferruh


&gt;&gt; Reviewed-by: Wei Hu (Xavier) <xavier.huwei@huawei.com&gt;
&gt;&gt;&gt; ---
&gt;&gt;&gt; v1 -&gt; v2: Adjust commit info
&gt;&gt;&gt; ---
&gt;&gt;&gt;&nbsp;&nbsp; drivers/net/bonding/rte_eth_bond_8023ad.c | 6 ------
&gt;&gt;&gt;&nbsp;&nbsp; 1 file changed, 6 deletions(-)
&gt;&gt;&gt;
&gt;&gt;&gt; diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c 
&gt;&gt;&gt; b/drivers/net/bonding/rte_eth_bond_8023ad.c
&gt;&gt;&gt; index b77a37ddb..339374337 100644
&gt;&gt;&gt; --- a/drivers/net/bonding/rte_eth_bond_8023ad.c
&gt;&gt;&gt; +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
&gt;&gt;&gt; @@ -1675,9 +1675,6 @@ 
&gt;&gt;&gt; rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port)
&gt;&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; dev = &amp;rte_eth_devices[port];
&gt;&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; internals = dev-&gt;data-&gt;dev_private;
&gt;&gt;&gt;&nbsp;&nbsp; -&nbsp;&nbsp;&nbsp; if (check_for_bonded_ethdev(dev) != 0)
&gt;&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return -1;
&gt;&gt;&gt; -
&gt;&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (bond_8023ad_slow_pkt_hw_filter_supported(port) != 0)
&gt;&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return -1;
&gt;&gt;&gt;&nbsp;&nbsp; @@ -1704,9 +1701,6 @@ 
&gt;&gt;&gt; rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port)
&gt;&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; dev = &amp;rte_eth_devices[port];
&gt;&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; internals = dev-&gt;data-&gt;dev_private;
&gt;&gt;&gt;&nbsp;&nbsp; -&nbsp;&nbsp;&nbsp; if (check_for_bonded_ethdev(dev) != 0)
&gt;&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return -1;
&gt;&gt;&gt; -
&gt;&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; /* Device must be stopped to set up slow queue */
&gt;&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (dev-&gt;data-&gt;dev_started)
&gt;&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return -1;
&gt;&gt;
&gt;

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH V2] net/bonding: delete redundant code
  2020-07-04  1:22 ` [dpdk-dev] [PATCH V2] net/bonding: delete redundant code Wei Hu (Xavier)
  2020-07-17 11:22   ` Wei Hu (Xavier)
@ 2020-07-20 22:51   ` Ferruh Yigit
  1 sibling, 0 replies; 5+ messages in thread
From: Ferruh Yigit @ 2020-07-20 22:51 UTC (permalink / raw)
  To: Wei Hu (Xavier), 197020236; +Cc: dev, stable

On 7/4/2020 2:22 AM, Wei Hu (Xavier) wrote:
> 
> 
> On 2020/7/4 9:15, 197020236@qq.com wrote:
>> From: pandongyang <197020236@qq.com>
>>
>> The function valid_bonded_port_id() has already contains function
>> rte_eth_dev_is_valid_port(), so delete redundant check.
>>
>> Fixes: 588ae95e7983 ("net/bonding: fix port ID check")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: pandongyang <197020236@qq.com>
>
> Signed-off-by: Dongyang Pan <197020236@qq.com>
>
> Reviewed-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
>

Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-07-20 22:51 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20878f97-ff83-4f39-b603-bcd8379fa5a9@DGGEMS414-HUB.china.huawei.com>
2020-07-04  1:22 ` [dpdk-dev] [PATCH V2] net/bonding: delete redundant code Wei Hu (Xavier)
2020-07-17 11:22   ` Wei Hu (Xavier)
2020-07-17 12:46     ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2020-07-18  2:29       ` [dpdk-dev] =?gb18030?b?u9i4tKO6IFtkcGRrLXN0YWJsZV0gW1BBVENIIFYy?= =?gb18030?q?=5D_net/bonding=3A_delete_redundant_code?= =?gb18030?B?19S/2MXLtqzR8w==?=
2020-07-20 22:51   ` [dpdk-dev] [dpdk-stable] [PATCH V2] net/bonding: delete redundant code Ferruh Yigit

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git