From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Jastrzebski, MichalX K" <michalx.k.jastrzebski@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] testpmd: check return value of rte_eth_dev_vlan_filter()
Date: Tue, 27 Jan 2015 23:22:11 +0100 [thread overview]
Message-ID: <59280674.3ZXkOACZBp@xps13> (raw)
In-Reply-To: <60ABE07DBB3A454EB7FAD707B4BB1582138D57F7@IRSMSX109.ger.corp.intel.com>
2015-01-27 15:58, Jastrzebski, MichalX K:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > And more importantly, you make it clear that sometimes we cannot enable
> > all vlans and return no error.
>
> Should I return this error somewhere? Isn't just printing the error best option here?
Yes printing a warning before "break" seems a good idea.
> > So I wonder how is it documented in the testpmd help?
>
> I can add a note in testpmd_funcs.rst file or I can place some info in .help_str?
> What do you mean "testpmd help"?
I mean both :)
But maybe it's not appropriate in .help_str, I'm not sure.
--
Thomas
prev parent reply other threads:[~2015-01-27 22:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 10:43 Michal Jastrzebski
2015-01-27 10:33 ` Thomas Monjalon
2015-01-27 15:58 ` Jastrzebski, MichalX K
2015-01-27 22:22 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59280674.3ZXkOACZBp@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=michalx.k.jastrzebski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).