From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f175.google.com (mail-we0-f175.google.com [74.125.82.175]) by dpdk.org (Postfix) with ESMTP id 13ABF18F for ; Tue, 27 Jan 2015 23:22:40 +0100 (CET) Received: by mail-we0-f175.google.com with SMTP id p10so17544705wes.6 for ; Tue, 27 Jan 2015 14:22:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=srrrJATu80aqiSbUO4O9yI605cosDotro6+3gBBuB7s=; b=htMPGR5SuGuh7N5YeeftQSg+p2qB2uaWFBe9uhCIZV9+AeJ8jW045aSVJlSnSFEfoK oTM5/f5nGqg8KRZatJWCVwjUDf9MbLBlx7EC3MXzCSX6037fkDXUZIbzVQCC4rukKNMo CrFCVkxRHzmoj2qSYy2WVz1G3+kzrAu6gtbT9NzUZPJNw9u6ErzREKVClToxwpesGKWE AkuXsCDincfkidOOlemRkhzfsMiTNaSp+ovAqF8utVhP8YIXl/r1AUUXhBFtk5b1sNQS +gT/g0pgSDsQYfhIzWFImIZZnwYqn5RYdpJfE8z028nhHfO8vxfmf22+85bwjhn95tzO 3tJw== X-Gm-Message-State: ALoCoQndkFL4U2XA+sQu37PGhVGRGy63uPY8OHAG/GPczyvGrZzwrfkTPfagL2+lw/ov9dgeeqQp X-Received: by 10.194.90.143 with SMTP id bw15mr544278wjb.132.1422397359526; Tue, 27 Jan 2015 14:22:39 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id mz10sm279483wic.9.2015.01.27.14.22.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Jan 2015 14:22:38 -0800 (PST) From: Thomas Monjalon To: "Jastrzebski, MichalX K" Date: Tue, 27 Jan 2015 23:22:11 +0100 Message-ID: <59280674.3ZXkOACZBp@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.18.2-2-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <60ABE07DBB3A454EB7FAD707B4BB1582138D57F7@IRSMSX109.ger.corp.intel.com> References: <1422009831-11092-1-git-send-email-michalx.k.jastrzebski@intel.com> <3441479.cVrRmaIGdi@xps13> <60ABE07DBB3A454EB7FAD707B4BB1582138D57F7@IRSMSX109.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] testpmd: check return value of rte_eth_dev_vlan_filter() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jan 2015 22:22:40 -0000 2015-01-27 15:58, Jastrzebski, MichalX K: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > And more importantly, you make it clear that sometimes we cannot enable > > all vlans and return no error. > > Should I return this error somewhere? Isn't just printing the error best option here? Yes printing a warning before "break" seems a good idea. > > So I wonder how is it documented in the testpmd help? > > I can add a note in testpmd_funcs.rst file or I can place some info in .help_str? > What do you mean "testpmd help"? I mean both :) But maybe it's not appropriate in .help_str, I'm not sure. -- Thomas