From: "Mattias Rönnblom" <hofors@lysator.liu.se>
To: David Marchand <david.marchand@redhat.com>
Cc: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>,
dev@dpdk.org, harry.van.haaren@intel.com,
"Stefan Sundkvist" <stefan.sundkvist@ericsson.com>
Subject: Re: [PATCH v2] service: extend service function call statistics
Date: Wed, 2 Oct 2024 21:43:38 +0200 [thread overview]
Message-ID: <593704a9-fb19-4d95-895a-af019e70b7c9@lysator.liu.se> (raw)
In-Reply-To: <CAJFAV8x1NOeZMjuAnF7_Hru6vdoe8HGbqKpoBvVWxyADnKZbNA@mail.gmail.com>
On 2024-10-02 21:08, David Marchand wrote:
> On Wed, Oct 2, 2024 at 8:57 PM Mattias Rönnblom <hofors@lysator.liu.se> wrote:
>>> Coverity flagged this patch with issue #445158.
>>> rte_delay_ms() is now unreachable.
>>>
>>> I suppose this delay is not that important for the unit test and we
>>> can remove it, but as I am not sure I'll let you have a look and send
>>> a fix.
>>>
>>
>> It works without it I think, but I would keep it, and add it to the
>> "case 0" branch.
>>
>> Let me know if you want a v2.
>
> Unfortunately, coverity is run only for merged stuff.
> So the report we got is for merged patch in the main repo.
>
> Please send a fix.
>
Done.
I decided I could just as well reintroduce the old behavior. You could
refactor away all this sleeping business I think, but that is for
another day.
next prev parent reply other threads:[~2024-10-02 19:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 19:15 [RFC] " Mattias Rönnblom
2024-01-25 23:19 ` Morten Brørup
2024-01-26 8:28 ` Mattias Rönnblom
2024-01-26 10:07 ` Morten Brørup
2024-01-27 19:31 ` Mattias Rönnblom
2024-01-29 12:50 ` Van Haaren, Harry
2024-01-30 7:16 ` Mattias Rönnblom
2024-08-09 20:25 ` [PATCH] " Mattias Rönnblom
2024-09-09 19:11 ` [PATCH v2] " Mattias Rönnblom
2024-09-10 1:19 ` fengchengwen
2024-09-10 7:19 ` Mattias Rönnblom
2024-09-12 9:18 ` Van Haaren, Harry
2024-10-01 15:24 ` David Marchand
2024-10-02 18:26 ` David Marchand
2024-10-02 18:56 ` Mattias Rönnblom
2024-10-02 19:08 ` David Marchand
2024-10-02 19:43 ` Mattias Rönnblom [this message]
2024-10-03 9:53 ` Van Haaren, Harry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=593704a9-fb19-4d95-895a-af019e70b7c9@lysator.liu.se \
--to=hofors@lysator.liu.se \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=stefan.sundkvist@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).