From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id DA2B245A82;
	Wed,  2 Oct 2024 21:43:43 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 9EEE74029B;
	Wed,  2 Oct 2024 21:43:43 +0200 (CEST)
Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3])
 by mails.dpdk.org (Postfix) with ESMTP id 1A88640285
 for <dev@dpdk.org>; Wed,  2 Oct 2024 21:43:42 +0200 (CEST)
Received: from mail.lysator.liu.se (localhost [127.0.0.1])
 by mail.lysator.liu.se (Postfix) with ESMTP id 5E4691D93F
 for <dev@dpdk.org>; Wed,  2 Oct 2024 21:43:41 +0200 (CEST)
Received: by mail.lysator.liu.se (Postfix, from userid 1004)
 id 367C71D8D2; Wed,  2 Oct 2024 21:43:41 +0200 (CEST)
X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on
 hermod.lysator.liu.se
X-Spam-Level: 
X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,AWL,
 T_SCC_BODY_TEXT_LINE autolearn=disabled version=4.0.0
X-Spam-Score: -1.2
Received: from [192.168.1.86] (h-62-63-215-114.A163.priv.bahnhof.se
 [62.63.215.114])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by mail.lysator.liu.se (Postfix) with ESMTPSA id 3D8041D84E;
 Wed,  2 Oct 2024 21:43:39 +0200 (CEST)
Message-ID: <593704a9-fb19-4d95-895a-af019e70b7c9@lysator.liu.se>
Date: Wed, 2 Oct 2024 21:43:38 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] service: extend service function call statistics
To: David Marchand <david.marchand@redhat.com>
Cc: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,
 dev@dpdk.org, harry.van.haaren@intel.com,
 Stefan Sundkvist <stefan.sundkvist@ericsson.com>
References: <20240809202539.590510-1-mattias.ronnblom@ericsson.com>
 <20240909191103.697554-1-mattias.ronnblom@ericsson.com>
 <CAJFAV8wz6H8oaZ2DzL6L6SxkytyYFys5Wx6F-AjpuJ8862177A@mail.gmail.com>
 <de48daed-7b77-4405-ba6e-9d94c0513593@lysator.liu.se>
 <CAJFAV8x1NOeZMjuAnF7_Hru6vdoe8HGbqKpoBvVWxyADnKZbNA@mail.gmail.com>
Content-Language: en-US
From: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= <hofors@lysator.liu.se>
In-Reply-To: <CAJFAV8x1NOeZMjuAnF7_Hru6vdoe8HGbqKpoBvVWxyADnKZbNA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Virus-Scanned: ClamAV using ClamSMTP
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 2024-10-02 21:08, David Marchand wrote:
> On Wed, Oct 2, 2024 at 8:57 PM Mattias Rönnblom <hofors@lysator.liu.se> wrote:
>>> Coverity flagged this patch with issue #445158.
>>> rte_delay_ms() is now unreachable.
>>>
>>> I suppose this delay is not that important for the unit test and we
>>> can remove it, but as I am not sure I'll let you have a look and send
>>> a fix.
>>>
>>
>> It works without it I think, but I would keep it, and add it to the
>> "case 0" branch.
>>
>> Let me know if you want a v2.
> 
> Unfortunately, coverity is run only for merged stuff.
> So the report we got is for merged patch in the main repo.
> 
> Please send a fix.
> 

Done.

I decided I could just as well reintroduce the old behavior. You could 
refactor away all this sleeping business I think, but that is for 
another day.