DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Cc: dev@dpdk.org, Yipeng Wang <yipeng1.wang@intel.com>,
	Sameh Gobriel <sameh.gobriel@intel.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Pablo de Lara <pablo.de.lara.guarch@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash
Date: Wed, 06 Feb 2019 11:38:57 +0100	[thread overview]
Message-ID: <5937441.0T0pBNs0GK@xps> (raw)
In-Reply-To: <1549375057-4211-2-git-send-email-vladimir.medvedkin@intel.com>

05/02/2019 14:57, Vladimir Medvedkin:
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> +M: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> +F: lib/librte_hash/rte_thash.h

I'm not sure about adding maintainership for one file.
You are the author of this file, so you should be consulted
during reviews if you don't catch them by yourself.
But I prefer seeing maintainers as taking charge and understanding of
a full library as a block.

And unfortunately, it does not work with the script:
	devtools/get-maintainer.sh lib/librte_hash/rte_cuckoo_hash.h
You would appear as maintainer for all hash files.

  reply	other threads:[~2019-02-06 10:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-03 16:34 [dpdk-dev] [PATCH] maintainers: claim co-maintainership of LPM Vladimir Medvedkin
2019-02-03 16:34 ` [dpdk-dev] [PATCH] maintainers: claim maintainership of Toeplitz hash Vladimir Medvedkin
2019-02-05 13:57   ` [dpdk-dev] [PATCH v2] " Vladimir Medvedkin
2019-02-06 10:38     ` Thomas Monjalon [this message]
2019-02-07 19:28       ` Medvedkin, Vladimir
2019-02-07 21:24         ` Thomas Monjalon
2019-02-07 21:32           ` Gobriel, Sameh
2019-02-07 23:13             ` Wang, Yipeng1
2019-02-08 11:34               ` Medvedkin, Vladimir
2019-02-03 16:34 ` [dpdk-dev] [PATCH] rte_thash: replace license text with SPDX tag Vladimir Medvedkin
2019-02-05 13:57   ` [dpdk-dev] [PATCH v2] " Vladimir Medvedkin
2019-02-06 10:45     ` Thomas Monjalon
2019-02-04  9:58 ` [dpdk-dev] [PATCH] maintainers: claim co-maintainership of LPM Bruce Richardson
2019-02-05 13:57 ` [dpdk-dev] [PATCH v2] " Vladimir Medvedkin
2019-02-06 10:41   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5937441.0T0pBNs0GK@xps \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=sameh.gobriel@intel.com \
    --cc=vladimir.medvedkin@intel.com \
    --cc=yipeng1.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).