From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <andy.pei@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
by dpdk.org (Postfix) with ESMTP id 1A7CC29CB;
Tue, 23 Apr 2019 03:24:30 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
22 Apr 2019 18:24:30 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,383,1549958400"; d="scan'208";a="166973781"
Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206])
by fmsmga001.fm.intel.com with ESMTP; 22 Apr 2019 18:19:30 -0700
Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by
FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS)
id 14.3.408.0; Mon, 22 Apr 2019 18:19:29 -0700
Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by
FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS)
id 14.3.408.0; Mon, 22 Apr 2019 18:19:29 -0700
Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.25]) by
SHSMSX103.ccr.corp.intel.com ([169.254.4.93]) with mapi id 14.03.0415.000;
Tue, 23 Apr 2019 09:19:28 +0800
From: "Pei, Andy" <andy.pei@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, "Xu, Rosen" <rosen.xu@intel.com>
CC: "stable@dpdk.org" <stable@dpdk.org>, "dev@dpdk.org" <dev@dpdk.org>,
"Kovacevic, Marko" <marko.kovacevic@intel.com>, "liq3ea@163.com"
<liq3ea@163.com>
Thread-Topic: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte
fpga do pr
Thread-Index: AQHU+TQrsiKyHWiccUeFrB7zp9m+y6ZI8kyw
Date: Tue, 23 Apr 2019 01:19:26 +0000
Message-ID: <5941F446C088714A85408FA3132CFCBB0100B26D@SHSMSX105.ccr.corp.intel.com>
References: <1555483757-48188-1-git-send-email-andy.pei@intel.com>
<1555485388-50214-1-git-send-email-andy.pei@intel.com>
<0E78D399C70DA940A335608C6ED296D73A6B85AA@SHSMSX104.ccr.corp.intel.com>
<1609679.gfMthc3lC5@xps>
In-Reply-To: <1609679.gfMthc3lC5@xps>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd
leak in rte fpga do pr
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Apr 2019 01:24:31 -0000
Hi Thomas,
My patch is the same as LI Qiang's patch.
I was told that Qiang's patch cannot get onto the patchwork, so I just help=
him do this.
-----Original Message-----
From: Thomas Monjalon [mailto:thomas@monjalon.net]=20
Sent: Tuesday, April 23, 2019 1:52 AM
To: Xu, Rosen <rosen.xu@intel.com>; Pei, Andy <andy.pei@intel.com>
Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko <marko.kovacevic@intel.=
com>; liq3ea@163.com
Subject: Re: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte =
fpga do pr
> > In rte_fpga_do_pr() function, if 'stat' returns error,
> > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that=20
> > has been opened.
> > After this patch, 'file_fd' is closed before rte_fpga_do_pr()=20
> > returns -EINVAL when 'stat' returns error
> >=20
> > Coverity issue: 279441
> > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
> > Cc: rosen.xu@intel.com
> > Cc: marko.kovacevic@intel.com
> > Cc: liq3ea@163.com
> > Cc: andy.pei@intel.com
> > Cc: stable@dpdk.org
> >=20
> > Signed-off-by: Andy Pei <andy.pei@intel.com>
>=20
> Acked-by: Rosen Xu <rosen.xu@intel.com>
Li Qiang <liq3ea@163.com> proposed the same patch.
Why he is not referenced here?
Which patch should I merge?
From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id D61F6A05D3
for <public@inbox.dpdk.org>; Tue, 23 Apr 2019 03:24:33 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id B20291B493;
Tue, 23 Apr 2019 03:24:32 +0200 (CEST)
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
by dpdk.org (Postfix) with ESMTP id 1A7CC29CB;
Tue, 23 Apr 2019 03:24:30 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
22 Apr 2019 18:24:30 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,383,1549958400"; d="scan'208";a="166973781"
Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206])
by fmsmga001.fm.intel.com with ESMTP; 22 Apr 2019 18:19:30 -0700
Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by
FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS)
id 14.3.408.0; Mon, 22 Apr 2019 18:19:29 -0700
Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by
FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS)
id 14.3.408.0; Mon, 22 Apr 2019 18:19:29 -0700
Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.25]) by
SHSMSX103.ccr.corp.intel.com ([169.254.4.93]) with mapi id 14.03.0415.000;
Tue, 23 Apr 2019 09:19:28 +0800
From: "Pei, Andy" <andy.pei@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, "Xu, Rosen" <rosen.xu@intel.com>
CC: "stable@dpdk.org" <stable@dpdk.org>, "dev@dpdk.org" <dev@dpdk.org>,
"Kovacevic, Marko" <marko.kovacevic@intel.com>, "liq3ea@163.com"
<liq3ea@163.com>
Thread-Topic: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte
fpga do pr
Thread-Index: AQHU+TQrsiKyHWiccUeFrB7zp9m+y6ZI8kyw
Date: Tue, 23 Apr 2019 01:19:26 +0000
Message-ID:
<5941F446C088714A85408FA3132CFCBB0100B26D@SHSMSX105.ccr.corp.intel.com>
References: <1555483757-48188-1-git-send-email-andy.pei@intel.com>
<1555485388-50214-1-git-send-email-andy.pei@intel.com>
<0E78D399C70DA940A335608C6ED296D73A6B85AA@SHSMSX104.ccr.corp.intel.com>
<1609679.gfMthc3lC5@xps>
In-Reply-To: <1609679.gfMthc3lC5@xps>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd
leak in rte fpga do pr
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190423011926.Rs31cFzvIlxJ5Yruj3qwuWl6mQ7_51RlBOynDHW-Uh8@z>
Hi Thomas,
My patch is the same as LI Qiang's patch.
I was told that Qiang's patch cannot get onto the patchwork, so I just help=
him do this.
-----Original Message-----
From: Thomas Monjalon [mailto:thomas@monjalon.net]=20
Sent: Tuesday, April 23, 2019 1:52 AM
To: Xu, Rosen <rosen.xu@intel.com>; Pei, Andy <andy.pei@intel.com>
Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko <marko.kovacevic@intel.=
com>; liq3ea@163.com
Subject: Re: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte =
fpga do pr
> > In rte_fpga_do_pr() function, if 'stat' returns error,
> > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that=20
> > has been opened.
> > After this patch, 'file_fd' is closed before rte_fpga_do_pr()=20
> > returns -EINVAL when 'stat' returns error
> >=20
> > Coverity issue: 279441
> > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
> > Cc: rosen.xu@intel.com
> > Cc: marko.kovacevic@intel.com
> > Cc: liq3ea@163.com
> > Cc: andy.pei@intel.com
> > Cc: stable@dpdk.org
> >=20
> > Signed-off-by: Andy Pei <andy.pei@intel.com>
>=20
> Acked-by: Rosen Xu <rosen.xu@intel.com>
Li Qiang <liq3ea@163.com> proposed the same patch.
Why he is not referenced here?
Which patch should I merge?