Re: [dpdk-dev] [PATCH] net/i40e: i40e rework for ipn3ke

["Pei, Andy" <andy.pei@intel.com>]

Hi, Ferruh

Thanks a lot. Your tips is really helpful, and I will follow this in the future.

-----Original Message-----
From: Yigit, Ferruh 
Sent: Friday, May 24, 2019 9:12 PM
To: Xu, Rosen <rosen.xu@intel.com>; Pei, Andy <andy.pei@intel.com>; dev@dpdk.org
Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>
Subject: Re: [PATCH] net/i40e: i40e rework for ipn3ke

On 5/24/2019 2:05 AM, Xu, Rosen wrote:
> Hi,
> 
>> -----Original Message-----
>> From: Pei, Andy
>> Sent: Thursday, May 23, 2019 17:15
>> To: dev@dpdk.org
>> Cc: Pei, Andy <andy.pei@intel.com>; Zhang, Roy Fan 
>> <roy.fan.zhang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, 
>> Jingjing <jingjing.wu@intel.com>; Xing, Beilei 
>> <beilei.xing@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; Xu, 
>> Rosen <rosen.xu@intel.com>
>> Subject: [PATCH] net/i40e: i40e rework for ipn3ke
> 
>> Add switch_mode argument for i40e PF to specify the specific FPGA 
>> that i40e PF is connected to.
>> i40e PF get link status update via the connected FPGA.
>>
>> Fixes: c60869e2b742 ("net/i40e: fix link status update")
>> Cc: roy.fan.zhang@intel.com
>> Cc: qi.z.zhang@intel.com
>> Cc: jingjing.wu@intel.com
>> Cc: beilei.xing@intel.com
>> Cc: ferruh.yigit@intel.com
>> Cc: rosen.xu@intel.com
> 
> My understanding cc people should add in git send-email not in patch.

"git send-email" is picking the names from commit log, so putting the names in the commit log is another way, but as you said at the end of the day we don't want names be in the git history.
But what can be done is, putting the names after "---" works for both, those names still will be picked by "git send-email" and cc'ed automatically, and this information is part of the patch meanwhile they will be stripped automatically when merged, so they won't be in the git history without causing manual cleanup task to maintainers.

> 
>> Signed-off-by: Andy Pei <andy.pei@intel.com>
>> ---

<----- HERE

>>  drivers/net/i40e/i40e_ethdev.c | 128
>> +++++++++++++++++++++++++++++++++++++++--
>>  1 file changed, 122 insertions(+), 6 deletions(-)
>>

<...>